itop-communications not working with iTop 3.2?

[Jeffrey Bostoen]

https://www.itophub.io/wiki/page?id=latest:release:extensions

Communications to the Customers
iTop 3.2: recommends using extension version 1.3.4
Symfony 6.4 deprecated calls
Not working on portal ???

So, it's indeed breaking the portal? Does Combodo already have a working version? Or did I upgrade too soon? :)

[Jeffrey Bostoen]

Seems it can be quickly fixed with a proper construct, just not sure if Combodo already had it internal and it just needs to be pushed to GitHub / iTop Hub :)

class CommunicationBrickController extends BrickController
{

    /**
     * @param \Combodo\iTop\Portal\Brick\BrickCollection $oBrickCollection
     *
     * @since 3.2.0 N°6933
     */
    public function __construct(
        protected BrickCollection $oBrickCollection,
    )
    {
    }

...

[Vincent @ Combodo]

Hi Jeffrey,
The comment was not very clear, the explanation "Not working on portal ???" was related to version 1.3.3. I just changed it to remove the ambiguity.
The 1.3.4 is fully compatible and does work in portal. We have been using it for 3 months internally. I have just tested it again, in case.
So if you encounter en issue, I'd be interested in the details to reproduce it.

[Jeffrey Bostoen]

Hm, I downloaded the 1.3.4 version.
I used it with the iTop Community version 3.2.0.
It did not seem to include a construct method for the brick controller.

When I accessed the portal, it was complaining about a deprecated call (the fallback to the "get" method used in previous versions) and effectively broke my portal until I added the constructor.