Garbled CGUIFileOpenDialog fix patch in Non latin code
3D Engine c++
Brought to you by:
cutealien,
nimphoenix2
Fix problem that CGUIFileOpenDialog is garbled when Fileaname written in Non latin code is displayed. (ex. Japanese)
screenshot http://etwas.wolfish.org/files/CGUIFileOpenDialog-Fix.png
garbled CGUIFileOpenDialog fix SVN patch
I think it may be better to update the FileList and FileSystem instead.
Does this only apply for Windows machines, or do the other operating systems return multibyte strings instead of wide chars?
Yes. It is necessary to apply this patch at least in Ubuntu 8.10 ja-JP(UTF).
>I think it may be better to update the FileList and FileSystem instead.
I don't think so.
Because This is a problem only in the GUI.
The FileList and FileSystem should keep the c8 type file name.
For instance, if the FileList and FileSystem have only converted wide chars, FileLoader can't be read the selected file.
Wow, nobody is me.
I noticed CReadFile use fopen() (not wfopen).
So, if the FileList and FileSystem are updated, it is necessary to update The CReadFile and CWriteFile, too.
I will try making the wide chars patch of FileSystem.
Do I upload a new patch to this thread ? Or a new thread?
To begin support for other languages, I guess we'll have to support wide chars in all parts of the engine! Please upload to this patch :)
This patch has been accepted and commited to SVN. It will be part of the next release.
This is patch is now applied, although the fix really should be in UTF8 support in core::string.
We really need help with internationalization!