#441 HMAC_MD5 and HMAC_SHA256 patches

[Holger Liebig]

Patches for supporting cipher suites 6/7/8 (HMAC-MD5) and cipher suite 17 (HMAC_SHA256). Patch is against 1.8.13RC1 source.

[Zdenek Styblik]

This isn't going to work(do anything), is it? So why is it there? Also, please, clean up the formatting.

#ifdef HAVE_CRYPTO_SHA256
#if 0
    case 15: // Note: Cipher Suite ID not (yet) confirmed in IPMI Spec or Errata 4
        *auth_alg      = IPMI_AUTH_RAKP_HMAC_SHA256;
        *integrity_alg = IPMI_INTEGRITY_NONE;
        *crypt_alg     = IPMI_CRYPT_NONE;
        break;
    case 16: // Note: Cipher Suite ID not (yet) confirmed in IPMI Spec or Errata 4
        *auth_alg      = IPMI_AUTH_RAKP_HMAC_SHA256;
        *integrity_alg = IPMI_INTEGRITY_HMAC_SHA256_128;
        *crypt_alg     = IPMI_CRYPT_NONE;
        break;
#endif
    case 17: // Note: Cipher Suite Id from DCMI 1.1 Spec
        *auth_alg      = IPMI_AUTH_RAKP_HMAC_SHA256;
        *integrity_alg = IPMI_INTEGRITY_HMAC_SHA256_128;
        *crypt_alg     = IPMI_CRYPT_AES_CBC_128;
        break;

#endif // HAVE_CRYPTO_SHA256

[Holger Liebig]

From: Zdenek Styblik [mailto:stybla@users.sf.net]
Sent: Tuesday, September 09, 2014 5:39 AM
To: [ipmitool:patches]
Subject: [ipmitool:patches] #82 HMAC_MD5 and HMAC_SHA256 patches

• status: open --> pending
• Comment:

This isn't going to work(do anything), is it? So why is it there? Also, please, clean up the formatting.

[Liebig, Holger] At the time of the original patch only cipher suite 17 was officially confirmed by Intel as a RAKP_HMAC_SHA256 cipher suite. It was introduced with the DCMI 1.1 Spec and later with the Errata 4 of the IPMI 2.0 Spec. Only Errata 5 and 6 (minor fixes for IPv6) of the IPMI 2.0 Spec confirm the other id's together with the RC4 in table 22-19 (page 292 in ipmi-v2-rev1-1-spec-errata-6-markup.pdf). I have to admit that I did not update the code/patch afterwards.

Let me know if you have any questions.

Thanks,
Holger

ifdef HAVE_CRYPTO_SHA256

if 0

case 15: // Note: Cipher Suite ID not (yet) confirmed in IPMI Spec or Errata 4

    *auth_alg      = IPMI_AUTH_RAKP_HMAC_SHA256;

    *integrity_alg = IPMI_INTEGRITY_NONE;

    *crypt_alg     = IPMI_CRYPT_NONE;

    break;

case 16: // Note: Cipher Suite ID not (yet) confirmed in IPMI Spec or Errata 4

    *auth_alg      = IPMI_AUTH_RAKP_HMAC_SHA256;

    *integrity_alg = IPMI_INTEGRITY_HMAC_SHA256_128;

    *crypt_alg     = IPMI_CRYPT_NONE;

    break;

endif

case 17: // Note: Cipher Suite Id from DCMI 1.1 Spec

    *auth_alg      = IPMI_AUTH_RAKP_HMAC_SHA256;

    *integrity_alg = IPMI_INTEGRITY_HMAC_SHA256_128;

    *crypt_alg     = IPMI_CRYPT_AES_CBC_128;

    break;

endif // HAVE_CRYPTO_SHA256

---

[patches:#82]http://sourceforge.net/p/ipmitool/patches/82 HMAC_MD5 and HMAC_SHA256 patches

Status: pending
Group: version-1.8.14
Created: Mon Sep 02, 2013 01:12 PM UTC by Holger Liebig
Last Updated: Mon Sep 02, 2013 01:12 PM UTC
Owner: nobody

Patches for supporting cipher suites 6/7/8 (HMAC-MD5) and cipher suite 17 (HMAC_SHA256). Patch is against 1.8.13RC1 source.

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/ipmitool/patches/82/https://sourceforge.net/p/ipmitool/patches/82

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/https://sourceforge.net/auth/subscriptions

[Zdenek Styblik]

Well, I'm confused why commended out code should be there. Either uncomment it or remove it.

Thanks.

[Zdenek Styblik]

Just to make it clear.

1. clean up code formatting - I see some white-spaces where tabs should be
2. decide whether to drop code enclosed in #ifdef 0 ... #endif or drop #ifdef 0 itself. As I've said, I see no point in including dead/unreachable code.

Other than that, I see no problem in giving this commit.

Cheers!

[Florian Breu]

Hello Zdenek,

i did some cleanup on this patch and posted it in this Bug: https://sourceforge.net/p/ipmitool/bugs/141/#7e44

best regards,
Florian

[Zdenek Styblik]

Reminder for myself - give this a look.

[Zdenek Styblik]

Ticket moved from /p/ipmitool/patches/82/

[Zdenek Styblik]

Committed into git.
Also fixes I'm closing this as a duplicate of https://sourceforge.net/p/ipmitool/bugs/442/ and I'm closing this as a duplicate of https://sourceforge.net/p/ipmitool/bugs/141/.

Thanks.