From: Alan H. <al...@us...> - 2003-08-31 16:56:34
|
Update of /cvsroot/ipcop/ipcop/src/misc-progs In directory sc8-pr-cvs1:/tmp/cvs-serv10256/src/misc-progs Modified Files: Tag: IPCOP_v1 rebuildhosts.c Log Message: add RFC1035 error checking to hosts.cgi and remove the error checking from rebuildhosts.c so that all error checking should be done through the CGI script so what's displayed on the web page is consistent with what should be done to /etc/hosts. (still need to check for duplicate hostnames) Index: rebuildhosts.c =================================================================== RCS file: /cvsroot/ipcop/ipcop/src/misc-progs/Attic/rebuildhosts.c,v retrieving revision 1.1.2.2 retrieving revision 1.1.2.3 diff -C2 -d -r1.1.2.2 -r1.1.2.3 *** rebuildhosts.c 26 Aug 2003 15:03:18 -0000 1.1.2.2 --- rebuildhosts.c 31 Aug 2003 16:56:26 -0000 1.1.2.3 *************** *** 78,93 **** break; ! if (strspn(ip, IP_NUMBERS) != strlen(ip)) ! { ! fprintf(stderr, "Bad IP: %s\n", ip); ! goto EXIT; ! } ! ! if (strspn(host, LETTERS_NUMBERS) != strlen(host)) ! { ! fprintf(stderr, "Bad Host: %s\n", host); ! goto EXIT; ! } ! if (domain) fprintf(hosts, "%s\t%s\t%s.%s\n",ip,host,host,domain); --- 78,87 ---- break; ! /* ! * Error checking is done in the CGI script, so if any ! * bad data gets here, we should really fix the CGI script ! * so we don't get inconsistent results with what's displayed ! * on the web page. ! */ if (domain) fprintf(hosts, "%s\t%s\t%s.%s\n",ip,host,host,domain); |