Re: [IPCop-devel] patch for general-functions.pl sub validedmail longer than 3 chars

[John E. <jo...@co...>]

On Wed, Jun 29, 2005 at 02:20:26AM +0200, Franck Bourdonnec wrote:
> Le Mercredi 29 Juin 2005 00:17, John Edwards a =E9crit :
>=20
>> While I was looking at this, I was thinking either a single file or
>> prepending 'cpan-' to the lfs file would be tidier.
>>
>> Including the modules required for my patch we are currently at 8 CPAN
>> modules:
>> Digest
>> Digest-HMAC
>> Digest-SHA1
>> Email-Valid
>> GD
>> MailTools
>> Net-DNS
>> Net-IPv4Addr
>>
>>
>> I'm not deeply familiar with Linux from Scratch but from what I can
>> see having seperate files means:
>>
>> 1) Each module is run as it's own build process launched from make.sh
>> and creates it's own log file. Would this make things easier to debug?

>> 2) Each module contains it's own variables in line with what appears
>> to be the LFS standard - eg "VER", "DL_FROM", "md5", etc. I suspect
>> that placing multiple download files in a single lfs file would
>> complicate matters.

> I prefer (imho) to limit number a files making a project.
> Theses can be seen as pacth to apply to Perl, One file.
> We can also group two or more cpan modules in one
> 'patch' file =3D> MailTool&ValidEmail
> 'patch' file =3D> Net-DNS&NetIPv4
> 'patch' file =3D> Digest&Digest-HMAC/SHA1 & SSL
>=20
> This limits number of files...   Good not good ?

That would still have the problem with needing to put multiple=20
variables into each file, one set for each module.

Some of the answers to these questions are probably in the LFSmake and
GNU make docs:
	http://www.sunsetsystems.com/lfsdoc.php3
	http://www.gnu.org/software/make/


IIRC 'make' has lists, but not any more complex arrays. So I think=20
it can be done if we roll the module name, version and CPAN download=20
directory together and just have a list of those, some like:

DL_FILES =3D Email/Email-Valid-0.15.tar.gz Mail/MailTools-1.67.tar.gz
DL_FROM =3D $(subst %,%$(URL_CPAN)/,$(DL_FILES))

(above is completely untested and probably wrong)

The drawback is that we lose seperate variables for the module name=20
("THISAPP" and "DL_FILE"), version number ("VER") and CPAN directory=20
("DL_FROM"). Of these I think the only one that is likely to cause a=20
problem is the version number, and I can't see that it's used anywhere=20
for the CPAN modules (though it is for Perl itself).

I'll see if I can have a little play with make scripts tomorrow.


--=20
#---------------------------------------------------------#
|    John Edwards   Email: jo...@co...    |
|                                                         |
| A. Because it breaks the logical sequence of discussion |
| Q. Why is top posting bad ?                             |
#---------------------------------------------------------#