#125 don't modify the value of --user option

[Anonymous]

when obtaining the user name and group name from --user
the value of the option is modified.

this patch preserves the value given to --user option.

this patch lets privoxy work right with OpenBSD's rc.d system.

[Anonymous]

don't modify the value of --user option

[Fabian Keil]

Patch to not mess with the --user argument directly

[Fabian Keil]

Thanks for the report.

I can see multiple problems in the code in question, but I think your
patch only hides one of the problems.

Does the attached patch fix whatever problem you were seeing?
How exactly did the problem manifest?

[Anonymous]

>I can see multiple problems in the code in question, but I think your
>patch only hides one of the problems.
yes there are.

>Does the attached patch fix whatever problem you were seeing?
yes strdup solves the problem.

>How exactly did the problem manifest?
launched with --user user1.group2 privoxy creates a process with --user user1

while you're frank with this part of the code, may I mention
that '.' is a valid char in login name,
so having user.1 in a secondary group group2
would probably cause some trouble.
lets use ':'

thanks.

[Fabian Keil]

Thanks for the confirmation. Should be fixed in CVS now.

You are right about the dot not being the greatest choice for
a delimiter, but it doesn't seem to have caused any actual
problems so far and changing it now could break a lot of scripts.