From: <no...@so...> - 2006-12-28 17:54:26
|
Update of /cvsroot/ijbswa/current In directory sc8-pr-cvs2.sourceforge.net:/tmp/cvs-serv30969 Modified Files: cgi.c Log Message: Fixed gcc43 conversion warnings and replaced sprintf calls with snprintf to give OpenBSD's gcc one less reason to complain. Index: cgi.c =================================================================== RCS file: /cvsroot/ijbswa/current/cgi.c,v retrieving revision 1.83 retrieving revision 1.84 diff -u -d -r1.83 -r1.84 --- cgi.c 17 Dec 2006 19:35:19 -0000 1.83 +++ cgi.c 28 Dec 2006 17:54:22 -0000 1.84 @@ -38,6 +38,11 @@ * * Revisions : * $Log$ + * Revision 1.84 2006/12/28 17:54:22 fabiankeil + * Fixed gcc43 conversion warnings and replaced sprintf + * calls with snprintf to give OpenBSD's gcc one less reason + * to complain. + * * Revision 1.83 2006/12/17 19:35:19 fabiankeil * Escape ampersand in Privoxy menu. * @@ -1075,7 +1080,7 @@ ch = *(lookup(parameters, param_name)); if ((ch >= 'a') && (ch <= 'z')) { - ch = ch - 'a' + 'A'; + ch = (char)(ch - 'a' + 'A'); } return ch; @@ -1207,7 +1212,7 @@ return JB_ERR_CGI_PARAMS; } - ch -= '0'; + ch = (char)(ch - '0'); /* Note: * @@ -1221,7 +1226,7 @@ return JB_ERR_CGI_PARAMS; } - value = value * 10 + ch; + value = value * 10 + (unsigned)ch; } /* Success */ @@ -1561,7 +1566,7 @@ rsp->head_length = 0; rsp->is_static = 0; - sprintf(errnumbuf, "%d", error_to_report); + snprintf(errnumbuf, sizeof(errnumbuf), "%d", error_to_report); rsp->body = malloc(strlen(body_prefix) + strlen(errnumbuf) + strlen(body_suffix) + 1); if (rsp->body == NULL) @@ -1804,7 +1809,7 @@ /* * Fill in the HTTP Status */ - sprintf(buf, "HTTP/1.0 %s", rsp->status ? rsp->status : "200 OK"); + snprintf(buf, sizeof(buf), "HTTP/1.0 %s", rsp->status ? rsp->status : "200 OK"); err = enlist_first(rsp->headers, buf); /* @@ -1816,7 +1821,7 @@ } if (!err) { - sprintf(buf, "Content-Length: %d", (int)rsp->content_length); + snprintf(buf, sizeof(buf), "Content-Length: %d", (int)rsp->content_length); err = enlist(rsp->headers, buf); } |