[privoxy-devel] [ ijbswa-Patches-3292710 ] don't modify the value of --user option

[SourceForge.net <no...@so...>]

Patches item #3292710, was opened at 2011-04-25 18:19
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=311118&aid=3292710&group_id=11118

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: bugfix
Group: None
Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: zepard ()
Assigned to: Fabian Keil (fabiankeil)
Summary: don't modify the value of --user option

Initial Comment:
when obtaining the user name and group name from --user
the value of the option is modified.

this patch preserves the value given to --user option. 

this patch lets privoxy work right with OpenBSD's rc.d system.

----------------------------------------------------------------------

Comment By: zepard ()
Date: 2011-04-25 23:22

Message:
>I can see multiple problems in the code in question, but I think your
>patch only hides one of the problems.
yes there are.

>Does the attached patch fix whatever problem you were seeing?
yes strdup solves the problem.

>How exactly did the problem manifest?
launched with --user user1.group2 privoxy creates a process with --user
user1

while you're frank with this part of the code, may I mention
that '.' is a valid char in login name,
so having user.1 in a secondary group group2
would probably cause some trouble.
lets use ':'

thanks.

----------------------------------------------------------------------

Comment By: Fabian Keil (fabiankeil)
Date: 2011-04-25 21:31

Message:
Thanks for the report.

I can see multiple problems in the code in question, but I think your
patch only hides one of the problems.

Does the attached patch fix whatever problem you were seeing?
How exactly did the problem manifest?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=311118&aid=3292710&group_id=11118