[privoxy-devel] [ ijbswa-Feature Requests-588084 ] Handle path specs in config consistently

[SourceForge.net <no...@so...>]

Feature Requests item #588084, was opened at 2002-07-29 15:13
Message generated for change (Comment added) made by fabiankeil
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=361118&aid=588084&group_id=11118

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: funct: other
Group: future
Status: Open
Resolution: Accepted
Priority: 3
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Handle path specs in config consistently

Initial Comment:
Using the Windows privoxy_setup_2_9_16.exe release, and
the standard config.txt, privoxy attempts to load a
non-existent actions file.

In the 2.9.16 config.txt, the following appears:
actionsfile default.action

In privoxy.log:
Jul 29 10:53:58 Privoxy(-292131) Info: Privoxy version
2.9.16
Jul 29 10:53:58 Privoxy(-292131) Info: Program name:
C:\PROGRAM FILES\PRIVOXY\PRIVOXY.EXE
Jul 29 10:53:58 Privoxy(-292131) Fatal error: can't
load actions file '.\default.action.action': error
finding file: (error number 2)

Something appears to be incorrectly adding .action to
the end of the file name, or the standard config.txt
needs to be changed to
actionsfile default

I suggest that this "automatic adding of .action" is
unexpected behavior, since filterfile doesn't work the
same way.  I'd rather have the specified file be the
one opened.

Check lines 700-708 of CVS version 2.1 of
ijbswa/current/src/loadcfg.c
to see where ".action" is getting added, and further
down to see that ".filter" is not added to the end of
filterfile filenames.

----------------------------------------------------------------------

>Comment By: Fabian Keil (fabiankeil)
Date: 2007-04-23 15:59

Message:
Logged In: YES 
user_id=875547
Originator: NO

I think Privoxy should either always add
the ".action" suffix, or not at all.

I'm in favor of not adding it and don't
see the need for fancy file name guessing
logic.

If there are no objections I'm going to
remove the ".action" adding code in two
weeks.

----------------------------------------------------------------------

Comment By: Andreas Oesterhelt (oes)
Date: 2002-08-05 15:52

Message:
Logged In: YES 
user_id=78811

Laurence,

..you're right that the handling should be consistent.

But since it's not a bug and we need to get 2.9.18/3.0
out the door, I'm turning this into a feature request.

Regards,
--Andreas


----------------------------------------------------------------------

Comment By: John Smith (whiteg)
Date: 2002-08-05 14:12

Message:
Logged In: YES 
user_id=7645

Fresh setup works OK.
BUT... I think that if you add ".action" automatically, you
should also be adding ".filter" automatically.  I suggest
you do something else:

Suppose config.txt contains the following line:
actionsfile default.action
actionsfile my.own.sites
actionsfile local

And the following files exist in the proper directory:
default.action
local.action
my.own.sites

Then privoxy should look for "default.action", and find it.
Then "my.own.sites", and find it.
Then "local", and not find it.  Because it didn't find
"local", it should then look for "local.action", and
find
that file.

Otherwise, the software is being inconsistent (since
filterfile works differently), but not exactly broken.

Feel free to disagree, and thanks for working on privoxy.

----------------------------------------------------------------------

Comment By: Andreas Oesterhelt (oes)
Date: 2002-08-05 11:38

Message:
Logged In: YES 
user_id=78811

Just installed 2.9.16 on a fresh Win98 setup.

The config file lists the action files without their .action
siffixes, and they get loaded fine. I'm also not aware of
any make or nullsoft installer magic that could append
the suffix.

Could you please try a clean re-install and report back
if you continue to have the problem?

Setting to pending / Works-for-me


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=361118&aid=588084&group_id=11118