#595 Possible inconsistencies

[Flavio Medeiros]

Function (match_sockaddr) is defined in file: filters.c only when both HAVE_RFC2553 and FEATURE_ACL are defined. However, it is used when only FEATURE_ACL is defined. So, there is a possible inconsistency when HAVE_RFC2553 is disabled and FEATURE_ACL is enabled.

The same issue occurs in function (mark_connection_closed) in file gateway.c (defined only when FEATURE_CONNECTION_KEEP_ALIVE is enabled. However, it is used when FEATURE_CONNECTION_SHARING is enabled. There a problem when it disables FEATURE_CONNECTION_KEEP_ALIVE, and enables FEATURE_CONNECTION_SHARING.

[Fabian Keil]

Are you sure you are looking at the official Privoxy sources?

In the official Privoxy sources match_sockaddr() is only called
if HAVE_RFC2553 is defined:
http://ijbswa.cvs.sourceforge.net/viewvc/ijbswa/current/filters.c?revision=1.192&view=markup#l256

The configure script does not allow to enable
FEATURE_CONNECTION_SHARING without FEATURE_CONNECTION_KEEP_ALIVE
as sharing connections that aren't alive is pretty pointless.

If I'm missing something, please provide the compiler errors
and the required steps to reproduce them.