Menu

#189 vbr stack overflow

closed-fixed
nobody
id3v1 tag (12)
5
2009-12-21
2008-01-04
No

Hi,

don't know if you knwo speaking french, so i put this in english

I used functions fore reading id3v1 tags and VBR header information, but error Stack was corrupted occured in SOME Mp3 files only.

When i debugged id3li, i found :
const size_t VBR_HEADER_MAX_SIZE = 116; // frames, bytes, toc and scale are optional
in the file mp3_parse.cpp, but when i was in the line vbrheaderdata[vbr_header_size] = '\0'; the value of vbr_header_size was 120.

When i changed VBR_HEADER_MAX_SIZE to 120 instead of 116, all went good.

If i can help you for next versions...

Best regards.

Discussion

  • Carl Lewis

    Carl Lewis - 2008-11-18

    I've hit this bug as well and can confirm that the fix works.

     
  • Norbert

    Norbert - 2009-12-21

    This issue is fixed in the cvs version of 3.8.3

     
  • Norbert

    Norbert - 2009-12-21

    This issue is fixed in the present CVS source tree.

     
  • Norbert

    Norbert - 2009-12-21
    • status: open --> closed-fixed
     

Log in to post a comment.

Monday.com Logo