Re: Look= ? (Re: keramik theme)

[Mathias H. <mat...@gm...>]

On Thu, 29 Aug 2002, Gert Brinkmann wrote:

> Ruben (aka _cyclops_) wrote:
> 
> > if you do some grep's in the icewm source you will see that there is a
> > difference (scrollbar, menu, buttons, etc...)
> 
> I took a look at the source code and found nearly zero lines of 
> comments!? Phuu, i think it is a wonder that todays software projects do 
> work (or are other projects better commented?)

	Good code doesn't need much comments (hint: speaking names) ;-) 
Ok, more seriously: Yes, would be nice to have at least some API doc for 
icewm but:

	1) inline docs were not that established in 1997 when icewm was 
	   started
	2) AFAIR there are no good javadoc like tools for C++: doxygen is 
	   bloated, docxx and most other tools have serious problems with
	   the C++ language and segfault frequently
	3) if we would have a good inline doc tool: who'd have the time to
	   comment all the classes?


> So i guess noboy out there can really say what is the difference between 
> the different Looks? One pixel more or less here and another there... Is 
> there a schema for this? 

	As you might guess: The schema for this is the look of the
emulated windowing systems......

> Should all this pixel-stuff not be configurable 
> with a parameter instead? (For e.g. menuPixelGapAboveItemText = 1, 
> etc.). Then "Look" would not be required and everything could be defined 
> in a theme.

	Pixel exact positioning wasn't the intention there. Well, and 
there was a time when icewm didn't support the "pixmap" look........

> It is really astonishing that icewm works so good ;)

	Boy... there is really much worse code out there. Ok, some parts
of icewm aren't that ellegant as they could be and you have to accept that
Mark came from Delphi-World when starting to work on Icewm. Well some
portions of icewm dramatically leave the track of OOP for the sake of
performance. Ok, and OOP has not not beeing that well understood in '97 as
it is today...  But for the somewhat experience coder icewm's code isn't
that hard to understand: Once you've got the idea behind the code it's
quite easy to spot the proper locations to change (maybe that's the reason
for the leak of docs? ;-) Ok, maybe icewm is not the next thing you should
read after hacking your hello-world.cc -- but it's manageable.

	Well, and to explain icewm's stability I have to add that Mark is
an excellent bug hunter, fortunatly...


Ciao,
Mathias
-- 
WWW:           http://taschenorakel.de/mathias/
PGP/GnuPG:     1024-Bit DSA: ID 55E572F3, 1024-Bit RSA: ID EAAF7CF1
"e:-1" is the Slashdot Troll Emoticon. Often seen after the word "Scor"