Menu ▾ ▴

#86 v2.5 NOT thread safe

v 2.6
closed-fixed
nobody
None
5
2013-08-03
2013-08-02
Tobias
No

It seems that v2.5 of the html cleaner library is no longer thread safe. The attached test demonstrates the problem. It works using v2.2 of the library.

1 Attachments

Discussion

  • Scott Wilson

    Scott Wilson - 2013-08-02

    Thanks for the report and test case Tobias

     
  • Scott Wilson

    Scott Wilson - 2013-08-02

    I ran the test case against the various releases, and the problem is introduced between 2.2.1 and 2.4.

     
  • Scott Wilson

    Scott Wilson - 2013-08-02
    • Group: v 2.5 --> v 2.6
     
  • Scott Wilson

    Scott Wilson - 2013-08-02

    Assigning to fix in 2.6

     
  • Scott Wilson

    Scott Wilson - 2013-08-02

    OK, for some reason the thread-safe class used to hold instance variables in HtmlCleaner didn't make it across when the codebases were merged. I've re-implemented it in trunk, and all unit tests pass including the one I've added from Tobias.

    Please do check this one thoroughly as there may be side effects of this change that aren't currently tested for.

     
  • Scott Wilson

    Scott Wilson - 2013-08-02
    • status: open --> closed-fixed
     
  • Tobias

    Tobias - 2013-08-03

    Thank you for taking care so quickly.

     

Log in to post a comment.