#11 Segmentation fault in get_ctrl_by_id

[Nobuhiro Iwamatsu]

Segmentation fault in get_ctrl_by_id.

---

{ discrete: width = 960, height = 720 }
Time interval between frame: 1/15, 1/10, 1/5,
{ discrete: width = 1280, height = 960 }
Time interval between frame: 2/15, 1/5,
checking muxed H264 format support
device doesn't seem to support uvc H264 (0)
checking format: MJPG
VIDIOC_G_COMP:: Inappropriate ioctl for device
fps is set to 1/25
drawing controls

Segmentation fault

I create a patch which revice this problem.
I attached.

[Paulo Assis]

Nobuhiro Hi,

I think this is not a problem in current git master (guvcview version 2.0):

~~~~~~~~
for(; current != NULL; current = current->next)
{
if(current->control.id == id)
return (current);
}
~~~~~~~

I'm using a null terminated list here, so the for loop finishes if current is null.

I just need to clean up a couple of things before releasing the code.

Debian packaging will change quite a bit in this new version, since I moved most of the code to a couple of shared libraries.
You can have a look here to check how I'm currently packaging this in my ppa.

Best regards,
Paulo

[Nobuhiro Iwamatsu]

Hi,

2014-09-07 6:04 GMT+09:00 Paulo Assis assisp@users.sf.net:

Nobuhiro Hi,

I think this is not a problem in current git master (guvcview version 2.0):

Yes, this patch is for version_1.7 branch.

for(; current != NULL; current = current->next)
{
if(current->control.id == id)
return (current);
}

I'm using a null terminated list here, so the for loop finishes if current
is null.

I just need to clean up a couple of things before releasing the code.

Debian packaging will change quite a bit in this new version, since I moved
most of the code to a couple of shared libraries.
You can have a look here to check how I'm currently packaging this in my
ppa.

Yes, I know.
But I do not seem to be released version 2.0.
When do you release new version or add tag for version 2.0 to git repositiry?

Best regards,
Paulo

Best regards,
Nobuhiro

--
Nobuhiro Iwamatsu

[Paulo Assis]

Nobuhiro Hi,

Just released version 2.0.0, it is tagged in git, source tarball can be found here

Best Regards,
Paulo

[Nobuhiro Iwamatsu]

Hi!

2014-09-08 7:49 GMT+09:00 Paulo Assis assisp@users.sf.net:

Nobuhiro Hi,

Just released version 2.0.0, it is tagged in git, source tarball can be
found here

Cool, thanks.
I will upload version 2.0.0 to debian.

Best Regards,
Paulo

Best regards,
Nobuhiro

--
Nobuhiro Iwamatsu

[Paulo Assis]

Fixed since 2.0.0

Thank you.