From: Kevin K. <kev...@ch...> - 2006-09-22 22:21:01
|
> You are pleased to revert your change. Again, Win32 = MinGW for you. > By doing this, the header does not compile under MSVC any longer! Why do the: #include <ticonv.h> in the various tilibs work (yes, I changed some #include "ticonv.h" to #include <ticonv.h> and I hope these didn't add to the breakage, but there were ALREADY some using <ticonv.h>!) and these not? Is this due to different project setup? Anyway, you're free to fix the tilibs.h headers and the other inclusions for the #ifdef _MSC_VER case. (I can't test M$VC, so it's best if you fix it.) I think the result would look like this: #ifdef _MSC_VER #include "ticonv.h" #include "ticables.h" #include "tifiles.h" #include "ticalcs.h" #else #include <ticonv.h> #include <ticables.h> #include <tifiles.h> #include <ticalcs.h> #endif But please don't re-add any other #ifdefs unless you're 100% sure they are needed (I'm pretty sure they aren't, because that's really what pkg-config is for) and please let the non-M$VC #includes be done the right way (i.e. using angle brackets, not quotes, for installed headers). Oh, and "Win32 = MinGW for you", well, not any more than Win32 = M$VC for you. ;-) Sorry, but I can't stand the: #ifdef __WIN32__ #pragma warning disable(1234) #endif type mistakes (which will spit out extra warnings on MinGW because that's not a valid GCC pragma). I found some of these by chance again, but I can't nearly fix them as fast as you introduce them. ;-( > The #ifdef __MACOSX__ was needed by native port of Mac OS (which obsolete > because not maintained, I agree). Again, MacOSX != X11! * But with the changes, stuff actually BUILDS for OS X (modulo bugs I'm going to fix right now, ZPedro told me what he had to fix). (Though to be honest, he hasn't tried building the projects where tilibs.h is in yet. Still, there's no way it would have built with the old #ifdefs which refer to non-existent directories!) * This has nothing to do with X11. It has to do with using a standard Unix file system layout or an arbitrary one. This is a completely different issue from X11. * _I'm_ not going to be the one maintaining the arbitrary, different-just-to-be-different file system structure for OS X, if someone else wants to maintain that, it's fine with me, but it needs to be done throughout, including "make install". (Otherwise, it only breaks things!) IMHO, the different file system structure you picked for your M$VC/InnoSetup builds is already enough of a mess, we don't need a third. * It's perfectly possible to build non-X11 versions of programs using the tilibs with this file system layout. KTIGCC 2.00 is most likely going to support Qt/Mac 4, so this will be an example. :-) As I said, these are really orthogonal issues. Kevin Kofler |