Re: [Gtkpod-devel] Addind duplicate files: a strange behaviour

[Jorg S. <Jor...@gm...>]

Mario Rossi wrote:
> 1) I add "A"
> 2) I add "A" again. Nothing happens.
> 3) I add "B". It says it is the same as "A"
> 4) I add "B" as many times as I want. No message.
> 5) I add "A". It says it is the same as "B"
> 6) I add "A" as many times as I want. No message.
> 
> It is more misleading when adding the directory, since I get the 2
> messages at the same time (or one according to whether the last added
> was "A" or "B")
> 
> This is because in "misc_trac.c" line 283, when adding a second copy
> of a track already present the local file path is updated to the new
> one.
> I can see the following commet:
> 
> /* Update filename if new track has filename set (should be
>  * always!?) */
> 
> IMHO it should be added only if the track in DB does not have a path.
> 
> Any opinion?

As far as I'm concerned this is the intended behavior:

If you add the same file (same filename) again, the data in gtkpod is 
updated (option you can select).

If you add the same file (different filename) again, gtkpod assumes that 
you have moved the file and sets the filename to the new location.

Obviously, this could be refined (only update the filename if the 
original file no longer exists/pop up a dialog/print out different 
message). Inputs?

JCS.