Menu
▾
▴
Re: [Gtkpod-devel] GtkPod with Embedded Player - Alpha patch 2 (updated with today's cvs)
|
From: Marcelo V. <mva...@ro...> - 2006-11-08 12:22:28
|
This Alpha patch does not have the option to build gtkpod without gstreamer= headers despite the autogen is generating the proper option (I forgot to a= dd #ifdefs across the new code changes). I will add that when I have a brea= k.=0A=0A=0A=0ACheers=0A=0A----- Original Message ----=0AFrom: Marcelo Varan= da <mva...@ro...>=0ATo: Jorg Schuler <Jor...@gm...>; gtkpod l= ist <gtk...@li...>=0ASent: Sunday, November 5, 2006 1= 2:40:08 PM=0ASubject: Re: [Gtkpod-devel] GtkPod with Embedded Player - Alph= a patch 2 (updated with today's cvs)=0A=0AHi Jorg,=0A=0AThanks for your ema= il. here is the fix for creating the player db automatically for those upgr= ading from gtkpod without embedded player. It also has your patch for autog= en (thanks btw).=0A=0AThere are lots to be done (see ToDo list in gstb_play= er.c) but users can already take advantage of this patch as it is right now= . Unfortunately gstreamer plugins for some distros are not friendly. For Ub= untu is quite simple but I spent a lot of time getting faad, mad and ffmpeg= to work with SUSE 10.1 (well... the OS community might start boycotting th= is one anyways after M$ deal ...).=0A=0AHave fun,=0AMV=0A=0A----- Original = Message ----=0AFrom:=0A Jorg Schuler <Jor...@gm...>=0ATo: Marcelo Va= randa <mva...@ro...>=0ACc: gtkpod-devel <gtk...@li...urcefo= rge.net>=0ASent: Thursday, October 26, 2006 11:50:37 AM=0ASubject: Re: [Gtk= pod-devel] GtkPod with Embedded Player - Alpha patch 2 (updated with today'= s cvs)=0A=0AHi Marcelo,=0A=0AI've been going over your patch -- looks quite= good I would say. I =0Amanaged to compile your patch but gtkpod doesn't se= t up the 'Player' =0Arepository -- probably because I didn't delete the .gt= kpod directory. I =0Adon't want to delete/rename... it should be quite easy= to add the Player =0A repository on startup if it's missing, though.=0A= =0AIn your patch I don't understand the following:=0A=0A--- src/display_itd= b.c 21 Sep 2006 15:03:13 -0000 1.58=0A+++ src/display_itdb.c 23 Oc= t 2006 12:20:54 -0000=0A@@ -617,12 +617,13=0A @@=0A case DELETE_ACTION= _IPOD:=0A case DELETE_ACTION_LOCAL:=0A case DELETE_ACTION_DATABAS= E:=0A+ case DELETE_ACTION_PLAYLIST:=0A+ case DELETE_ACTION_PLAYER:=0A= /* remove from MPL in these cases (unless we are removing=0A = podcasts) */=0A if (!(plitem && itdb_playlist_is_podcasts (plitem)))= =0A plitem =3D NULL;=0A break;=0A- case DELETE_ACTION_PLAY= LIST:=0A /* cannot remove from MPL */=0A g_return_if_fail (plitem= );=0A break;=0A=0Athe DELETE_ACTION_PLAYLIST case should not be=0A mov= ed -- the occurence of =0Athis case indicates a programming error (allowing= to remove from =0Aplaylist when the playlist is the MPL) which should be c= aught and reported.=0A=0A- Somewhere else you used "//" for comments, which= is not allowed.=0A=0AChanges to file_export.c were reverted (you should ru= n a "cvs update" on =0Ayour tree to merge the latest changes into your copy= -- it will leave =0Ayour changes in place):=0A=0A--- src/file_export.c = 3 Oct 2006 14:12:00 -0000 1.65=0A+++ src/file_export.c 23 Oct 2006 12= :20:57 -0000=0A=0ALet me contribute something as well:=0A=0Aconfigure.in:= =0A=0A(attached)=0A=0AThis makes the src/Makefile hack unnecessary. In gstb= _player.c you =0Ashould add a conditional=0A=0A#ifdef HAVE_GSTREAMER=0A=0Aa= nd fall back to the default behavior if gstreamer support is not =0Acompile= d in -- see mp4file.c for an example.=0A=0AI really like what I see so far= =0A -- please set up the Player Repository =0Aautomatically when it's not p= resent (renaming the existing .gtkpod is =0Aquite a hazzle!) and it seems w= e are almost there!=0A=0ACheers,=0A=0A=0AJCS.=0A=0A=0A=0A=0AMarcelo Varanda= wrote:=0A> Hi All,=0A> =0A> The patch I sent had cvs from last week. It lo= oks like Jorg has =0A> submitted something about 2 or 3 days ago.=0A> =0A> = here is my patch over the latest (today's cvs). See attached or:=0A> =0A> h= ttp://www.vartk.com/playerAlpha_patch2.tar=0A> =0A> cheers=0A> =0A> ----- O= riginal Message ----=0A> From: Marcelo Varanda <mva...@ro...>=0A> To= : gtkpod list <gtk...@li...>=0A> Sent: Sunday, Octobe= r 22, 2006 5:38:05 PM=0A> Subject: [Gtkpod-devel] GtkPod with Embedded Play= er - Alpha patch=0A> =0A> Hi All,=0A> =0A> I believe the=0A weather here in= Ottawa has been great for open source =0A> projects. After two consecutive= rainy weekends I was able to put =0A> together a player that might be usef= ul for gtkpod users. So I am =0A> releasing a patch for it.=0A> =0A> Here s= ome points:=0A> =0A> - the tar file should be expanded in gtkpod directory = (GUI root where =0A> autogen.sh is located).=0A> =0A> - The player is based= on Gstreamer-0.10 so you will need to have at =0A> least the gstreamer hea= der (dev packet) to build it.=0A> =0A> - The target machines DO NOT need to= have GStreamer installed. For those =0A> who are happy with an external pl= ayer the gstreamer lib is loaded in =0A> run-time if available. Just unchec= k the menu View option "Player Panel" =0A> and gtkpod will be as you used b= efore.=0A> =0A> - I am not familiar with Autogen. Therefore, I was not able= to add =0A> instructions to generate an include path for gstreamer=0A head= ers. =0A> Therefore, after you have ran autogen then change src/Makefile an= d add =0A> the path to your gstreamer headers. For Ubuntu add =0A> -I/usr/= include/gstreamer-0.10 for PACKAGE_CFLAGS, AM_CFLAGS and INCLUDES =0A> defi= nitions.=0A> =0A> - delete your /home/yourhome/.gtkpod (or rename it) befor= e you run gtkpod.=0A> =0A> - The file gstb_player.c has a TODO list. YOU AR= E WELCOME TO HELP. Just =0A> let us all know what are you doing or willing = to do; so it would avoid =0A> someone else loosing his/her time. I guess I = will not be able to do much =0A> more in the upcoming weeks as my job is ge= tting more and more demanding.=0A> =0A> In case you can not download my pat= ch from the list then you can get it =0A> from the link bellow:=0A> =0A> ht= tp://www.vartk.com/playerAlpha_patch.tar=0A> =0A> =0A> For those who have= =0A ipod supporting video I would ask to "hack around" =0A> and improve thi= s player for video.=0A> =0A> Have fun,=0A> Marcelo=0A> --------------------= -----------------------------------------------------=0A> Using Tomcat but = need to do more? Need to support web services, security?=0A> Get stuff done= quickly with pre-integrated technology to make your job =0A> easier=0A> Do= wnload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo=0A= > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat= =3D121642 =0A> <http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid= =3D263057&dat=3D121642>=0A> _______________________________________________= =0A> Gtkpod-devel=0A mailing list=0A> Gtk...@li...=0A= > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel=0A> =0A> =0A> -= -----------------------------------------------------------------------=0A>= =0A> ---------------------------------------------------------------------= ----=0A> Using Tomcat but need to do more? Need to support web services, se= curity?=0A> Get stuff done quickly with pre-integrated technology to make y= our job easier=0A> Download IBM WebSphere Application Server v.1.0.1 based = on Apache Geronimo=0A> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D1207= 09&bid=3D263057&dat=3D121642=0A> =0A> =0A> --------------------------------= ----------------------------------------=0A> =0A>=0A ______________________= _________________________=0A> Gtkpod-devel mailing list=0A> Gtkpod-devel@li= sts.sourceforge.net=0A> https://lists.sourceforge.net/lists/listinfo/gtkpod= -devel=0A=0A=0AIndex: configure.in=0A=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=0ARCS file: /cvsroot/gtkpod/gtkpod/configure.in,v=0Aretriev= ing revision 1.93=0Adiff -u -r1.93 configure.in=0A--- configure.in 24 Se= p 2006 14:10:23 -0000 1.93=0A+++ configure.in 26 Oct 2006 15:45:23 -0= 000=0A@@ -41,6 +41,16 @@=0A AC_SUBST(PACKAGE_CFLAGS)=0A AC_SUBST(PACKAGE_LI= BS)=0A =0A+dnl check for gstreamer=0A+GSTREAMER_REQUIRED_VERSION=3D0.10.0= =0A+PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 >=3D $GSTREAMER_REQUIRED_VE= RSION, have_gstreamer=3Dyes, have_gstreamer=3Dno)=0A+=0A+if test "x$have_gs= treamer" =3D "xyes";=0A then=0A+ AC_DEFINE_UNQUOTED(HAVE_GSTREAMER, 1, ["= Set to 1 to compile support for gstreamer"])=0A+ CFLAGS=3D"$CFLAGS $GSTRE= AMER_CFLAGS"=0A+fi=0A+=0A+=0A dnl we need 'flex'=0A AM_PROG_LEX=0A if ! tes= t "y$LEX" =3D "yflex"; then=0A@@ -116,6 +126,7 @@=0A Preprocessor ........= .: $CC $CPPFLAGS=0A Compiler .............: $CC $CFLAGS $PACKAGE_CFLAGS=0A= Linker ...............: $CC $LDFLAGS $LIBS $PACKAGE_LIBS=0A+ gstreamer ..= ..........: $have_gstreamer=0A GTK2 version .........: `pkg-config gtk+-2.= 0 --modversion`=0A GLib2/GThread version : `pkg-config gthread-2.0 --modve= rsion`=0A id3tag lib ...........: yes=0A=0A=0A=0A=0A=0A-------------------= ------------------------------------------------------=0AUsing Tomcat but n= eed to do more? Need to support web services, security?=0AGet stuff done qu= ickly with pre-integrated technology to make your job easier=0ADownload IBM= WebSphere Application Server v.1.0.1 based on Apache Geronimo=0Ahttp://sel= .as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D121642=0A__= _____________________________________________=0AGtkpod-devel mailing list= =0AG...@li...=0Ahttps://lists.sourceforge.net/lists= /listinfo/gtkpod-devel=0A=0A=0A=0A=0A |