[Gtkpod-devel] Patch: remove photo albums

[Seb R. <me...@se...>]

Hi!

I've written up a small patch to all removing of photo albums from ipods.

Keep in mind that I'm not used to writing in g-style code.  I've done
my best to keep to your conventions and done some testing.

Albums are successfully removed, and so are the child items, but
writing to the database will crash if the following call is used:

itdb_photodb_write( db, NULL );

> Program received signal SIGSEGV, Segmentation fault.
> 0xb7ef1e22 in itdb_photodb_write (photodb=0x80502c0, error=0x0) at itdb_photoalbum.c:453
> 453         if (!(*error) && photodb->device->sysinfo_changed)

Obviously it will work when passing the error value into the method:

itdb_photodb_write( db, &err );

(the former is used often in your test code).

I've also written a new test case in test-photos.c
./test-photos delete /media/IPOD "test album"

Feedback on the patch would be nice.

Seb

-- 
http://www.sebruiz.net/