From: Richard H. <email@RichardHyde.net> - 2006-08-31 14:39:13
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thanks. That may explain it. I was running version 2.8.1 and according to the website they added support for a lot of additional properties and widgets in 2.10. I guess loading it into 2.8 ignored these so they were removed when I saved it back down. Richard On Thu, August 31, 2006 3:31 pm, Jorg Schuler wrote: > Great! > > glade-2 2.12.1 > > But I'm not sure which version was installed when I last wrote out the > gtkpod.glade. So I did the simple test: > > - load gtkpod.glade with 2.12.1 > - write gtkpod.glade > - do a diff against CVS > > Result: > > No change. > > Cheers, > > > JCS. > > Richard Hyde wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi Jorg, >> >> I'll fix those tonight and get you another patch out. >> >> Out of interest which version of glade are you using? >> >> Regards, >> >> Richard >> >> On Thu, August 31, 2006 3:04 pm, Jorg Schuler wrote: >>> Hi Richard, >>> >>> I like the idea. There's just some more work needed on the patch before >>> we can commit: >>> >>> - I don't know what you did to gtkpod.glade, but much more has been >>> done >>> than just adding a new mask (look at the patch -- it's HUGE!). Can you >>> check this? >>> >>> + >>> +/** check a filename against the "excludes file mask" from the >>> preferences >>> + * and return TRUE if it should be excluded based on the mask >>> + */ >>> +gboolean excludefile (gchar *filename) >>> +{ >>> + gboolean bresult=FALSE; >>> + gchar **masks; >>> + int i=0; >>> + >>> + masks = g_strsplit(prefs_get_string("exclude_file_mask"), ",", >>> -1); >>> + >>> + g_return_val_if_fail(masks, FALSE); >>> + >>> >>> - you can't pass the NULL pointer t g_strsplit, so you must check for >>> that before. >>> >>> - prefs_get_string() requires you to free the obtained string >>> >>> - you can't use g_return_val... a NULL pointer is a completely legal >>> return value. >>> >>> >>> --- src/file.h 11 Jun 2006 16:04:47 -0000 1.54 >>> +++ src/file.h 21 Aug 2006 16:14:29 -0000 >>> @@ -109,6 +109,7 @@ >>> void parse_offline_playcount (void); >>> >>> gboolean read_soundcheck (Track *track); >>> +gboolean excludefile (gchar *filename); >>> >>> >>> excludefile() should be static -- it's only used in file.c >>> >>> >>> If you send a revised patch I'll include it. >>> >>> Cheers, >>> >>> >>> JCS. >>> >>> >>> >>> Richard Hyde wrote: >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA1 >>>> >>>> Hi All, >>>> >>>> I've added an "excludes file mask" option to the preferences. It >>>> cause >>>> gtkpod to skip files which match the file mask (or masks, comma >>>> sperated >>>> list) when adding a file. >>>> >>>> Not having a video ipod I've can use this to stop video podcasts being >>>> added to my iPod when syncing a directory. >>>> >>>> The patch seems to have picked up quite a few changes to gtkpod.glade, >>>> so >>>> I may be running an incorrect version (v2) of glade, should I upgrade >>>> to >>>> v3? >>>> >>>> Cheers, >>>> >>>> Richard > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Gtkpod-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFE9vSJAazTgS/MW2YRAmlrAJ9Iz/oLsACcCxRgFHpUgko4te5vmACfXrth TPoOaWfmfLnxxb4rfdMsg68= =8k8K -----END PGP SIGNATURE----- |