From: Javier K. <jk...@us...> - 2007-07-29 13:22:33
|
Hi Jorg, list, It's been a long time, but I finally got around to work on this issue. El jue, 24-05-2007 a las 17:46 +0200, Jorg Schuler escribió: > > > I noticed that gtkpod uses about 10% of CPU all the time while oggdec > > and faac work on transforming files from OGG to M4A. Shouldn't gtkpod be > > idle on the background, or just using what little CPU power is necessary > > to update the details box? For comparison, oggdec is using less CPU than > > gtkpod... > > > > A 10% speed increase would be very appreciated in this significantly > > slow process :) > > > > Also, if you have some ideas on what could be causing the issue but have > > no time to check it, maybe I could look into it myself. I have very > > little experience with GTK+, but it can't be that hard, can it? > gtkpod does three things: > > 1) monitor output of the scripts and paste it into the details window, I think 100x per second I found this to be the reason for the 10% CPU usage. Sysprof pointed to gtk_text_buffer_emit_insert taking all the load, so I investigated file_convert.c as you suggested and found out that it was adding the text to the log character by character! The attached patch fixes the conversion_log_append to use runs of texts. In my test cases (ogg to mp4 conversion) gtkpod was not using more CPU than idle Epiphany and amule processes. It also disappeared completely from the sysprof profile, which is good. Note that in all my tests as well as during my initial finding, the log window was closed. Cheers, -- Javier Kohen <jk...@us...> ICQ: blashyrkh #2361802 Jabber: jk...@ja... |