Re: [Gtkpod-devel] PATCH: 5g video iPod support.

[Jorg S. <Jor...@gm...>]

Hi there,

> > Patch attached.
> > 
> > I didn't test the WAV and MP4 files, but it works fine with MP3s.
> > Also, I cannot check iPod models other than the g5, so I don't know
> > whether this breaks something for older models.
> 
> What about that patch? (the ipod-device.[ch] bits are simply a sync with
> libipoddevice CVS) It only changes behaviour when an iPod video is
> detected, and assumes that non-video files are audio files, hopefully
> that's a safe assumption to make.

Ultimately the application should be responsible for setting this field, I
believe. Therefore the approach taken to set this value only when not being
set is quite good.

I wouldn't worry too much about breaking older iPod models. The oldest iPod
models don't even know about unk208, and I wouldn't be surprised if iTunes
6.0 would set this value for all iPods. I'll check later this week with my
iPod nano (iTunes 5.0 set this field to 0). Or is there anyone else who
could check?

Cheers,


JCS.