Re: [Gtkpod-devel] Patch: libgpod and 16 bit integers in itdb on big endian machines

[Jorg S. <Jor...@gm...>]

Hi Martin,

thanks for pointing this out. One more line had to be changed, however:

static guint16 get16lint (FContents *cts, glong seek)
{
!!    guint32 n=0;

    if (check_seek (cts, seek, 2))
    {
	g_return_val_if_fail (cts->contents, 0);
!!	memcpy (&n, &cts->contents[seek], 4);  -> read only 2 bytes!
#       if (G_BYTE_ORDER == G_BIG_ENDIAN)
	  n = GUINT16_SWAP_LE_BE (n);
#       endif
    }
    return n;
}

Cheers,


JCS.



On Mon, Oct 31, 2005 at 01:32:02AM +0100, Martin Aumueller wrote:
> Hi,
> 
> get16lint in src/itdb_itunesdb.c from libgpod does not seem to work on
> big endian systems because endianess conversion is done on 32 bit
> values. Because of this, the podcast playlist is not recognized as
> such.
> 
> Martin