From: Todd Z. <tm...@po...> - 2009-04-17 22:10:38
|
Dudy Kohen wrote: > It doesn't need the taglib sources, just the library (and some of > the includes, but they are all in the dev package of taglib)... Cool. That's good to know. > The question is not "Can it be done?" it can be, I believe it's even > very simple, I never installed taglib from sources, just the > bindings... The question is "should we do it?" I'd say that depends on how easily we can add it to the build system weighed against the benefit of adding taglib support now. Is the main benefit that taglib is better maintained than libid3tag? I thought I saw a comment in the code or on the list about USLT tags still not being liked by the iPod? I think that may well be an iPod bug, one that only seems to be tickled when using id3v2.4 tags? I've got plenty of id3v2.3 tags that my iPod reads just fine. :/ I started to try and get the bindings building as part of the gtkpod build but I got sidetracked. I was thinking that the tag_c.* files could go into a taglib subdir to be built if we find that the system taglib is too old. Then we can link against our local copies. The autoconf logic would go something like this: if pkg-config taglib_c >= 1.6 or contains the required functions use system taglib else if pkg-config taglib build and use local bindings fi fi if no taglib found or buildable use libid3tag fi And maybe in the beginning we'd be better off making taglib require explicit enabling via a --with-taglib option. That way unsuspecting users shouldn't notice any change at all. More adventurous folks can enable taglib and help shake out any bugs. When it's been tested and solid, we can make taglib the default (and remove libid3tag sometime after). Sound like a plan? -- Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It is not enough to be busy, so are the ants. The question is: what are we busy about? -- Henry David Thoreau |