From: Todd Z. <tm...@po...> - 2009-04-12 22:36:36
|
Greg wrote: > I added a gui interface to configure the ReplayGain preferences that > I created in the previous patch. Nice. Sorry I haven't made time to test much yet. I played a bit with it yesterday though. I didn't test all of the various possible scenarios. > I put the ReplayGain dialog box as a button on the "music" tab of > the main prefs dialog. It seemed logical to me but I'm open to other > suggestions. That seems about as reasonable as any other place. You could argue that the metadata tab would be good too. But I'm not sure if either one is significantly better than the other. :) > It looks like line wrapping may be an issue in this message, let me > know if you would like an actual file... The line wrapping was easier to figure out than the tabs which were converted to spaces. Funky cut-and-paste perhaps? ;) I tried to simplify the UI a little, let me know what you think. I'll attach an updated patch series against svn rev 2309. -- Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ A person who smiles in the face of adversity ... probably has a scapegoat. |