Re: [Gtkpod-devel] [PATCH] Add support for missing light blue ipod shuffle

[Christophe F. <te...@gn...>]

Hello,


Le 15 décembre 2008 10:17, Neil Campbell <li...@th...> a écrit :
>
> I got a new Ipod shuffle, but was having difficulty getting it to work
> properly with libgpod.  I found that the specific model number for this one
> (B228) was missing from libgpod.  Attached is a patch (against latest
> libgpod SVN) which solves this for me; I've tested it briefly with gtkpod
> and amarok (both using the patch applied to libgpod 0.6.0).
>
> Here is the link where I found the relevant model number listings:
> http://yabb.jriver.com/interact/index.php?topic=36033.0
>
> It would be great if you could apply this to SVN.  Let me know if the patch
> needs any more work.

Thanks for the patch!! Before applying it, I had a question, is it
important to make the distinction between blue and light blue shuffles
? We generally use the generic color name to cover different shade of
colors, I think we did that already for the ipod nano colors which are
different from generations from generations. So would you have issues
with a simpler patch only adding the model number and serial number
from your ipod reusing the exising ITDB_IPOD_MODEL_SHUFFLE_BLUE enum ?

Thanks,

Christophe