Re: [Gtkpod-devel] libid3tag problems (with lyrics)

[Dudy K. <ko...@gm...>]

Hi Todd,
I added another comment in the RedHat\Fedora bugzilla.
I think this should be moved from the list, to bugzilla, so others won't
have to repeat the discussion.
David


On Fri, Dec 19, 2008 at 6:23 AM, Todd Zullinger <tm...@po...> wrote:

> Hi David,
>
> Dudy Kohen wrote:
> > The lyrics support that I have been working on was acting strangely,
> > it turns out that it writes the tag only some of the times and the
> > iPod has problems finding the end of string.
> >
> > As it turns out, the library, in an attempt to save a few bytes,
> > doesn't write the termination character in the end of a frame,
> > something that is required by the specs:
> >
> > From http://www.id3.org/id3v2.4.0-structure
> >
> > Frames that allow different types of text encoding contains a text
> >  encoding description byte. Possible encodings:
> >
> >    $00   ISO-8859-1 [ISO-8859-1]. Terminated with $00.
> >    $01   UTF-16 [UTF-16] encoded Unicode [UNICODE] with BOM. All
> >          strings in the same frame SHALL have the same byteorder.
> >          Terminated with $00 00.
> >    $02   UTF-16BE [UTF-16] encoded Unicode [UNICODE] without BOM.
> >          Terminated with $00 00.
> >    $03   UTF-8 [UTF-8] encoded Unicode [UNICODE]. Terminated with $00.
> >
> > The attached patch takes care of that one.
>
> As I just wrote in the Fedora bugzilla¹, I think this patch is
> incorrect.  The terminator is written to the Content descriptor
> portion of the text frame header, not at the end of the text frame
> body.  Of course, I could easily be reading things wrong.
>
> ¹ https://bugzilla.redhat.com/476493
>
> --
> Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp<http://www.pobox.com/%7Etmz/pgp>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Don't look for me in daylight where robots all assemble.  You'll find
> me in my dark world, in my smoke-filled temple.
>
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
>
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
>
>