Re: [Gtkpod-devel] Lyrics Support

[Dudy K. <ko...@gm...>]

Which lists do we risk in destroying?
On Sat, Nov 8, 2008 at 11:41 AM, Jorg Schuler <Jor...@gm...> wrote:
> OK, I've submitted the patch and also made a few changes:
>
> - new page for lyrics
> - column indicating presence of lyrics is a checkbox. Clicking on the
> checkbox will bring up the edit lyrics dialog.
>
> I didn't try with my iPod, but I failed to write the lyrics to the file.
> Please do some testing.
>
> Furthermore, I found two possible sources for segfaults (one existing,
> one new, both for the same reason):
>
>          !!! There are two possible sources for segfaults in
>          details.c/details_button_apply_clicked:
>
>          - track_copy_artwork() writes the lyrics tag to the file and
>            checks for duplicates. This might destroy the list we are
>             just iterating over.
>
>          - write_tags_to_file() writes tags to the file and checks for
>            duplicates. This might destroy the list we are just
>             iterating over.
>
>          I don't have a simple solution right now.
>
> Ideas are welcome...
>
> Cheers,
>
>
> JCS.
>
> Dudy Kohen wrote:
>> On Fri, Oct 31, 2008 at 3:58 PM, Todd Zullinger <tm...@po...> wrote:
>>> Dudy Kohen wrote:
>>>> The problem is because I worked on a 0.99.12 tarball and not the
>>>> SVN...
>>> Ahh, yeah, there were a few conflicts trying to apply the patch to
>>> SVN, though all except the the glade file ones were relatively minor.
>>> I think the attached patch has all of your changes from the first
>>> patch except the glade file, which as you say, is easier to regenerate
>>> with glade than it is to manually merge.  I attempted to do that, but
>>> had issues when using glade 3.4, and Jorg wasn't around to find out
>>> exactly which version he's been using recently.
>>>
>>>> Lyrics can be marked as stored while an empty string is in the file
>>>> itself, can you say what Picard or Kid3 show in the USLT section of
>>>> the same file?
>>> Oh, there are lyrics in the USLT tag, to be sure.  I even added some
>>> debug code to id3_lyrics_read() to verify that the lyrics were found.
>>> They just didn't get displayed for me.
>>>
>>> I'll try to update to your current patch and test again sometime over
>>> the weekend.
>>>
>> It worked with my lyrics, there is an option to use more than one
>> lyrics tag in the same file, for different encodings and languages,
>> iPod works with UTF8 only, maybe yours is in a different encoding,
>> that's why I suggested seeing it with Picard...
>>>> A new tab is too much in my opinion, and since the entire window is
>>>> resizeable, the box is resizeable.
>>> Though for many people, screen width is easier to come by than height,
>>> which is what made me think that a separate tab would fit better in
>>> the default size of the dialog.
>> OK, I'll make the new glade as a new tab...
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
>