Re: [Gtkpod-devel] [Patch] Crop iPhone thumbnails to be square, and add white border

[Jacob Hoffman-A. <js...@ne...>]

Okay, I seem to have all my ducks in a row git-wise, thanks a lot for
the pointers on getting started.  This was actually really handy,
since I've been meaning to learn some git.

I was able to clone and build Christophe's branch.  Unfortunately, it
doesn't work for me.  With the version you have at head, I get no
thumbnails after I open an album.  If I sync the version that
incorporates only my changes and not your most recent ones (commit
d703822711bb4b483eea3d2ace07a6e33a4c2185), things are still broken.

Christophe, it looks like, until this most recent round, the last
changes on your branch were in February?  Maybe there are some changes
since then in SVN that need to be incorporated?

I made some miscellaneous refactorings, these seem to restore things
to a point where I get thumbnails after opening an album, but I get
black margins on the sides still.  I'm not sure why these changes fix
things, since that was not their intent, but anyhow I've attached
them.  I think they are a slight improvement in clarity.

On Tue, May 20, 2008 at 6:09 PM, Jacob Hoffman-Andrews <js...@ne...> wrote:
> Thanks, that was useful.  This was also useful:
> http://www.freedesktop.org/wiki/Infrastructure/git/Developers
>
> Now, is anongit down or am I doing something wrong?
>
>
> $ git init
> $ git fetch git://anongit.freedesktop.org/git/users/teuf/libgpod.git
> fatal: The remote end hung up unexpectedly
>
>
> On Tue, May 20, 2008 at 3:11 PM, Todd Zullinger <tm...@po...> wrote:
>> Jacob Hoffman-Andrews wrote:
>>> Should I send further updates to these as a monolithic patch similar
>>> to my original, or apply them as smaller changes to your git branch?
>>> I'm a complete git novice so I'd need a link to some documentation.
>>
>> One good place to start is:
>>
>> http://www.kernel.org/pub/software/scm/git/docs/tutorial.html
>>
>> --
>> Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> Shpx gur Pbzzhavpngvbaf Qrprapl Npg!
>>    -- Anonymous
>>
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> Gtkpod-devel mailing list
>> Gtk...@li...
>> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
>>
>>
>