From: Neil C. <li...@th...> - 2008-12-15 09:17:25
Attachments:
libgpod-shuffle-ltblue.patch
|
Hi, I got a new Ipod shuffle, but was having difficulty getting it to work properly with libgpod. I found that the specific model number for this one (B228) was missing from libgpod. Attached is a patch (against latest libgpod SVN) which solves this for me; I've tested it briefly with gtkpod and amarok (both using the patch applied to libgpod 0.6.0). Here is the link where I found the relevant model number listings: http://yabb.jriver.com/interact/index.php?topic=36033.0 It would be great if you could apply this to SVN. Let me know if the patch needs any more work. Thanks, Neil |
From: Christophe F. <te...@gn...> - 2008-12-20 23:15:13
|
Hello, Le 15 décembre 2008 10:17, Neil Campbell <li...@th...> a écrit : > > I got a new Ipod shuffle, but was having difficulty getting it to work > properly with libgpod. I found that the specific model number for this one > (B228) was missing from libgpod. Attached is a patch (against latest > libgpod SVN) which solves this for me; I've tested it briefly with gtkpod > and amarok (both using the patch applied to libgpod 0.6.0). > > Here is the link where I found the relevant model number listings: > http://yabb.jriver.com/interact/index.php?topic=36033.0 > > It would be great if you could apply this to SVN. Let me know if the patch > needs any more work. Thanks for the patch!! Before applying it, I had a question, is it important to make the distinction between blue and light blue shuffles ? We generally use the generic color name to cover different shade of colors, I think we did that already for the ipod nano colors which are different from generations from generations. So would you have issues with a simpler patch only adding the model number and serial number from your ipod reusing the exising ITDB_IPOD_MODEL_SHUFFLE_BLUE enum ? Thanks, Christophe |
From: Neil C. <li...@th...> - 2008-12-21 13:47:22
Attachments:
libgpod-shuffle-ltblue_v2.patch
|
Christophe Fergeau wrote: > Thanks for the patch!! Before applying it, I had a question, is it > important to make the distinction between blue and light blue shuffles > ? We generally use the generic color name to cover different shade of > colors, I think we did that already for the ipod nano colors which are > different from generations from generations. So would you have issues > with a simpler patch only adding the model number and serial number > from your ipod reusing the exising ITDB_IPOD_MODEL_SHUFFLE_BLUE enum ? Hi Christophe, That sounds like it would work too; I'm not terribly familiar with the code but I can't see any problems with reusing ITDB_IPOD_MODEL_SHUFFLE_BLUE as you suggest. Attached is an updated patch which makes these changes. I've tested it briefly and it seems fine. Thanks! Neil |
From: Christophe F. <te...@gn...> - 2008-12-22 14:21:52
|
2008/12/21 Neil Campbell <li...@th...>: > That sounds like it would work too; I'm not terribly familiar with the code > but I can't see any problems with reusing ITDB_IPOD_MODEL_SHUFFLE_BLUE as > you suggest. > > Attached is an updated patch which makes these changes. I've tested it > briefly and it seems fine. Ok, thanks, I applied it except for the 2nd hunk which was unnecessary if we don't add a new color. I'm feeling a bit uneasy about our ipod shuffle info, I've got the feeling that it's not really accurate, especially when it comes to the generation number :-/ But as long as it works well enough, it's fine ;) Thanks for providing the information! Christophe |
From: Neil C. <li...@th...> - 2008-12-22 16:44:13
|
Christophe Fergeau wrote: > 2008/12/21 Neil Campbell <li...@th...>: >> That sounds like it would work too; I'm not terribly familiar with the code >> but I can't see any problems with reusing ITDB_IPOD_MODEL_SHUFFLE_BLUE as >> you suggest. >> >> Attached is an updated patch which makes these changes. I've tested it >> briefly and it seems fine. > > Ok, thanks, I applied it except for the 2nd hunk which was unnecessary > if we don't add a new color. I'm feeling a bit uneasy about our ipod > shuffle info, I've got the feeling that it's not really accurate, > especially when it comes to the generation number :-/ But as long as > it works well enough, it's fine ;) Ah yes, you're quite right - leaving that extra line in is wrong. However, I'm now wondering if the first version of the patch might have been preferable after all. On the Repository Options panel in gtkpod, when I use the drop-down menu to select the model, the list now includes "1 GB Shuffle (Blue)" twice, with the two different model numbers (B227 and B228). How is the user expected to know which of these to select? Perhaps keeping the Blue/Light Blue distinction would make things easier - what do you think? Thanks, Neil |