gtkpod-devel — gtkpod development issues

[Gtkpod-devel] Last changes in Anjuta

[Sébastien G. <se...@fr...>]

Hi all,


I have just committed some changes in Anjuta to make it works better as 
a GtkApplication. Anjuta is already derived from GtkApplication but it 
is not completely working. By example, clicking on New Window in the 
GNOME shell dash doesn't open a new Anjuta window if it is already started.

I have added a new function in the AnjutaShell interface in order to 
create a new main window. I have used it when a new project is open in 
Anjuta. A crash in this process will close all the windows.

Previously in most of the case a new process was created so the code 
used to unload the plugins (or even just free them) was not really used 
and it's quite buggy. There are still some crashes, I will try to fix 
them but I have already committed my changes so you can try them.


Regards,

Sébastien

[Gtkpod-devel] Patches: mp4 chapters, sorting/compilation/media type tags

[Joel S. <jsf...@jk...>]

Hi all,
I have added some patches to the Atomic Parsley wrapper to get support 
for reading MP4 Quicktime-style chapters and reading/writing some 
missing tags, such as the sorting tags.

Additionally, I have some minor bugfixes for reading the compilation 
flag (which should fix 
http://gtkpod.org/bugs/index.php?do=details&task_id=42 I think) and 
reading the media type tag from MP4 files.

I have tested the code with my MP4 audiobooks, but most of my files are 
more-or-less the same in terms of atom layout, etc, so if anybody has 
some files that break my code, I'd be happy to take a look and fix the 
code to accommodate other variations.

You can find the patches in my sandbox here:
https://gitorious.org/~joelsmith/gtkpod/joelsmiths-sandbox/commits/master
There are 5 patches, all pushed 2012/11/09 @ 05:08 UTC.

Regards,
Joel

Re: [Gtkpod-devel] [BUG] normal_sorttab_page.c, line 957 reached with entryname == NULL

[phantomjinx <p.g...@ph...>]

Apologies Jonathan,

No need to post again. I have your email on my TODO list ;)

My fault for not acknowledging it.

Will try and have a closer look at the problem this weekend.

Thanks for the info.

Cheers

PGR

On 10/21/2012 10:56 AM, Jonathan Neuschäfer wrote:
> Hi!
> 
> Gtkpod crashed today, so I fired up gdb to have a look at the cause.
> Here's part of the backtrace:
> 
> #0  __strcmp_ia32 () at ../sysdeps/i386/i686/multiarch/../strcmp.S:39
> #1  0xb778f6bc in fuzzy_skip_prefix (name=name@entry=0x0) at misc.c:479
> #2  0xafa8ba47 in _st_build_sortkeys (entry=0x9526ba8) at normal_sorttab_page.c:286
> #3  0xafa8d74b in normal_sort_tab_page_add_track (self=0x8c2c2c8, track=track@entry=0x912d878, final=final@entry=0, display=display@entry=1)
>     at normal_sorttab_page.c:965
> 
> As you can see, fuzzy_skip_prefix is called with a NULL pointer as its
> argument. That's because line 957 was reached with entryname == NULL and
> entry == NULL. (I haven't done any further debugging yet, but you might
> be able to find the bug from the hints I gave so far.)
> 
> 
> Thanks,
> Jonathan Neuschäfer
> 
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_sfd2d_oct
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

[Gtkpod-devel] [BUG] normal_sorttab_page.c, line 957 reached with entryname == NULL

[Jonathan N. <j.n...@gm...>]

Hi!

Gtkpod crashed today, so I fired up gdb to have a look at the cause.
Here's part of the backtrace:

#0  __strcmp_ia32 () at ../sysdeps/i386/i686/multiarch/../strcmp.S:39
#1  0xb778f6bc in fuzzy_skip_prefix (name=name@entry=0x0) at misc.c:479
#2  0xafa8ba47 in _st_build_sortkeys (entry=0x9526ba8) at normal_sorttab_page.c:286
#3  0xafa8d74b in normal_sort_tab_page_add_track (self=0x8c2c2c8, track=track@entry=0x912d878, final=final@entry=0, display=display@entry=1)
    at normal_sorttab_page.c:965

As you can see, fuzzy_skip_prefix is called with a NULL pointer as its
argument. That's because line 957 was reached with entryname == NULL and
entry == NULL. (I haven't done any further debugging yet, but you might
be able to find the bug from the hints I gave so far.)


Thanks,
Jonathan Neuschäfer

Re: [Gtkpod-devel] gtkpod / Anuta 3.6 compatibility

[phantomjinx <p.g...@ph...>]

Committed.

Many thanks for the report and patch.

PGR

On 10/13/2012 02:27 PM, Dimstar / Dominique Leuenberger wrote:
> Hi list,
> 
> Anjuta had some minor API changes in the 3.5 / 3.6 development cycle
> which affects the capabilities of GTKPod to be built.
> 
> Attached a patch that seems to address this, hopefully the right way.
> 
> Feel free to use or ignore.
> 
> Best regards
> Dominique
> 
> 
> 
> This body part will be downloaded on demand.
> 
> 
> 
> This body part will be downloaded on demand.
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

[Gtkpod-devel] gtkpod / Anuta 3.6 compatibility

[Dimstar / D. L. <di...@op...>]

Hi list,

Anjuta had some minor API changes in the 3.5 / 3.6 development cycle
which affects the capabilities of GTKPod to be built.

Attached a patch that seems to address this, hopefully the right way.

Feel free to use or ignore.

Best regards
Dominique

Re: [Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Jonathan N. <j.n...@gm...>]

On Sun, Oct 07, 2012 at 08:47:21AM +0200, Javier Kohen wrote:
> On Sat, Oct 6, 2012 at 6:06 PM, Jonathan Neuschäfer
> <j.n...@gm...>wrote:
> 
> > On Sat, Oct 06, 2012 at 10:22:29AM +0200, Javier Kohen wrote:
> > > Actually they made it to the list :-) I have commit rights and they look
> > > good to me, but I'd rather wait for someone who's worked more closely
> > with
> > > the distros to take a look, to make sure we're not locking users out from
> > > gktpod (I would think not, except for very old distros... but I don't
> > have
> > > much practical experience with them).
> >
> > The only patch that should cause any trouble is the one that replaces
> > g_mapped_file_free by g_mapped_file_unref (introduced in glib 2.22).
> > I suggest adding something like the following somewhere in the libgpod
> > source (glib-compat.h, maybe):
> >
> >         #if GLIB_VERSION_CHECK(2,22,0) == 0
> >         #define g_mapped_file_unref(f) g_mapped_file_free(f)
> >         #endif
> >
> > I've pushed the rest of the patchset as "dev2" on github.
> >
> 
> I've pull all your changes and pushed them, as libgpod doesn't compile with
> glib 2.22+ without this patch (all warnings cause compilation errors).
> Instead of the fix you suggested I'm using AC_CHECK_FUNCS.

Right, that's cleaner.

> 
> Thank you!
> 
> 
> > [ BTW, gtkpod requires GLib 2.28. ]
> >
> > Thanks,
> > Jonathan Neuschäfer
> >

Re: [Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Javier K. <jk...@gm...>]

On Sat, Oct 6, 2012 at 6:06 PM, Jonathan Neuschäfer
<j.n...@gm...>wrote:

> On Sat, Oct 06, 2012 at 10:22:29AM +0200, Javier Kohen wrote:
> > Actually they made it to the list :-) I have commit rights and they look
> > good to me, but I'd rather wait for someone who's worked more closely
> with
> > the distros to take a look, to make sure we're not locking users out from
> > gktpod (I would think not, except for very old distros... but I don't
> have
> > much practical experience with them).
>
> The only patch that should cause any trouble is the one that replaces
> g_mapped_file_free by g_mapped_file_unref (introduced in glib 2.22).
> I suggest adding something like the following somewhere in the libgpod
> source (glib-compat.h, maybe):
>
>         #if GLIB_VERSION_CHECK(2,22,0) == 0
>         #define g_mapped_file_unref(f) g_mapped_file_free(f)
>         #endif
>
> I've pushed the rest of the patchset as "dev2" on github.
>

I've pull all your changes and pushed them, as libgpod doesn't compile with
glib 2.22+ without this patch (all warnings cause compilation errors).
Instead of the fix you suggested I'm using AC_CHECK_FUNCS.

Thank you!


> [ BTW, gtkpod requires GLib 2.28. ]
>
> Thanks,
> Jonathan Neuschäfer
>

Re: [Gtkpod-devel] gtkpod fails to build in debian, patch

[phantomjinx <p.g...@ph...>]

Committed. Many thanks for the report and patch.

PGR

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

Re: [Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Jonathan N. <j.n...@gm...>]

On Sat, Oct 06, 2012 at 10:22:29AM +0200, Javier Kohen wrote:
> On Sat, Oct 6, 2012 at 2:08 AM, Jonathan Neuschäfer
> > As the mails with the actual patches don't seem to have reached the
> > mailing list,
> 
> Actually they made it to the list :-) I have commit rights and they look

I blame mailman's "Avoid duplicate copies of messages" option. :-)

Re: [Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Jonathan N. <j.n...@gm...>]

On Sat, Oct 06, 2012 at 10:22:29AM +0200, Javier Kohen wrote:
> Actually they made it to the list :-) I have commit rights and they look
> good to me, but I'd rather wait for someone who's worked more closely with
> the distros to take a look, to make sure we're not locking users out from
> gktpod (I would think not, except for very old distros... but I don't have
> much practical experience with them).

The only patch that should cause any trouble is the one that replaces
g_mapped_file_free by g_mapped_file_unref (introduced in glib 2.22).
I suggest adding something like the following somewhere in the libgpod
source (glib-compat.h, maybe):

	#if GLIB_VERSION_CHECK(2,22,0) == 0
	#define g_mapped_file_unref(f) g_mapped_file_free(f)
	#endif

I've pushed the rest of the patchset as "dev2" on github.

[ BTW, gtkpod requires GLib 2.28. ]

Thanks,
Jonathan Neuschäfer

Re: [Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Javier K. <jk...@gm...>]

On Sat, Oct 6, 2012 at 2:08 AM, Jonathan Neuschäfer
<j.n...@gm...>wrote:

> On Fri, Sep 28, 2012 at 09:23:53PM +0200, Jonathan Neuschäfer wrote:
> > Hi,
> >
> > A little libgpod patchset for you devs. Thanks for libgpod and gtkpod.
> >
> > The first three patches replace calls to deprecated GLib/Gdk functions
> > with calls to supported ones. The other two functions will make sense if
> > you look at them. :-)
> >
> > * c77a4b2 replace deprecated g_mapped_file_free()
> > * 6c008df replace deprecated g_basename()
> > * f03c72a replace deprecated gdk_pixbuf_unref()
> > * 53480eb configure.ac: show --disable-udev, not --enable-udev
> > * f2d3b3c configure.ac: fix a minor typo
>
> As the mails with the actual patches don't seem to have reached the
> mailing list,


Actually they made it to the list :-) I have commit rights and they look
good to me, but I'd rather wait for someone who's worked more closely with
the distros to take a look, to make sure we're not locking users out from
gktpod (I would think not, except for very old distros... but I don't have
much practical experience with them).



> I've put my branch on github:
>
>         git://github.com/neuschaefer/libgpod.git dev
>         https://github.com/neuschaefer/libgpod/commits/dev
>
> Please note that I haven't checked the compatibility with older versions
> of glib or gdk (yet).
>



>
> The configure.ac-related patches can also be found in the conf branch of
> the same github repository.
>
> Thanks,
> Jonathan Neuschäfer
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
>

Re: [Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Jonathan N. <j.n...@gm...>]

On Fri, Sep 28, 2012 at 09:23:53PM +0200, Jonathan Neuschäfer wrote:
> Hi,
> 
> A little libgpod patchset for you devs. Thanks for libgpod and gtkpod.
> 
> The first three patches replace calls to deprecated GLib/Gdk functions
> with calls to supported ones. The other two functions will make sense if
> you look at them. :-)
> 
> * c77a4b2 replace deprecated g_mapped_file_free()
> * 6c008df replace deprecated g_basename()
> * f03c72a replace deprecated gdk_pixbuf_unref()
> * 53480eb configure.ac: show --disable-udev, not --enable-udev
> * f2d3b3c configure.ac: fix a minor typo

As the mails with the actual patches don't seem to have reached the
mailing list, I've put my branch on github:

	git://github.com/neuschaefer/libgpod.git dev
	https://github.com/neuschaefer/libgpod/commits/dev

Please note that I haven't checked the compatibility with older versions
of glib or gdk (yet).

The configure.ac-related patches can also be found in the conf branch of
the same github repository.

Thanks,
Jonathan Neuschäfer

Re: [Gtkpod-devel] gtkpod fails to build in debian, patch

[Javier K. <jk...@gm...>]

On Wed, Oct 3, 2012 at 7:11 PM, phantomjinx <
p.g...@ph...> wrote:

> "Brent S. Elmer Ph.D." <we...@ai...> wrote:
>
>> gtkpod fails to build in debian testing.  It gives the following error:
>>
>> clarity_cover.c:244:9: error: format not a string literal and no format
>> arguments [-Werror=format-security]
>>
>> I fixed the problem like this:
>>
>> gtkpod-2.1.2/plugins/clarity/clarity_cover.c
>>
>>     // Set cover artwork
>>     gtk_clutter_texture_set_from_pixbuf
>> (GTK_CLUTTER_TEXTURE(priv->texture), item->albumart, &error);
>>     if (error) {
>> +       g_warning("%s", error->message);
>> -       g_warning(error->message);
>>         g_error_free(error);
>>         return;
>>     }
>>
>> After the fix gtkpod compiled.
>>
>>
>>
>> ------------------------------
>>
>> Don't let slow site performance ruin your business. Deploy New Relic APM
>> Deploy New Relic app performance management and know exactly
>> what is happening inside your Ruby, Python, PHP, Java, and .NET app
>> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
>> http://p.sf.net/sfu/newrelic-dev2dev
>> ------------------------------
>>
>> Gtkpod-devel mailing list
>> Gtk...@li...
>> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
>>
>>
> Thanks. Little perplexed why that would be a compile error ...
>

Because if a user manages to sneak a %-printf code in the error message he
might get a crash at best, or the system could be compromised at worst. In
any case the result is not defined.

Re: [Gtkpod-devel] gtkpod fails to build in debian, patch

[Brent S. E. Ph.D. <we...@ai...>]

On Wed, 2012-10-03 at 18:11 +0100, phantomjinx wrote:
> "Brent S. Elmer Ph.D." <we...@ai...> wrote:
>         gtkpod fails to build in debian testing.  It gives the following error:
>         
>         clarity_cover.c:244:9: error: format not a string literal and no format
>         arguments [-Werror=format-security]
>         
>         I fixed the problem like this:
>         
>         gtkpod-2.1.2/plugins/clarity/clarity_cover.c
>         
>             // Set cover artwork
>             gtk_clutter_texture_set_from_pixbuf
>         (GTK_CLUTTER_TEXTURE(priv->texture), item->albumart, &error);
>             if (error) {
>         +       g_warning("%s", error->message);
>         -       g_warning(error->message);
>                 g_error_free(error);
>                 return;
>             }
>         
>         After the fix gtkpod compiled.
>         
>         
>         
>         
>         ______________________________________________________________
>         
>         Don't let slow site performance ruin your business. Deploy New Relic APM
>         Deploy New Relic app performance management and know exactly
>         what is happening inside your Ruby, Python, PHP, Java, and .NET app
>         Try New Relic at no cost today and get our sweet Data Nerd shirt too!
>         http://p.sf.net/sfu/newrelic-dev2dev
>         
>         ______________________________________________________________
>         
>         Gtkpod-devel mailing list
>         Gtk...@li...
>         https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 
> Thanks. Little perplexed why that would be a compile error ...
> 
> PGR

Maybe the debian source package and build uses some special flags that
make it a compiler error(probably -Werror=format-security).  By the way,
there are also some deprecated warnings.  If it helps, here is the
compile command as from the debian build process:

  CC     libclarity_la-clarity_cover.lo
/bin/sh ../../libtool --silent --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H
-I. -I../..  -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\"
-DGTKPOD_DATA_DIR=\"/usr/share/gtkpod/data\"
-DGTKPOD_PLUGIN_DIR=\"/usr/lib/i386-linux-gnu/gtkpod\"
-DGTKPOD_IMAGE_DIR=\"/usr/share/gtkpod/icons\"
-DGTKPOD_GLADE_DIR=\"/usr/share/gtkpod/data/glade\"
-DGTKPOD_SCRIPT_DIR=\"/usr/share/gtkpod/scripts\"
-DGTKPOD_UI_DIR=\"/usr/share/gtkpod/data/ui\" -DPACKAGE_DATA_DIR=\"/usr/share\"
-DPACKAGE_SRC_DIR=\".\" -I../.. -g -O2 -fstack-protector --param=ssp-buffer-
size=4 -Wformat -Werror=format-security -Wall -Wno-pointer-sign -std=gnu99
-Werror-implicit-function-declaration -pthread -I/usr/include/gtk-3.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12   -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include   -pthread -I/usr/include/gtk-3.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2
-I/usr/include/libpng12   -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include   -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include    -pthread -I/usr/include/gpod-1.0
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/libxml2
-I/usr/include/p11-kit-1   -pthread -I/usr/include/libxml2
-I/usr/include/gtk-3.0 -I/usr/include/libgdl-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/libpng12 -I/usr/include/libanjuta-3.0   -pthread
-I/usr/include/libgdl-3.0 -I/usr/include/gtk-3.0 -I/usr/include/libxml2
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12   -I/usr/include/libxml2
-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES
-DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE -pthread -I/usr/include/clutter-
gtk-1.0 -I/usr/include/clutter-1.0 -I/usr/include/gtk-3.0
-I/usr/include/pango-1.0 -I/usr/include/cogl -I/usr/include/cairo
-I/usr/include/atk-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pixman-1
-I/usr/include/gio-unix-2.0/   -pthread -I/usr/include/gstreamer-0.10
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/libxml2   -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/pixman-1
-I/usr/include/libpng12 -I/usr/include/brasero3   -pthread
-I/usr/include/libxml2 -I/usr/include/gtk-3.0 -I/usr/include/libgdl-3.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/libanjuta-3.0
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/clutter-gtk-1.0
-I/usr/include/clutter-1.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/cogl -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include
/json-glib-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/gio-unix-2.0/
-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-
security -Wall -Wno-pointer-sign -std=gnu99 -Werror-implicit-function-
declaration -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/libpng12   -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include   -pthread -I/usr/include/gtk-3.0 -I/usr/include/gio-
unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gdk-
pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12
-pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-pthread -I/usr/include/gpod-1.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12
-I/usr/include/libxml2 -I/usr/include/p11-kit-1   -pthread
-I/usr/include/libxml2 -I/usr/include/gtk-3.0 -I/usr/include/libgdl-3.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/libanjuta-3.0
-pthread -I/usr/include/libgdl-3.0 -I/usr/include/gtk-3.0
-I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12
-I/usr/include/libxml2     -DG_DISABLE_SINGLE_INCLUDES
-DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES
-DGSEAL_ENABLE -pthread -I/usr/include/clutter-gtk-1.0
-I/usr/include/clutter-1.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/cogl -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include
/json-glib-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/gio-unix-2.0/
-pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/libxml2   -pthread
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12
-I/usr/include/brasero3   -c -o libclarity_la-clarity_cover.lo `test -f
'clarity_cover.c' || echo './'`clarity_cover.c
clarity_cover.c: In function 'clarity_cover_set_album_item':
clarity_cover.c:244:9: error: format not a string literal and no format
arguments [-Werror=format-security]
clarity_cover.c: In function 'clarity_cover_clear_rotation_behaviour':
clarity_cover.c:293:5: warning: 'clutter_behaviour_is_applied' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour.h:164) [-Wdeprecated-declarations]
clarity_cover.c:294:9: warning: 'clutter_behaviour_remove' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour.h:143) [-Wdeprecated-declarations]
clarity_cover.c: In function 'clarity_cover_set_rotation_behaviour':
clarity_cover.c:310:9: warning: 'clutter_behaviour_rotate_new' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-behaviour-
rotate.h:82): Use 'clutter_actor_animate' instead [-Wdeprecated-declarations]
clarity_cover.c:317:9: warning: 'clutter_behaviour_rotate_set_center' is
deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour-rotate.h:93) [-Wdeprecated-declarations]
clarity_cover.c:322:9: warning: 'clutter_behaviour_apply' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour.h:140) [-Wdeprecated-declarations]
cc1: some warnings being treated as errors
make[5]: *** [libclarity_la-clarity_cover.lo] Error 1
make[5]: Leaving directory `/usr/local/src/gtkpod-2.1.2/plugins/clarity'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/usr/local/src/gtkpod-2.1.2/plugins/clarity'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/usr/local/src/gtkpod-2.1.2/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/local/src/gtkpod-2.1.2'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/local/src/gtkpod-2.1.2'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Build command 'cd gtkpod-2.1.2 && dpkg-buildpackage -b -uc' failed.
E: Child process failed

Brent

Re: [Gtkpod-devel] gtkpod fails to build in debian, patch

[phantomjinx <p.g...@ph...>]

"Brent S. Elmer Ph.D." <we...@ai...> wrote:

gtkpod fails to build in debian testing. It gives the following error:

clarity_cover.c:244:9: error: format not a string literal and no format
arguments [-Werror=format-security]

I fixed the problem like this:

gtkpod-2.1.2/plugins/clarity/clarity_cover.c

// Set cover artwork
gtk_clutter_texture_set_from_pixbuf
(GTK_CLUTTER_TEXTURE(priv->texture), item->albumart, &error);
if (error) {
+ g_warning("%s", error->message);
- g_warning(error->message);
g_error_free(error);
return;
}

After the fix gtkpod compiled.



_____________________________________________

Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_____________________________________________

Gtkpod-devel mailing list
Gtk...@li...
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel


Thanks. Little perplexed why that would be a compile error ...

PGR

[Gtkpod-devel] gtkpod fails to build in debian, patch

[Brent S. E. Ph.D. <we...@ai...>]

gtkpod fails to build in debian testing.  It gives the following error:

clarity_cover.c:244:9: error: format not a string literal and no format
arguments [-Werror=format-security]

I fixed the problem like this:

gtkpod-2.1.2/plugins/clarity/clarity_cover.c

    // Set cover artwork
    gtk_clutter_texture_set_from_pixbuf
(GTK_CLUTTER_TEXTURE(priv->texture), item->albumart, &error);
    if (error) {
+       g_warning("%s", error->message);
-       g_warning(error->message);
        g_error_free(error);
        return;
    }

After the fix gtkpod compiled.

[Gtkpod-devel] [PATCH 4/5] configure.ac: show --disable-udev, not --enable-udev

[Jonathan N. <j.n...@gm...>]

This makes it more obvious that udev is enabled by default.
---
 configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 669d433..25a14d2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -164,7 +164,7 @@ dnl * nowadays (2009), it's the recommended way of having callouts, so
 dnl * it should be preferred over HAL, and it's enabled by default.
 dnl ***********************************************************************
 AC_ARG_ENABLE(udev,
-             [AS_HELP_STRING([--enable-udev],[Enable udev callout])],
+             [AS_HELP_STRING([--disable-udev],[Disable udev callout])],
              [if test x"$enableval" = "xno" ; then
                  enable_udev=no
               else
-- 
1.7.10.4

[Gtkpod-devel] [PATCH 5/5] configure.ac: fix a minor typo

[Jonathan N. <j.n...@gm...>]

---
 configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 25a14d2..04949cc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -192,7 +192,7 @@ AH_TEMPLATE([TMPMOUNTDIR], [Directory where HAL/udev will create a sub-directory
 AC_DEFINE_UNQUOTED(TMPMOUNTDIR, "$with_temp_mount_dir", [Directory where HAL/udev will create a sub-directory to mount iPods])
 
 dnl ***********************************************************************
-dnl * provide a $l{ibdir}/libgpod directory for external modules
+dnl * provide a ${libdir}/libgpod directory for external modules
 dnl ***********************************************************************
 AC_ARG_WITH(libgpod-blob-dir, [AC_HELP_STRING([--with-libgpod-blob-dir=PATH],
                                               [Load libgpod binary blobs from this directory [LIBDIR/libgpod]])],
-- 
1.7.10.4

[Gtkpod-devel] [PATCH 2/5] replace deprecated g_basename()

[Jonathan N. <j.n...@gm...>]

g_basename is deprecated since GLib 2.2.

As all of these calls are done just before the program terminates,
we might as well skip the g_free.
---
 tests/get-timezone.c         |    4 +++-
 tests/itdb_main.c            |    5 ++++-
 tests/test-cp.cc             |    4 +++-
 tests/test-fw-id.c           |    4 +++-
 tests/test-ls.c              |    6 ++++--
 tests/test-rebuild-db.cc     |    4 +++-
 tools/ipod-time-sync.c       |    6 ++++--
 tools/read-sysinfoextended.c |    6 ++++--
 8 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/tests/get-timezone.c b/tests/get-timezone.c
index e453ca3..60977d9 100644
--- a/tests/get-timezone.c
+++ b/tests/get-timezone.c
@@ -28,7 +28,9 @@ int main (int argc, char **argv)
     if (argc >= 2) {
         mountpoint = argv[1];
     } else {
-        g_print ("Usage: %s <mountpoint>\n\n", g_basename(argv[0]));
+        char *basename = g_path_get_basename(argv[0]);
+        g_print ("Usage: %s <mountpoint>\n\n", basename);
+        g_free (basename);
         return -1;
     }
 
diff --git a/tests/itdb_main.c b/tests/itdb_main.c
index e7723bb..1cc03a4 100644
--- a/tests/itdb_main.c
+++ b/tests/itdb_main.c
@@ -55,7 +55,10 @@ main (int argc, char *argv[])
 
   if (infile == 0)
   {
-      printf ("Usage: %s <infile> [<outfile>]\n",  g_basename(argv[0]));
+      char *basename = g_path_get_basename(argv[0]);
+      printf ("Usage: %s <infile> [<outfile>]\n", basename);
+      g_free(basename);
+
       exit (0);
   }
 
diff --git a/tests/test-cp.cc b/tests/test-cp.cc
index cec778d..73a1dd9 100644
--- a/tests/test-cp.cc
+++ b/tests/test-cp.cc
@@ -108,8 +108,10 @@ int main (int argc, char **argv)
 	GError *error;
 
 	if (argc != 3) {
+		char *basename = g_path_get_basename(argv[0]);
 		g_print ("Usage:\n");
-		g_print ("%s <filename> <mountpoint> \n", g_basename (argv[0]));
+		g_print ("%s <filename> <mountpoint> \n", basename);
+		g_free (basename);
 		exit (1);
 	}
 
diff --git a/tests/test-fw-id.c b/tests/test-fw-id.c
index 7490001..085123a 100644
--- a/tests/test-fw-id.c
+++ b/tests/test-fw-id.c
@@ -42,7 +42,9 @@ main (int argc, char *argv[])
     char *fwid;
 
     if (argc < 2) {
-        g_print ("Usage: %s <mountpoint>\n", g_basename (argv[0]));
+        char *basename = g_path_get_basename(argv[0]);
+        g_print ("Usage: %s <mountpoint>\n", basename);
+        g_free (basename);
         return 1;
 
     }
diff --git a/tests/test-ls.c b/tests/test-ls.c
index e28cd9c..464824e 100644
--- a/tests/test-ls.c
+++ b/tests/test-ls.c
@@ -118,10 +118,12 @@ main (int argc, char *argv[])
  
   if (mountpoint == NULL)
   {
+      char *basename = g_path_get_basename (argv[0]);
       g_print ("Usage: %s <mountpoint>|-l [<playlistname>]\n\n"
                "-l - List from the local repository (~" LOCALDB ")\n"
-	       "<playlistname> - name of the playlist to list (optional)\n",  
-                g_basename(argv[0]));
+               "<playlistname> - name of the playlist to list (optional)\n",
+               basename);
+      g_free (basename);
       exit (0);
   }
 
diff --git a/tests/test-rebuild-db.cc b/tests/test-rebuild-db.cc
index fbcaf1e..f2b05ef 100644
--- a/tests/test-rebuild-db.cc
+++ b/tests/test-rebuild-db.cc
@@ -216,8 +216,10 @@ int main (int argc, char **argv)
 	GError *error;
 
 	if (argc != 2) {
+		char *basename = g_path_get_basename(argv[0]);
 		g_print ("Usage:\n");
-		g_print ("%s <mountpoint>\n", g_basename (argv[0]));
+		g_print ("%s <mountpoint>\n", basename);
+		g_free (basename);
 		exit (1);
 	}
 
diff --git a/tools/ipod-time-sync.c b/tools/ipod-time-sync.c
index 0cc62f1..a0cc163 100644
--- a/tools/ipod-time-sync.c
+++ b/tools/ipod-time-sync.c
@@ -34,8 +34,10 @@ int
 main (int argc, char **argv)
 {
     if (argc < 2) {
-        g_print (_("usage: %s <device> [timezone]\n"), g_basename (argv[0]));
-	return 1;
+        char *basename = g_path_get_basename (argv[0]);
+        g_print (_("usage: %s <device> [timezone]\n"), basename);
+        g_free (basename);
+        return 1;
     }
 
     sync_time (argv[1], NULL);
diff --git a/tools/read-sysinfoextended.c b/tools/read-sysinfoextended.c
index b3afd2c..8262137 100644
--- a/tools/read-sysinfoextended.c
+++ b/tools/read-sysinfoextended.c
@@ -78,8 +78,10 @@ main (int argc, char **argv)
     char *xml;
     
     if (argc < 3) {
-      g_print (_("usage: %s <device|uuid|bus device> <mountpoint>\n"), g_basename (argv[0]));
-	return 1;
+      char *basename = g_path_get_basename (argv[0]);
+      g_print (_("usage: %s <device|uuid|bus device> <mountpoint>\n"), basename);
+      g_free (basename);
+      return 1;
     }
 
     xml = NULL;
-- 
1.7.10.4

[Gtkpod-devel] [PATCH 3/5] replace deprecated gdk_pixbuf_unref()

[Jonathan N. <j.n...@gm...>]

gdk_pixbuf_unref is depreceted since Gdk 2.0.
---
 src/itdb_artwork.c  |    6 +++---
 src/itdb_thumb.c    |    4 ++--
 tests/test-covers.c |    2 +-
 tests/test-photos.c |    2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/itdb_artwork.c b/src/itdb_artwork.c
index 2328840..c595d70 100644
--- a/src/itdb_artwork.c
+++ b/src/itdb_artwork.c
@@ -849,7 +849,7 @@ gpointer itdb_thumb_ipod_item_to_pixbuf (Itdb_Device *device,
 				      NULL);
 
 	/* !! do not g_free(pixels) here: it will be freed when doing a
-	 * gdk_pixbuf_unref() on the GdkPixbuf !! */
+	 * g_object_unref() on the GdkPixbuf !! */
 
 	/* Remove padding from the pixmap and/or cut the pixmap to the
 	   right size. */
@@ -882,8 +882,8 @@ gpointer itdb_thumb_ipod_item_to_pixbuf (Itdb_Device *device,
 					       pad_x, pad_y,
 					       width, height);
 	pixbuf = gdk_pixbuf_copy (pixbuf_sub);
-	gdk_pixbuf_unref (pixbuf_full);
-	gdk_pixbuf_unref (pixbuf_sub);
+	g_object_unref (pixbuf_full);
+	g_object_unref (pixbuf_sub);
 
         return pixbuf;
 }
diff --git a/src/itdb_thumb.c b/src/itdb_thumb.c
index 8ed3b6f..8b3c8a1 100644
--- a/src/itdb_thumb.c
+++ b/src/itdb_thumb.c
@@ -374,7 +374,7 @@ const GList *itdb_thumb_ipod_get_thumbs (Itdb_Thumb_Ipod *thumbs)
  * GDK_PIXBUF() yourself.
  * </note>
  *
- * Returns: a #GdkPixbuf that must be unreffed with gdk_pixbuf_unref()
+ * Returns: a #GdkPixbuf that must be unreffed with g_object_unref()
  * after use, or NULL if the creation of the gdk-pixbuf failed or if
  * libgpod was compiled without gdk-pixbuf support.
  *
@@ -547,7 +547,7 @@ static GList *itdb_thumb_ipod_to_pixbufs (Itdb_Device *device,
  *
  * Returns: a #GList of #GdkPixbuf which are associated with @thumb, NULL
  * if the pixbuf was invalid or if libgpod is compiled without gdk-pixbuf
- * support. The #GdkPixbuf must be unreffed with gdk_pixbuf_unref() after use
+ * support. The #GdkPixbuf must be unreffed with g_object_unref() after use
  * and the #GList must be freed with g_list_free().
  *
  * Since: 0.7.0
diff --git a/tests/test-covers.c b/tests/test-covers.c
index 20b4d7b..4d3a68f 100644
--- a/tests/test-covers.c
+++ b/tests/test-covers.c
@@ -53,7 +53,7 @@ save_itdb_thumb (Itdb_Track *track, GdkPixbuf *pixbuf, guint id)
         }
         g_print ("  %s\n", filename);
         gdk_pixbuf_save (pixbuf, filename, "png", NULL, NULL);
-        gdk_pixbuf_unref (pixbuf);
+        g_object_unref (pixbuf);
         /*		g_print ("Saved %s\n", filename); */
         g_free (filename);
 }
diff --git a/tests/test-photos.c b/tests/test-photos.c
index 930e66b..b5bd89d 100644
--- a/tests/test-photos.c
+++ b/tests/test-photos.c
@@ -81,7 +81,7 @@ dump_thumbs (Itdb_PhotoDB *db, Itdb_Artwork *artwork,
 		path = g_build_filename (dir, filename, NULL);
 		g_free (filename);
 		gdk_pixbuf_save (pixbuf, path, "png", NULL, NULL);
-		gdk_pixbuf_unref (pixbuf);
+		g_object_unref (pixbuf);
 		g_free (path);
 	}
         g_list_free (thumbnails);
-- 
1.7.10.4

[Gtkpod-devel] [PATCH 1/5] replace deprecated g_mapped_file_free()

[Jonathan N. <j.n...@gm...>]

g_mapped_file_free is deprecated since GLib 2.22
---
 src/db-parse-context.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/db-parse-context.c b/src/db-parse-context.c
index 88009c9..789b3e9 100644
--- a/src/db-parse-context.c
+++ b/src/db-parse-context.c
@@ -64,7 +64,7 @@ db_parse_context_destroy (DBParseContext *ctx)
 	g_return_if_fail (ctx != NULL);
 
 	if (ctx->mapped_file) {
-		g_mapped_file_free(ctx->mapped_file);
+		g_mapped_file_unref(ctx->mapped_file);
 	}
 
 	g_free (ctx);
@@ -215,7 +215,7 @@ db_parse_context_new_from_file (const char *filename, Itdb_DB *db)
 					device->byte_order);
 
 	if (ctx == NULL) {
-		g_mapped_file_free(mapped_file);
+		g_mapped_file_unref(mapped_file);
 		return NULL;
 	}
 	ctx->db = db;
-- 
1.7.10.4

[Gtkpod-devel] [PATCHSET] libgpod: replace deprecated glib calls + two random patches

[Jonathan N. <j.n...@gm...>]

Hi,

A little libgpod patchset for you devs. Thanks for libgpod and gtkpod.

The first three patches replace calls to deprecated GLib/Gdk functions
with calls to supported ones. The other two functions will make sense if
you look at them. :-)

* c77a4b2 replace deprecated g_mapped_file_free()
* 6c008df replace deprecated g_basename()
* f03c72a replace deprecated gdk_pixbuf_unref()
* 53480eb configure.ac: show --disable-udev, not --enable-udev
* f2d3b3c configure.ac: fix a minor typo


Thanks,
Jonathan Neuschäfer

[Gtkpod-devel] (no subject)

[George S. <gg...@pa...>]

http://www.homeandschoolscience.com/wp-content/plugins/googleanalytics/likeit.php?Sunday209.png

Re: [Gtkpod-devel] Sync music with a Jailbreak iPhone4 and IOS 5.1.1

[Niccolò B. <dar...@li...>]

Il 11/09/2012 15:36, Michaël Cadilhac ha scritto:
 > Hey there Niccolò;
 >
 > I saw your post on the GtkPod mailing list, which had no answer
 > whatsoever.  So, did you succeed in syncing your iPhone with IOS
 > 5.1.1? I experience the same symptom as you...
 >
 > Thanks!

Still no luck, but if you jailbreaked then you can try pwntunes. Mount 
iPhone in Linux, copy music, unmount and THEN flick the "needs sync" 
switch in settings. Close down Music app via Multitasking and relaunch 
Music app. It will then sync.

I really hate this piece of shit of phone :|

Niccolò
-- 
http://www.linuxsystems.it