gtkpod-devel — gtkpod development issues

Re: [Gtkpod-devel] About newer iOS and devices

[Henrique C. U. <hen...@gm...>]

2013/10/28 "Andrés G. Aragoneses" <kn...@gm...>

> BTW, if libgpod doesn't support devices from version X of iOS, shouldn't
> libgpod emit an error (fail fast), so the consumers of the
> library (media players) can tell the user about it, instead of fail
> miserably and make the user think that the media player is buggy?
>

That is indeed a very good idea.

Henrique Cesar Ulbrich
hen...@gm...

Re: [Gtkpod-devel] [Gtkpod-questions] About newer iOS and devices

[<tin...@gm...>]

On Sat, Oct 26, 2013 at 16:37:38 -0200, Henrique Cesar Ulbrich wrote:
> I guess I failed to explain. Language barrier, you know. English is not one
> of my strongest skills. Let's try again:
> 
> Of course, it's not supported. But there must be a reason for not being
> supported. For iOS 4 and up a new version of libgpod would have to be
> written to make use of some kind of binary blob from Apple. My question is:
> 
> 1. Did someone research or document those things? How deep did he/she go in
> the matter? Is this documentation, if exists, archived somewhere?
> 
> 2. If not, did this at least been discussed in the mailing lists? Did
> someone find something that could be a starting point?

I guess frequent changes in new iOS versions that would break libgpod
are not a strong motivation to work on this. Apple sending lawyers to
people who participate in reverse engineering the iTunesDB certainly
doesn't help either.

Regards,
Tino

Re: [Gtkpod-devel] [Gtkpod-questions] About newer iOS and devices

[Henrique C. U. <hen...@gm...>]

I guess I failed to explain. Language barrier, you know. English is not one
of my strongest skills. Let's try again:

Of course, it's not supported. But there must be a reason for not being
supported. For iOS 4 and up a new version of libgpod would have to be
written to make use of some kind of binary blob from Apple. My question is:

1. Did someone research or document those things? How deep did he/she go in
the matter? Is this documentation, if exists, archived somewhere?

2. If not, did this at least been discussed in the mailing lists? Did
someone find something that could be a starting point?

Henrique Cesar Ulbrich
hen...@gm...


2013/10/24 <tin...@gm...>

> On Sat, Sep 07, 2013 at 12:39:17 -0300, Henrique Cesar Ulbrich wrote:
> > The issues for synching newer devices  and iOS > 4 are well known.
>
> AFAIK the issue is that iOS > 4 just won't work with libgpod at all. Am I
> correct?
>
> >
> > The question is: are all those issues documented somewhere, or one needs
> to
> > go through all mailing lists to gather scattered information?
> >
> > This is not criticism, I am really asking because I don't know. I
> couldn't
> > find these documented anywhere and I am willing to help in this effort.
> > Maybe it would help future adventurers.
>
> Hi,
>
> supported devices are mentioned here: http://www.gtkpod.org/ (Status of
> Supported Hardware)
>
> Regards,
> Tino
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> _______________________________________________
> Gtkpod-questions mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-questions
>

Re: [Gtkpod-devel] About newer iOS and devices

[<tin...@gm...>]

On Sat, Sep 07, 2013 at 12:39:17 -0300, Henrique Cesar Ulbrich wrote:
> The issues for synching newer devices  and iOS > 4 are well known.

AFAIK the issue is that iOS > 4 just won't work with libgpod at all. Am I
correct?

> 
> The question is: are all those issues documented somewhere, or one needs to
> go through all mailing lists to gather scattered information?
> 
> This is not criticism, I am really asking because I don't know. I couldn't
> find these documented anywhere and I am willing to help in this effort.
> Maybe it would help future adventurers.

Hi,

supported devices are mentioned here: http://www.gtkpod.org/ (Status of
Supported Hardware)

Regards,
Tino

[Gtkpod-devel] About newer iOS and devices

[Henrique C. U. <hen...@gm...>]

The issues for synching newer devices  and iOS > 4 are well known.

The question is: are all those issues documented somewhere, or one needs to
go through all mailing lists to gather scattered information?

This is not criticism, I am really asking because I don't know. I couldn't
find these documented anywhere and I am willing to help in this effort.
Maybe it would help future adventurers.
--
Henrique

[Gtkpod-devel] gtkpod 2.1.4 released

[phantomjinx <p.g...@ph...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Evening people,

2.1.4 kicked out of the door ...

Enjoy! Any problems then let me know and on to 2.1.5 ...

PGR

- -- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlInqkoACgkQcthLMIwdEb0ITwCg4PonhDECNgYhDIVKwBaX1Dil
RY0AnAqyYqiHwObIzj4q6E7cc/HIpisN
=ASG/
-----END PGP SIGNATURE-----

[Gtkpod-devel] libgpod 0.8.3

[Christophe F. <cfe...@gm...>]

Hey,

I've just pushed a libgpod 0.8.3 release. It's a minor release which
adds support for newer libimobiledevice 1.1.x releases, and removes
use of deprecated glib functions. For now, this makes libgpod
dependant on glib 2.32 even though configure.ac does not check for it.

You can get the tarball from
http://sourceforge.net/projects/gtkpod/files/libgpod/libgpod-0.8/libgpod-0.8.3.tar.bz2/download
and it's signed with my GPG key:
A525 E3EA 186A AB45 DD0F  86AF 24A4 69FB 7A56 F78E

Overview of changes in libgpod 0.8.3
====================================

* Add support for libimobiledevice 1.1.5 (there was an API/ABI break)
* Remove use of some deprecated glib functions
* Fix various issues found using clang/cppcheck
* Improve robustness of the iphone callout


Christophe

Re: [Gtkpod-devel] [Gtkpod-questions] gtkpod 2.1.4-beta1 released

[phantomjinx <p.g...@ph...>]

Daniele Forsi <df...@gm...> wrote:
>2013/8/25 phantomjinx:
>
>> 2.1.4-beta1 out the door and uploaded ...
>
>any idea why commit emails aren't sent?
>
>https://sourceforge.net/p/gtkpod/mailman/gtkpod-cvs2/
>
>-- 
>Daniele Forsi
>
>------------------------------------------------------------------------------
>Introducing Performance Central, a new site from SourceForge and 
>AppDynamics. Performance Central is your source for news, insights, 
>analysis and resources for efficient Application Performance
>Management. 
>Visit us today!
>http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>_______________________________________________
>Gtkpod-devel mailing list
>Gtk...@li...
>https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

Far as I noticed emails are being sent. Received a couple last night from my commits.

Re: [Gtkpod-devel] gtkpod 2.1.4-beta1 released

[Dimstar / D. L. <di...@op...>]

On Sam, 2013-08-24 at 23:03 +0100, phantomjinx wrote: 
> Evening people,
> 
> 2.1.4-beta1 out the door and uploaded ...
> 
> Changelog and NEWS have the details.

Hi,

I tried building gtkpod 2.1.4beta1 against GNOME 3.9.90;
The first issue encountered is the deprecation of GtkStock, which you
still seem to be making use of:

[   19s] gtkpod_app_iface.c: In function 'ok_to_close_gtkpod':
[   19s] gtkpod_app_iface.c:152:104: error: 'GTK_STOCK_SAVE' undeclared
(first use in this function)
[   19s]                  = gtkpod_confirmation_hig(GTK_MESSAGE_WARNING,
_("Save changes before quiting?"), str, GTK_STOCK_SAVE,
GTK_STOCK_CANCEL, _("Quit without saving"), NULL);
[   19s]
^
[   19s] gtkpod_app_iface.c:152:104: note: each undeclared identifier is
reported only once for each function it appears in
[   19s] gtkpod_app_iface.c:152:120: error: 'GTK_STOCK_CANCEL'
undeclared (first use in this function)
[   19s]                  = gtkpod_confirmation_hig(GTK_MESSAGE_WARNING,
_("Save changes before quiting?"), str, GTK_STOCK_SAVE,
GTK_STOCK_CANCEL, _("Quit without saving"), NULL);
[   19s]
^
[   19s] gtkpod_app_iface.c: In function
'gtkpod_display_command_ctx_menu':
[   19s] gtkpod_app_iface.c:611:61: error: 'GTK_STOCK_EXECUTE'
undeclared (first use in this function)
[   19s]          hookup_menu_item(menu, track_command_get_text(cmd),
GTK_STOCK_EXECUTE, G_CALLBACK (on_track_command_menuitem_activate),
pairarr);
[   19s]                                                              ^
[   19s] make[2]: *** [gtkpod_app_iface.lo] Error 1
[   19s] make[2]: Leaving directory
`/home/abuild/rpmbuild/BUILD/gtkpod-2.1.4/libgtkpod'

Hacking -DGTK_DISABLE_DEPRECATED out of configure gets me over this (but
I don't think this should be needed for a release).

With this done, the build fails further down with:
[   48s] gtkpod.c: In function 'on_gtkpod_delete_event':
[   48s] gtkpod.c:245:35: error: 'profile_manager' undeclared (first use
in this function)
[   48s]      anjuta_profile_manager_close (profile_manager);
[   48s]                                    ^

Cheers,
Dominique
-- 
Dimstar / Dominique Leuenberger <di...@op...>

Re: [Gtkpod-devel] [Gtkpod-questions] gtkpod 2.1.4-beta1 released

[Daniele F. <df...@gm...>]

2013/8/25 phantomjinx:

> 2.1.4-beta1 out the door and uploaded ...

any idea why commit emails aren't sent?

https://sourceforge.net/p/gtkpod/mailman/gtkpod-cvs2/

-- 
Daniele Forsi

Re: [Gtkpod-devel] gtkpod 2.1.4-beta1 released

[Willy S. R. <wi...@gm...>]

> I got this error while building this version
>
> make  all-recursive
> make[1]: Entering directory `/tmp/build/gtkpod-2.1.4'
> Making all in libgtkpod
> make[2]: Entering directory `/tmp/build/gtkpod-2.1.4/libgtkpod'
>   CC       gtkpod_app_iface.lo
>   CC       filetype_iface.lo
>   CC       track_command_iface.lo
>   CC       exporter_iface.lo
>   CC       repository_editor_iface.lo
>   CC       details_editor_iface.lo
>   CC       lyrics_editor_iface.lo
>   CC       photo_editor_iface.lo
>   CC       gp_private.lo
>   CC       gp_itdb.lo
>   CC       charset.lo
>   CC       sha1.lo
>   CC       file.lo
>   CC       file_itunesdb.lo
>   CC       file_convert.lo
>   CC       fileselection.lo
>   CC       misc_track.lo
>   CC       prefs.lo
>   CC       syncdir.lo
>   CC       misc.lo
>   CC       misc_conversion.lo
>   CC       clientserver.lo
>   CC       directories.lo
>   CC       tools.lo
>   CC       misc_playlist.lo
>   CC       stock_icons.lo
>   CC       gtkpod_app-marshallers.lo
>   CC       tool_menu_action.lo
>   CC       context_menus.lo
>   CC       autodetection.lo
> autodetection.c: In function 'autodetection_init':
> autodetection.c:179:9: warning: 'g_type_init' is deprecated (declared
> at /usr/include/glib-2.0/gobject/gtype.h:669)
> [-Wdeprecated-declarations]
>          g_once (&g_type_init_once, (GThreadFunc)g_type_init, NULL);
>          ^
>   CCLD     libgtkpod.la
> make[2]: Leaving directory `/tmp/build/gtkpod-2.1.4/libgtkpod'
> Making all in libs
> make[2]: Entering directory `/tmp/build/gtkpod-2.1.4/libs'
> Making all in atomic-parsley
> make[3]: Entering directory `/tmp/build/gtkpod-2.1.4/libs/atomic-parsley'
>   CXX      AP_AtomExtracts.lo
>   CXX      AP_commons.lo
>   CXX      AP_iconv.lo
>   CXX      APar_sha1.lo
>   CXX      APar_uuid.lo
>   CXX      AtomicParsley_genres.lo
>   CXX      AtomicParsley.lo
>   CXX      AtomicParsleyBridge.lo
>   CXXLD    libatomicparsley.la
> make[3]: Leaving directory `/tmp/build/gtkpod-2.1.4/libs/atomic-parsley'
> make[3]: Entering directory `/tmp/build/gtkpod-2.1.4/libs'
> make[3]: Nothing to be done for `all-am'.
> make[3]: Leaving directory `/tmp/build/gtkpod-2.1.4/libs'
> make[2]: Leaving directory `/tmp/build/gtkpod-2.1.4/libs'
> Making all in src
> make[2]: Entering directory `/tmp/build/gtkpod-2.1.4/src'
>   CC       anjuta-about.o
>   CC       anjuta-action-callbacks.o
>   CC       anjuta-app.o
>   CC       gtkpod.o
> gtkpod.c: In function ‘on_gtkpod_delete_event’:
> gtkpod.c:245:35: error: ‘profile_manager’ undeclared (first use in
> this function)
>      anjuta_profile_manager_close (profile_manager);
>                                    ^
> gtkpod.c:245:35: note: each undeclared identifier is reported only
> once for each function it appears in
> make[2]: *** [gtkpod.o] Error 1
> make[2]: Leaving directory `/tmp/build/gtkpod-2.1.4/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/tmp/build/gtkpod-2.1.4'
> make: *** [all] Error 2
>
> compiled against anjuta-3.8.4

Caused by this commit
http://sourceforge.net/p/gtkpod/code/ci/69b17cd9aa3fec77ca9ead566dd10a7bfdd9a4b9/tree/


-- 
Willy Sudiarto Raharjo
Personal Blog : http://willysr.blogspot.com
Linux Blog: http://slackblogs.blogspot.com

Re: [Gtkpod-devel] gtkpod 2.1.4-beta1 released

[Willy S. R. <wi...@gm...>]

> 2.1.4-beta1 out the door and uploaded ...
>
> Changelog and NEWS have the details.
>
> Will leave it about a week and if there is nothing significant then I will make the
> final release.

I got this error while building this version

make  all-recursive
make[1]: Entering directory `/tmp/build/gtkpod-2.1.4'
Making all in libgtkpod
make[2]: Entering directory `/tmp/build/gtkpod-2.1.4/libgtkpod'
  CC       gtkpod_app_iface.lo
  CC       filetype_iface.lo
  CC       track_command_iface.lo
  CC       exporter_iface.lo
  CC       repository_editor_iface.lo
  CC       details_editor_iface.lo
  CC       lyrics_editor_iface.lo
  CC       photo_editor_iface.lo
  CC       gp_private.lo
  CC       gp_itdb.lo
  CC       charset.lo
  CC       sha1.lo
  CC       file.lo
  CC       file_itunesdb.lo
  CC       file_convert.lo
  CC       fileselection.lo
  CC       misc_track.lo
  CC       prefs.lo
  CC       syncdir.lo
  CC       misc.lo
  CC       misc_conversion.lo
  CC       clientserver.lo
  CC       directories.lo
  CC       tools.lo
  CC       misc_playlist.lo
  CC       stock_icons.lo
  CC       gtkpod_app-marshallers.lo
  CC       tool_menu_action.lo
  CC       context_menus.lo
  CC       autodetection.lo
autodetection.c: In function 'autodetection_init':
autodetection.c:179:9: warning: 'g_type_init' is deprecated (declared
at /usr/include/glib-2.0/gobject/gtype.h:669)
[-Wdeprecated-declarations]
         g_once (&g_type_init_once, (GThreadFunc)g_type_init, NULL);
         ^
  CCLD     libgtkpod.la
make[2]: Leaving directory `/tmp/build/gtkpod-2.1.4/libgtkpod'
Making all in libs
make[2]: Entering directory `/tmp/build/gtkpod-2.1.4/libs'
Making all in atomic-parsley
make[3]: Entering directory `/tmp/build/gtkpod-2.1.4/libs/atomic-parsley'
  CXX      AP_AtomExtracts.lo
  CXX      AP_commons.lo
  CXX      AP_iconv.lo
  CXX      APar_sha1.lo
  CXX      APar_uuid.lo
  CXX      AtomicParsley_genres.lo
  CXX      AtomicParsley.lo
  CXX      AtomicParsleyBridge.lo
  CXXLD    libatomicparsley.la
make[3]: Leaving directory `/tmp/build/gtkpod-2.1.4/libs/atomic-parsley'
make[3]: Entering directory `/tmp/build/gtkpod-2.1.4/libs'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/tmp/build/gtkpod-2.1.4/libs'
make[2]: Leaving directory `/tmp/build/gtkpod-2.1.4/libs'
Making all in src
make[2]: Entering directory `/tmp/build/gtkpod-2.1.4/src'
  CC       anjuta-about.o
  CC       anjuta-action-callbacks.o
  CC       anjuta-app.o
  CC       gtkpod.o
gtkpod.c: In function ‘on_gtkpod_delete_event’:
gtkpod.c:245:35: error: ‘profile_manager’ undeclared (first use in
this function)
     anjuta_profile_manager_close (profile_manager);
                                   ^
gtkpod.c:245:35: note: each undeclared identifier is reported only
once for each function it appears in
make[2]: *** [gtkpod.o] Error 1
make[2]: Leaving directory `/tmp/build/gtkpod-2.1.4/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/build/gtkpod-2.1.4'
make: *** [all] Error 2

compiled against anjuta-3.8.4

-- 
Willy Sudiarto Raharjo
Personal Blog : http://willysr.blogspot.com
Linux Blog: http://slackblogs.blogspot.com

[Gtkpod-devel] gtkpod 2.1.4-beta1 released

[phantomjinx <p.g...@ph...>]

Evening people,

2.1.4-beta1 out the door and uploaded ...

Changelog and NEWS have the details.

Will leave it about a week and if there is nothing significant then I will make the
final release.

Extra Note:
Bug #124 [1] - recorded downstream by debian, concerns reading from an smb mount. This has not been
fixed since I think it concerns gio rather than gtkpod. More research required and I don't think it
significant enough to stop the release. However, if people disagree and/or want to test/research
this then let me know.

Cheers and regards

PGR

[1] http://gtkpod.org/bugs/index.php?do=details&task_id=124
-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

Re: [Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

[phantomjinx <p.g...@ph...>]

merged.

On 06/20/2013 04:54 PM, Jonathan Neuschäfer wrote:
> On Thu, Jun 20, 2013 at 04:18:16PM +0100, phantomjinx wrote:
>> Not sure this has been merged yet. Is it ready to be?
> 
> Yes, correct.  It will merge and build cleanly.
> 
> 
> Thanks,
> Jonathan
> 
> [...]
>>>   display_playlists: balance parentheses in a comment
>>>   display_playlists: remove outdated debugging printfs
>>>   playlist_display: support dropping playlist into an itdb
>>>   playlist_display: remove a comment about "SPL data"
>>>   playlist_display: reduce duplicate code
>>>
>>> plugins/playlist_display/display_playlists.c |   99 ++++++------------
>>> 1 file changed, 34 insertions(+), 65 deletions(-)
> [...]
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

Re: [Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

[Jonathan N. <j.n...@gm...>]

On Thu, Jun 20, 2013 at 04:18:16PM +0100, phantomjinx wrote:
> Not sure this has been merged yet. Is it ready to be?

Yes, correct.  It will merge and build cleanly.


Thanks,
Jonathan

[...]
> >   display_playlists: balance parentheses in a comment
> >   display_playlists: remove outdated debugging printfs
> >   playlist_display: support dropping playlist into an itdb
> >   playlist_display: remove a comment about "SPL data"
> >   playlist_display: reduce duplicate code
> > 
> > plugins/playlist_display/display_playlists.c |   99 ++++++------------
> > 1 file changed, 34 insertions(+), 65 deletions(-)
[...]

Re: [Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

[phantomjinx <p.g...@ph...>]

Not sure this has been merged yet. Is it ready to be?

PGR

On 06/03/2013 09:40 AM, Jonathan Neuschäfer wrote:
> Hi,
> 
> I've updated my previous patchset. The updated version is available at:
> 
> 	git://github.com/neuschaefer/gtkpod.git ui.v2
> 
> The commits are:
> 
>   display_playlists: balance parentheses in a comment
>   display_playlists: remove outdated debugging printfs
>   playlist_display: support dropping playlist into an itdb
>   playlist_display: remove a comment about "SPL data"
>   playlist_display: reduce duplicate code
> 
> plugins/playlist_display/display_playlists.c |   99 ++++++------------
> 1 file changed, 34 insertions(+), 65 deletions(-)
> 
> 
> Best regards,
> Jonathan Neuschäfer
> 
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite
> It's a free troubleshooting tool designed for production
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap2
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

Re: [Gtkpod-devel] [GIT PULL] command line handling with glib

[phantomjinx <p.g...@ph...>]

Thanks Jonathan!

Will aim to get the merged in the next week or so (hopefully the weekend), unless anyone else gets
there sooner.

Cheers

PGR


On 06/05/2013 11:04 AM, Jonathan Neuschäfer wrote:
> Hi,
> 
> I've updated the command line handling code in gtkpod to use the
> g_option_* API from glib, as Daniele Forsi suggested.
> 
> Please consider pulling the following branch:
> 
> 	git://github.com/neuschaefer/gtkpod.git cmdline
> 
> The commits are:
> 
>   main: add \n after "Error parsing options: %s"
>   main: translate "Error parsing options: %s\n"
>   libgtkpod/prefs: add --playcount option
>   use g_option_* for gtkpod's own options, too
> 
> libgtkpod/prefs.c |  102 ++++++++++++++-------------------------------
> libgtkpod/prefs.h |    1 +
> src/gtkpod.h      |    2 +
> src/main.c        |    5 ++-
> 4 files changed, 38 insertions(+), 72 deletions(-)
> 
> 
> Best regards,
> Jonathan Neuschäfer
> 
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. A cloud service to automate IT design, transition and operations
> 2. Dashboards that offer high-level views of enterprise services
> 3. A single system of record for all IT processes
> http://p.sf.net/sfu/servicenow-d2d-j
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

[Gtkpod-devel] [GIT PULL] command line handling with glib

[Jonathan N. <j.n...@gm...>]

Hi,

I've updated the command line handling code in gtkpod to use the
g_option_* API from glib, as Daniele Forsi suggested.

Please consider pulling the following branch:

	git://github.com/neuschaefer/gtkpod.git cmdline

The commits are:

  main: add \n after "Error parsing options: %s"
  main: translate "Error parsing options: %s\n"
  libgtkpod/prefs: add --playcount option
  use g_option_* for gtkpod's own options, too

libgtkpod/prefs.c |  102 ++++++++++++++-------------------------------
libgtkpod/prefs.h |    1 +
src/gtkpod.h      |    2 +
src/main.c        |    5 ++-
4 files changed, 38 insertions(+), 72 deletions(-)


Best regards,
Jonathan Neuschäfer

[Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

[Jonathan N. <j.n...@gm...>]

Hi,

I've updated my previous patchset. The updated version is available at:

	git://github.com/neuschaefer/gtkpod.git ui.v2

The commits are:

  display_playlists: balance parentheses in a comment
  display_playlists: remove outdated debugging printfs
  playlist_display: support dropping playlist into an itdb
  playlist_display: remove a comment about "SPL data"
  playlist_display: reduce duplicate code

plugins/playlist_display/display_playlists.c |   99 ++++++------------
1 file changed, 34 insertions(+), 65 deletions(-)


Best regards,
Jonathan Neuschäfer

Re: [Gtkpod-devel] [PATCH] po/de.po: untranslate --mountpoint

[Jonathan N. <j.n...@gm...>]

On Sat, Jun 01, 2013 at 08:06:00PM +0200, Daniele Forsi wrote:
> however I noticed now that gtkpod --help doesn't show that string and
> the other usage strings from libgtkpod/prefs.c because --help is
> intercepted by g_option_context_parse() in src/main.c
> 
> using GOption also for prefs.c would avoid translation of arguments
> and fix the formatting...

Thank you for the hint, I'm working on it now.


Regards,
Jonathan Neuschäfer

Re: [Gtkpod-devel] [PATCH] po/de.po: untranslate --mountpoint

[Daniele F. <df...@gm...>]

2013/5/31 Jonathan Neuschäfer <j.n...@gm...>:
> ---
>  po/de.po |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/po/de.po b/po/de.po
> index be89d1c..a881a47 100644
> --- a/po/de.po
> +++ b/po/de.po
> @@ -2315,7 +2315,7 @@ msgstr "  -m <Pfad>:    Einhängepunkt für iPod angeben\n"
>
>  #: ../libgtkpod/prefs.c:328
>  msgid "  --mountpoint: same as '-m'.\n"
> -msgstr "  --Einhängepunkt: wie '-m'.\n"
> +msgstr "  --mountpoint: wie '-m'.\n"
>
>  #: ../libgtkpod/prefs.c:496
>  #, c-format
> --
> 1.7.10.4
>

pushed, thank you

however I noticed now that gtkpod --help doesn't show that string and
the other usage strings from libgtkpod/prefs.c because --help is
intercepted by g_option_context_parse() in src/main.c

using GOption also for prefs.c would avoid translation of arguments
and fix the formatting...

-- 
Daniele Forsi

[Gtkpod-devel] [PATCH] po/de.po: untranslate --mountpoint

[Jonathan N. <j.n...@gm...>]

---
 po/de.po |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/po/de.po b/po/de.po
index be89d1c..a881a47 100644
--- a/po/de.po
+++ b/po/de.po
@@ -2315,7 +2315,7 @@ msgstr "  -m <Pfad>:    Einhängepunkt für iPod angeben\n"
 
 #: ../libgtkpod/prefs.c:328
 msgid "  --mountpoint: same as '-m'.\n"
-msgstr "  --Einhängepunkt: wie '-m'.\n"
+msgstr "  --mountpoint: wie '-m'.\n"
 
 #: ../libgtkpod/prefs.c:496
 #, c-format
-- 
1.7.10.4

Re: [Gtkpod-devel] [GIT PULL] UI fixes, code cleanup

[Jonathan N. <j.n...@gm...>]

(CC'ing gtkpod-devel)

On Fri, May 31, 2013 at 09:46:39PM +0200, Daniele Forsi wrote:
> 2013/5/31 Jonathan Neuschäfer:
> 
> >   usage: avoid the translation of args
> 
> I only looked at this commit and I'd suggest not to apply it because
> without args translators can't easily align the descriptions (if they
> want)

Agreed, drop this patch.

But we will have to watch out that translators don't translate the
option names, as it happened in po/de.po:

  #: ../libgtkpod/prefs.c:328
  msgid "  --mountpoint: same as '-m'.\n"
  msgstr "  --Einhängepunkt: wie '-m'.\n"

Luckily, it's the only case throughout po/.


Thanks,
Jonathan Neuschäfer

[Gtkpod-devel] [GIT PULL] UI fixes, code cleanup

[Jonathan N. <j.n...@gm...>]

Hello developers,

please consider pulling my gtkpod fixes from:

	git://github.com/neuschaefer/gtkpod.git ui

The commits are:

  display_playlists: balance parentheses in a comment
  display_playlists: remove outdated debugging printfs
  playlist_display: support dropping playlist into an itdb
  playlist_display: remove a comment about "SPL data"
  playlist_display: reduce duplicate code
  fix "Unknown option: (null)" on --misspelled-option
  usage: avoid the translation of args
  usage: improve output style

libgtkpod/prefs.c                            |   19 ++--
plugins/playlist_display/display_playlists.c |   99 +++++++------------
2 files changed, 47 insertions(+), 71 deletions(-)


Best regards,
Jonathan Neuschäfer

[Gtkpod-devel] gtkpod-2.1.3 bug report

[David B. <dc...@ho...>]

Hello there,

I just got the GNU C compiler to say this

In function 'int sprintf(char*, const char*, ...)',
    inlined from 'char* APar_ExtractDataAtom(int)' at AtomicParsley.cpp:1833:97:
/usr/include/bits/stdio2.h:34:43: warning: call to int __builtin___sprintf_chk(char*, int, long unsigned int, const char*, ...) will always overflow destination buffer [enabled by default]
       __bos (__s), __fmt, __va_arg_pack ());
                                           ^

Source code is

                            char* result = (char*) malloc(sizeof(char) * 12);
                            sprintf(result, "Unknown (%u)\n", UInt32FromBigEndian(data_payload));

Suggest change 12 to 20 or 30.

Regards

David Binderman