#549 glibc-2.28 crashes gtk-gnutella build

[balducci]

hello

apologies if I'm missing something obviuos

1.1.14 build stops with:

----8<----
gcc -m64 -c -I../.. -I.. -pthread -I/opt/stow.d/versions/glib-2.58.1/usr/include -I/opt/stow.d/stow/libffi/usr/lib64/libffi-3.2.1/include -I/opt/stow.d/versions/glib-2.58.1/usr/include -I/opt/stow.d/versions/glib-2.58.1/usr/include/glib-2.0 -I/opt/stow.d/versions/glib-2.58.1/usr/lib64/glib-2.0/include -I/opt/stow.d/versions/pcre-8.42/usr/include -I/opt/stow.d/stow/dbus/usr/include/dbus-1.0 -I/opt/stow.d/stow/dbus/usr/lib64/dbus-1.0/include -DCURDIR=src/lib -O2 -g -pthread -pipe -momit-leaf-frame-pointer -W -Wall -Wformat=2 -Wshadow -I/usr/Xorg/include  stats.c
stats.c:53:8: error: redefinition of 'struct statx'
 struct statx {
        ^~~~~
In file included from /usr/include/sys/stat.h:446,
                 from ../common.h:108,
                 from stats.c:34:
/usr/include/bits/statx.h:36:8: note: originally defined here
 struct statx
        ^~~~~
---->8----

The problem seems to be a (n accidental?) clash of struct statx
defined in stats.c with glibc-2.28's struct statx defined in
/usr/include/bits/statx.h (which looks unrelated to gtk-gnutella's
struct statx).

AFAICS /usr/include/bits/statx.h has been introduced with glibc-2.28:
it isn't there for 2.24<=glibc<=2.27.

Fooling the build with an empty statx.h header allows it to complete
successfully.

cheers
gabriele

[Raphael Manfredi]

This is an unfortunate name clash that was not detected here locally nor by the Continuous Integration travis servers. I will fix it for the next release.

[Raphael Manfredi]

Closed by commit e4205a082eb32161e28de81f5cba8095eea8ecc7 on devel.