#14 Update UI, remove deprecated icon names

[newhoa]

Hi, I am not sure if this is the right way to submit changes, but I did some updates to the UI and wanted see if they could be used.

I began by just updating the UI widgets to replace deprecated ones (didn't see there was already a patch here till I finished). But I also replaced all the old gtk- icon names with icon names that use the freedesktop.org icon naming spec. Most icon themes don't include the gtk- icons anymore, so this should make grsync look a little nicer with more icon themes.

While updating the widgets, I did take a few UI changes a bit further and tried to make things hopefully a little easier to understand.

I moved Simulate/Run away from the add/remove session buttons and added text to clarify. Before it was a bit confusing as the icons were next to the session add/remove buttons which made them feel more like session controls. You also had to check the tooltips to see what they would do and not all icon themes made those actions clear without text (like + and - for add and remove are). So I tried to make them more obvious and in the order the user would use (From top to bottom: Select session, select session settings, execute).

I also moved the 'Source' and 'Destination' labels to the entry lines they are associated with which seems a little clearer and cleaner. It takes away about 5 characters of entry space, but the window is expandable and to me it's a lot clearer as to which entry is which.

Also, I read one of your notes from another patch and saw you wanted Notes to be multi-line so I did that.

Anyway, I'll include grsync.glade, src/callbacks.c, and a screenshot (left will be current, right proposed). After trying to add them, it looks like I can only add one attachment, so I'll add these three files in a tar.gz.

Let me know if this is of any use, and any guidance/criticisms would be appreciated. Thanks!

---

Grsync UI update

• Remove deprecated Gtk widgets
• Switch icon names from using gtk-* to instead use freedesktop.org icon spec names
• Make 'Source' and 'Destination' entry boxes easier to understand by moving text beside them
• Move 'execute' buttons (Simulate, Run/Sync, and Quit) to the bottom, use text in boxes
• Make Extra Options -> Notes multiline
• Adjust box orientation in Glade from horizontal to vertical for dialogs
• Adjust spacing within the tabs so widgets are aligned
• Fix issue where separators were expanding vertically
• Fix issue where sync dialog -> output window did not expand vertically
• Make dialog -> output window 'normal window' so it can be maximized by 'snapping' to screen edges in some window managers
• Add ellipsis to menu items that request user input after selection

---

[Piero Orsoni]

Hello,
Many thanks for your work! Much appreciated! The interface really needed some of those updates.
I will be checking the code ASAP.
Cheers!

[Jeff]

I would suggest taking the opportunity to remove the Quit button. There's no reason for that button to exist, it is redundant with the window manager's close (X) button, and standard keyboard shortcuts.

If the tall button on the right of the two Open buttons was meant to serve as a way to switch the two paths around, then it should remain a tall button that spans the height of the two rows, for clarity; the (?) help button could instead be moved to be into the GtkEntry of the source path (if its hint is specific to the source path in particular), maybe with gtk_entry_set_icon_from_icon_name and a Gtk Tooltip property (instead of requiring a dialog for itself, the info could be shown in a tooltip...). Heck, that info could be shown on a tooltip on the entry itself, not even requiring a click then, therefore no (?) button needed.