Menu

#12 Modernize glade file removing deprecated GtkTable and GtkAlignment

Unstable (example)
pending
nobody
None
5
2022-02-03
2021-12-31
genodeftest
No

Changes:

  • Replace deprecated GtkTable in preferences dialog by GtkGrid
  • Remove unnecessary GtkTable table6 from toolbar
  • Remove unnecessary GtkTables and GtkAlignment from main_window's tabs

Notes:

  • In tab "Extra options", the GtkEntry entry_notes for "Notes:" is single-line, which may be counter-intuitive.
  • In case a GtkLabel was meant to be the description for the next line's GtkEntry, I put both onto the same line.
  • Minor non-functional layout changes
1 Attachments

Discussion

  • Piero Orsoni

    Piero Orsoni - 2022-01-02
    • status: open --> pending
     
  • Piero Orsoni

    Piero Orsoni - 2022-01-02

    Thanks!

     
  • Piero Orsoni

    Piero Orsoni - 2022-01-04

    Tried it, works fine!

    Some notes:

    1. "notes" could indeed be a multi-line; I don't recall a reason why it's a one-liner, probably just my laziness :-)
    2. if you enlarge the window horizontally, only the left column is widened, so the options are no longer centered, is it on purpose? Not sure what's the correct behaviour according to the guidelines, but it looks nicer when centered, IMHO.
    3. I'm not sure about the two "before" and "after" commands being on the same line as the label, because the input is now much shorter, and the commands are less likely to fit in the box. Same for rsync executable on the preferences dialog: it may contain a full path and so be bigger than the input box.
     
  • Piero Orsoni

    Piero Orsoni - 2022-02-03

    Hello, could you please comment on my previous 3 points?
    Many thanks

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.