Menu

#11 Update glade file to Gtk3 and modernize it a bit

Unstable (example)
closed
None
5
2022-01-02
2021-12-29
genodeftest
No

Changes done to the attached file grsync.glade:
1. Convert to gtk3 3.22 using Glade 3.38.2
2. Convert GtkVBox to GtkBox with orientation=vertical
3. Convert GtkHSeparator to GtkSeparator (with orientation=horizontal, which is the default)
4. Convert GtkHBox to GtkBox (with orientation=horizontal, which is the default)
5. Replace GtkButton stock-id with the identical icon-name
6. In dialog_rsync, make the log expand vertically to fill all space when resizing the window

Note: I've chosen Gtk3 3.22 because it is the latest version that is still supported by all major oldstable distros such as Ubuntu 18.04 LTS, Debian 9. Older linux distros probably won't receive this update anyways.

PS: Would you be interested if I also replaced the deprecated tables in the glade file? I'd put that into a separate ticket though.

1 Attachments

Discussion

  • Piero Orsoni

    Piero Orsoni - 2021-12-30
    • status: open --> pending
    • assigned_to: Piero Orsoni
     
  • Piero Orsoni

    Piero Orsoni - 2021-12-30

    Many thanks for the patch! I will test it ASAP.
    Regarding the tables (and Gtk in general) I've not been updating anything except small fixes for years, as I don't work on glade any longer and just tweak the glade file manually on need; reason why your work is even more appreciated! :-)

     
  • Piero Orsoni

    Piero Orsoni - 2021-12-30

    Couple notes on this:
    I already fixed the vertical expand issue, but it's not in a release yet; in the future, to avoid working on older files, please base on the latest svn commit.
    There's a vertical spacing issue in the "extra options" tab, could you please look into it now that you are editing the file? :-)
    Many thanks!

     
  • Piero Orsoni

    Piero Orsoni - 2021-12-30

    added to svn r179

     
  • genodeftest

    genodeftest - 2021-12-31

    Thanks for your positive feedback and for maintaining grsync!

    Regarding the tables (and Gtk in general) I've not been updating
    anything except small fixes for years, as I don't work on glade any
    longer and just tweak the glade file manually on need; reason why your
    work is even more appreciated! :-)

    Thanks! I guess I will open a new "Patch" here if I find time to do so.

    I already fixed the vertical expand issue, but it's not in a release
    yet; in the future, to avoid working on older files, please base on the
    latest svn commit.

    Ok, nice and thanks for the hint!

    There's a vertical spacing issue in the "extra options" tab, could you
    please look into it now that you are editing the file? :-)

    Will do when replacing GtkTable with GtkGrid.

    Feel free to close this patch. It seems to be resolved from my side.

     
  • Piero Orsoni

    Piero Orsoni - 2022-01-02
    • status: pending --> closed
     
  • Piero Orsoni

    Piero Orsoni - 2022-01-02

    with thanks!

     

Log in to post a comment.