From: Vassilii K. <vas...@ta...> - 2013-07-28 08:49:39
|
On 27.07.2013 23:10, gra...@li... wrote: > I tried running RunAllTests.py in gramps40. It runs 8 tests which all fail. This is very interesting. I have just updated to today's gramps40, and, just as before, on my Linux raring virtual machine, running python RunAllTests.py in tests/ subdirectory, runs 4, not 8 tests, and only 1 of them fails (as detailed in the bug #6940). Note that, like I documented in the wiki, 2 of the NON-FAILING tests open up the error dialog, which is expected. You need to "cancel" it and the test will be marked as passed. Can you please summarize your running in a bug, while running it with "-v 3" switch? Please capture the terminal output produced, so we can see the exact list of tests that runs. Feel free to assign the bug to me right away. V. |
From: Vassilii K. <vas...@ta...> - 2013-07-28 08:56:45
|
On 27.07.2013 23:10, gra...@li... wrote: > Since python v2.7 the unittest module has the ability to discover unit > tests. We just need to ensure they conform to a standard naming > convention and are importable. So we may not even need the RunAllTests > script. > > It is easy to add a custom command to distutils. There is already a > "check" command which checks the meta-data, but a "test" command is a > good idea. > > Let me know if you want me to add it. > > Nick. Sounds like a good plan, let's just revive the unit tests first and separate the interactive ones, so that a fully automated run is possible. (I've added this to the wiki). V. |
From: Nick H. <nic...@ho...> - 2013-07-30 22:19:31
|
Vassilii, The unit tests should now work. You can run them from the top-level Gramps directory with: GRAMPS_RESOURCES=. python -m unittest <test module> for example: GRAMPS_RESOURCES=. python -m unittest gramps.gen.lib.test.date_test A full list of tests is available on the wiki: http://www.gramps-project.org/wiki/index.php?title=Testing_Gramps#unit_tests_in_the_main_tree To run all unit tests use: GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' You can get more output by adding the -v flag: GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' -v Some of the unit tests will work with python3, but not all of them. I couldn't find bindings for libxml2. Nick. On 28/07/13 09:56, Vassilii Khachaturov wrote: > On 27.07.2013 23:10, gra...@li... wrote: >> Since python v2.7 the unittest module has the ability to discover unit >> tests. We just need to ensure they conform to a standard naming >> convention and are importable. So we may not even need the RunAllTests >> script. >> >> It is easy to add a custom command to distutils. There is already a >> "check" command which checks the meta-data, but a "test" command is a >> good idea. >> >> Let me know if you want me to add it. >> >> Nick. > Sounds like a good plan, let's just revive the unit tests first and > separate the interactive ones, so that a fully automated run is possible. > (I've added this to the wiki). > > V. > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > > |
From: Vassilii K. <vas...@ta...> - 2013-07-31 05:51:59
|
Amazing, thank you very much!!! VKh On 31.07.2013 01:19, Nick Hall wrote: > Vassilii, > > The unit tests should now work. You can run them from the top-level > Gramps directory with: > > GRAMPS_RESOURCES=. python -m unittest <test module> > > for example: > > GRAMPS_RESOURCES=. python -m unittest gramps.gen.lib.test.date_test > > A full list of tests is available on the wiki: > > http://www.gramps-project.org/wiki/index.php?title=Testing_Gramps#unit_tests_in_the_main_tree > > To run all unit tests use: > > GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' > > You can get more output by adding the -v flag: > > GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' -v > > Some of the unit tests will work with python3, but not all of them. I > couldn't find bindings for libxml2. > > > Nick. > > > On 28/07/13 09:56, Vassilii Khachaturov wrote: >> On 27.07.2013 23:10, gra...@li... wrote: >>> Since python v2.7 the unittest module has the ability to discover unit >>> tests. We just need to ensure they conform to a standard naming >>> convention and are importable. So we may not even need the RunAllTests >>> script. >>> >>> It is easy to add a custom command to distutils. There is already a >>> "check" command which checks the meta-data, but a "test" command is a >>> good idea. >>> >>> Let me know if you want me to add it. >>> >>> Nick. >> Sounds like a good plan, let's just revive the unit tests first and >> separate the interactive ones, so that a fully automated run is possible. >> (I've added this to the wiki). >> >> V. >> |
From: Helge.Herz <Hel...@we...> - 2013-07-31 05:48:39
|
Nick, I tried the latest maintenance version from svn #22782 on Win: D: cd "D:\Gramps4.0nativPy2.7.3\test" C:\Python27\python RunAllTests.py "-v 3" having still this result: test_buffer_recall (ErrorReportAssistant_Test.ErrorReportAssistantTest) Test that simple recall of messages works. ... ERROR test_window (GtkHandler_Test.GtkHandlerTest) Test that the window appears. ... ok test_buffer_recall (RotateLogger_Test.RotateHandlerTest) Test that simple recall of messages works. ... ok test_buffer_rotation (RotateLogger_Test.RotateHandlerTest) Test that buffer correctly rolls over when capacity is reached. ... ok ====================================================================== ERROR: test_buffer_recall (ErrorReportAssistant_Test.ErrorReportAssistantTest) Test that simple recall of messages works. ---------------------------------------------------------------------- Traceback (most recent call last): File ".\GrampsLogger\ErrorReportAssistant_Test.py", line 60, in test_buffer_recall rotate_handler=rh) File "..\gramps\gui\logger\_errorreportassistant.py", line 81, in __init__ self.build_page1() File "..\gramps\gui\logger\_errorreportassistant.py", line 267, in build_page1 self._reset_error_details() File "..\gramps\gui\logger\_errorreportassistant.py", line 178, in _reset_error_details self._error_detail.get_record())) AttributeError: 'str' object has no attribute 'get_record' ---------------------------------------------------------------------- Ran 4 tests in 1.872s FAILED (errors=1) The message box appears. I choose CANCEL. What's to do? - Helge Am 31.07.2013 00:19, schrieb Nick Hall: > Vassilii, > > The unit tests should now work. You can run them from the top-level > Gramps directory with: > > GRAMPS_RESOURCES=. python -m unittest <test module> > > for example: > > GRAMPS_RESOURCES=. python -m unittest gramps.gen.lib.test.date_test > > A full list of tests is available on the wiki: > > http://www.gramps-project.org/wiki/index.php?title=Testing_Gramps#unit_tests_in_the_main_tree > > To run all unit tests use: > > GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' > > You can get more output by adding the -v flag: > > GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' -v > > Some of the unit tests will work with python3, but not all of them. I > couldn't find bindings for libxml2. > > > Nick. > > > On 28/07/13 09:56, Vassilii Khachaturov wrote: >> On 27.07.2013 23:10, gra...@li... wrote: >>> Since python v2.7 the unittest module has the ability to discover unit >>> tests. We just need to ensure they conform to a standard naming >>> convention and are importable. So we may not even need the RunAllTests >>> script. >>> >>> It is easy to add a custom command to distutils. There is already a >>> "check" command which checks the meta-data, but a "test" command is a >>> good idea. >>> >>> Let me know if you want me to add it. >>> >>> Nick. >> Sounds like a good plan, let's just revive the unit tests first and >> separate the interactive ones, so that a fully automated run is possible. >> (I've added this to the wiki). >> >> V. >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> Gramps-devel mailing list >> Gra...@li... >> https://lists.sourceforge.net/lists/listinfo/gramps-devel >> >> > > ------------------------------------------------------------------------------ > Get your SQL database under version control now! > Version control is standard for application code, but databases havent > caught up. So what steps can you take to put your SQL databases under > version control? Why should you start doing it? Read more to find out. > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel |
From: Vassilii K. <vas...@ta...> - 2013-07-31 05:54:08
|
This is known as bug #6940. On 31.07.2013 08:48, Helge.Herz wrote: > Nick, > > I tried the latest maintenance version from svn #22782 on Win: > > D: > cd "D:\Gramps4.0nativPy2.7.3\test" > C:\Python27\python RunAllTests.py "-v 3" > > having still this result: > > test_buffer_recall > (ErrorReportAssistant_Test.ErrorReportAssistantTest) > Test that simple recall of messages works. ... ERROR > test_window (GtkHandler_Test.GtkHandlerTest) > Test that the window appears. ... ok > test_buffer_recall (RotateLogger_Test.RotateHandlerTest) > Test that simple recall of messages works. ... ok > test_buffer_rotation (RotateLogger_Test.RotateHandlerTest) > Test that buffer correctly rolls over when capacity is reached. ... ok > > ====================================================================== > ERROR: test_buffer_recall > (ErrorReportAssistant_Test.ErrorReportAssistantTest) > Test that simple recall of messages works. > ---------------------------------------------------------------------- > Traceback (most recent call last): > File ".\GrampsLogger\ErrorReportAssistant_Test.py", line 60, in > test_buffer_recall > rotate_handler=rh) > File "..\gramps\gui\logger\_errorreportassistant.py", line 81, > in __init__ > self.build_page1() > File "..\gramps\gui\logger\_errorreportassistant.py", line 267, > in build_page1 > > self._reset_error_details() > File "..\gramps\gui\logger\_errorreportassistant.py", line 178, > in _reset_error_details > self._error_detail.get_record())) > AttributeError: 'str' object has no attribute 'get_record' > > ---------------------------------------------------------------------- > Ran 4 tests in 1.872s > > FAILED (errors=1) > > The message box appears. I choose CANCEL. > What's to do? > > - Helge > Am 31.07.2013 00:19, schrieb Nick Hall: >> Vassilii, >> >> The unit tests should now work. You can run them from the top-level >> Gramps directory with: >> >> GRAMPS_RESOURCES=. python -m unittest <test module> >> >> for example: >> >> GRAMPS_RESOURCES=. python -m unittest gramps.gen.lib.test.date_test >> >> A full list of tests is available on the wiki: >> >> http://www.gramps-project.org/wiki/index.php?title=Testing_Gramps#unit_tests_in_the_main_tree >> >> To run all unit tests use: >> >> GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' >> >> You can get more output by adding the -v flag: >> >> GRAMPS_RESOURCES=. python -m unittest discover -p '*_test.py' -v >> >> Some of the unit tests will work with python3, but not all of them. I >> couldn't find bindings for libxml2. >> >> >> Nick. >> >> >> On 28/07/13 09:56, Vassilii Khachaturov wrote: >>> On 27.07.2013 23:10,gra...@li... wrote: >>>> Since python v2.7 the unittest module has the ability to discover unit >>>> tests. We just need to ensure they conform to a standard naming >>>> convention and are importable. So we may not even need the RunAllTests >>>> script. >>>> >>>> It is easy to add a custom command to distutils. There is already a >>>> "check" command which checks the meta-data, but a "test" command is a >>>> good idea. >>>> >>>> Let me know if you want me to add it. >>>> >>>> Nick. >>> Sounds like a good plan, let's just revive the unit tests first and >>> separate the interactive ones, so that a fully automated run is possible. >>> (I've added this to the wiki). >>> >>> V. >>> >>> ------------------------------------------------------------------------------ >>> See everything from the browser to the database with AppDynamics >>> Get end-to-end visibility with application monitoring from AppDynamics >>> Isolate bottlenecks and diagnose root cause in seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> Gramps-devel mailing list >>> Gra...@li... >>> https://lists.sourceforge.net/lists/listinfo/gramps-devel >>> >>> >> ------------------------------------------------------------------------------ >> Get your SQL database under version control now! >> Version control is standard for application code, but databases havent >> caught up. So what steps can you take to put your SQL databases under >> version control? Why should you start doing it? Read more to find out. >> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk >> _______________________________________________ >> Gramps-devel mailing list >> Gra...@li... >> https://lists.sourceforge.net/lists/listinfo/gramps-devel > > > > ------------------------------------------------------------------------------ > Get your SQL database under version control now! > Version control is standard for application code, but databases havent > caught up. So what steps can you take to put your SQL databases under > version control? Why should you start doing it? Read more to find out. > http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk > > > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel |
From: Nick H. <nic...@ho...> - 2013-07-31 13:23:50
|
Helge, The in-tree unit tests use the unittest module discover functionality. Use the commands I suggested rather than the RunAllTests script. Nick. On 31/07/13 06:48, Helge.Herz wrote: > Nick, > > I tried the latest maintenance version from svn #22782 on Win: > > D: > cd "D:\Gramps4.0nativPy2.7.3\test" > C:\Python27\python RunAllTests.py "-v 3" > > having still this result: > > test_buffer_recall > (ErrorReportAssistant_Test.ErrorReportAssistantTest) > Test that simple recall of messages works. ... ERROR > test_window (GtkHandler_Test.GtkHandlerTest) > Test that the window appears. ... ok > test_buffer_recall (RotateLogger_Test.RotateHandlerTest) > Test that simple recall of messages works. ... ok > test_buffer_rotation (RotateLogger_Test.RotateHandlerTest) > Test that buffer correctly rolls over when capacity is reached. ... ok > |
From: Nick H. <nic...@ho...> - 2013-07-29 17:11:30
|
Vassilii, There was a small bug in the RunAllTests script, that made it only run the tests in the last directory visited. I was running the database cursor and reference map tests only. You were just running the error handler tests. I have updated the database cursor and reference map tests and moved them into the main tree. We could do the same for the non-interactive tests error handler tests. The only error I get now already has a bug report (#6940). Nick. On 28/07/13 09:49, Vassilii Khachaturov wrote: > On 27.07.2013 23:10, gra...@li... wrote: >> I tried running RunAllTests.py in gramps40. It runs 8 tests which all fail. > This is very interesting. I have just updated to today's gramps40, and, > just as before, > on my Linux raring virtual machine, running > python RunAllTests.py > in tests/ subdirectory, runs 4, not 8 tests, and only 1 of them fails > (as detailed in the bug #6940). > > Note that, like I documented in the wiki, 2 of the NON-FAILING tests > open up the error dialog, which is expected. You need to "cancel" it and > the test will be marked as passed. > > Can you please summarize your running in a bug, while running it with > "-v 3" switch? Please capture the terminal output produced, so we can > see the exact list of tests that runs. > Feel free to assign the bug to me right away. > > V. > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > > |