From: Peter L. <pet...@te...> - 2011-05-28 20:26:41
|
Hi Windows people, I have been trying to fix spell checking for Swedish (or any other language) in Gramps 3.3. I started with Gramps 3.2.6 and got that OK. See: http://www.gramps-project.org/bugs/view.php?id=3866 I must add sv_SE.aff and se_SE.dic from the Open Office spell catalog (C:\Program\OpenOffice.org 3\share\uno_packages\cache\uno_packages\32.tmp_\dict-sv.oxt\) to: C:\Python26\Lib\site-packages\enchant\share\enchant\myspell> in order to get Swedish spelling working. Note: 1. enchant must be installed 2. Aspell is NOT installed. Now I have spell checking working in both 3.2.6 and 3.3.0 for Windows XP. Remains to test in Windows 7. Note. In 3.3.0 I had to fix Spell.py Index: Spell.py =================================================================== --- Spell.py (revision 17588) +++ Spell.py (arbetskopia) @@ -34,7 +34,7 @@ #------------------------------------------------------------------------- from gen.ggettext import gettext as _ import locale - +import constfunc #------------------------------------------------------------------------- # # Set up logging @@ -51,6 +51,8 @@ import gtk try: + if constfunc.win(): + import enchant import gtkspell HAVE_GTKSPELL = True except ImportError: ============================================================================ This is one way of fixing spell checking in Windows XP. There might be other ways. /Peter |
From: Josip <jo...@pi...> - 2011-05-28 22:34:46
|
On 28.05.2011 22:31, Peter Landgren wrote: > Hi Windows people, > > I have been trying to fix spell checking for Swedish (or any other language) in Gramps 3.3. > I started with Gramps 3.2.6 and got that OK. > See: http://www.gramps-project.org/bugs/view.php?id=3866 > > I must add sv_SE.aff and se_SE.dic from the Open Office spell catalog > (C:\Program\OpenOffice.org 3\share\uno_packages\cache\uno_packages\32.tmp_\dict-sv.oxt\) to: > C:\Python26\Lib\site-packages\enchant\share\enchant\myspell> > in order to get Swedish spelling working. > You need dictionary for yours language if you wont spell-check to work. It is explained on wiki. > Note: > 1. enchant must be installed > 2. Aspell is NOT installed. > OpenOffice uses myspell so aspell is not needed (although it can be used if you like to use aspell dicts) > Now I have spell checking working in both 3.2.6 and 3.3.0 for Windows XP. > Remains to test in Windows 7. > > Note. In 3.3.0 I had to fix Spell.py > > Index: Spell.py > =================================================================== > --- Spell.py (revision 17588) > +++ Spell.py (arbetskopia) > @@ -34,7 +34,7 @@ > #------------------------------------------------------------------------- > from gen.ggettext import gettext as _ > import locale > - > +import constfunc > #------------------------------------------------------------------------- > # > # Set up logging > @@ -51,6 +51,8 @@ > import gtk > > try: > + if constfunc.win(): > + import enchant > import gtkspell > HAVE_GTKSPELL = True > except ImportError: > > ============================================================================ > This is one way of fixing spell checking in Windows XP. > There might be other ways. > The recent version i try is 3.3.0beta in which spellcheck work fine. Now i see some mention of removing enchant in localisation patch so i wonder why is that done. GtkSpell (so PyGtKSpell also) is dependant of Enchant library, so it must be PyEnchant they mention (as your code show) but it is just small pure python (ctypes) extension module so what is problem in keeping it included. PyEnchant allow as in the past to fix problem with broken dicts engines (hebrew and turkish ones) as gtkspell does not expose any functions to deal with them. It is also been suggested to replace (py)gtkspell with pyenchant entirely. -- Josip |
From: Peter L. <pet...@te...> - 2011-05-29 09:34:30
|
Just a few comments below. > On 28.05.2011 22:31, Peter Landgren wrote: > > Hi Windows people, > > > > I have been trying to fix spell checking for Swedish (or any other > > language) in Gramps 3.3. I started with Gramps 3.2.6 and got that OK. > > See: http://www.gramps-project.org/bugs/view.php?id=3866 > > > > I must add sv_SE.aff and se_SE.dic from the Open Office spell catalog > > (C:\Program\OpenOffice.org > > 3\share\uno_packages\cache\uno_packages\32.tmp_\dict-sv.oxt\) to: > > C:\Python26\Lib\site-packages\enchant\share\enchant\myspell> > > in order to get Swedish spelling working. > > You need dictionary for yours language if you wont spell-check to work. > It is explained on wiki. Yes, I know, but the link to the Swedish dictionary ends in a non existent page. > > Note: > > 1. enchant must be installed > > 2. Aspell is NOT installed. > > OpenOffice uses myspell so aspell is not needed (although it can be used > if you like to use aspell dicts) Someone suggested to install Aspell and the corresponding dictionaries, but it didn't help me. > > Now I have spell checking working in both 3.2.6 and 3.3.0 for Windows XP. > > Remains to test in Windows 7. > > > > Note. In 3.3.0 I had to fix Spell.py > > > > Index: Spell.py > > =================================================================== > > --- Spell.py (revision 17588) > > +++ Spell.py (arbetskopia) > > @@ -34,7 +34,7 @@ > > > > #---------------------------------------------------------------------- > > --- from gen.ggettext import gettext as _ > > import locale > > > > - > > +import constfunc > > > > #---------------------------------------------------------------------- > > --- # > > # Set up logging > > > > @@ -51,6 +51,8 @@ > > > > import gtk > > > > try: > > + if constfunc.win(): > > + import enchant > > > > import gtkspell > > HAVE_GTKSPELL = True > > > > except ImportError: > > ========================================================================= > > === This is one way of fixing spell checking in Windows XP. > > There might be other ways. > > The recent version i try is 3.3.0beta in which spellcheck work fine. Yes, correct, but beta uses the "old" Spell.py. I was using the SVN-version with the "new" Spell.py, where enchant is not used/imported, which works well in Linux. > Now i see some mention of removing enchant in localisation patch so i > wonder why is that done. > GtkSpell (so PyGtKSpell also) is dependant of Enchant library, so it > must be PyEnchant they mention (as your code show) but it is just small > pure python (ctypes) extension module so what is problem in keeping it > included. > > PyEnchant allow as in the past to fix problem with broken dicts engines > (hebrew and turkish ones) as gtkspell does not expose any functions to > deal with them. It is also been suggested to replace (py)gtkspell with > pyenchant entirely. /Peter |
From: Benny M. <ben...@gm...> - 2011-05-29 11:02:14
|
2011/5/29 Josip <jo...@pi...> > On 28.05.2011 22:31, Peter Landgren wrote: > > Hi Windows people, > > > > I have been trying to fix spell checking for Swedish (or any other > language) in Gramps 3.3. > > I started with Gramps 3.2.6 and got that OK. > > See: http://www.gramps-project.org/bugs/view.php?id=3866 > > > > I must add sv_SE.aff and se_SE.dic from the Open Office spell catalog > > (C:\Program\OpenOffice.org > 3\share\uno_packages\cache\uno_packages\32.tmp_\dict-sv.oxt\) to: > > C:\Python26\Lib\site-packages\enchant\share\enchant\myspell> > > in order to get Swedish spelling working. > > > > You need dictionary for yours language if you wont spell-check to work. > It is explained on wiki. > > > Note: > > 1. enchant must be installed > > 2. Aspell is NOT installed. > > > > OpenOffice uses myspell so aspell is not needed (although it can be used > if you like to use aspell dicts) > > > > Now I have spell checking working in both 3.2.6 and 3.3.0 for Windows XP. > > Remains to test in Windows 7. > > > > Note. In 3.3.0 I had to fix Spell.py > > > > Index: Spell.py > > =================================================================== > > --- Spell.py (revision 17588) > > +++ Spell.py (arbetskopia) > > @@ -34,7 +34,7 @@ > > > #------------------------------------------------------------------------- > > from gen.ggettext import gettext as _ > > import locale > > - > > +import constfunc > > > #------------------------------------------------------------------------- > > # > > # Set up logging > > @@ -51,6 +51,8 @@ > > import gtk > > > > try: > > + if constfunc.win(): > > + import enchant > > import gtkspell > > HAVE_GTKSPELL = True > > except ImportError: > > > > > ============================================================================ > > This is one way of fixing spell checking in Windows XP. > > There might be other ways. > > > > The recent version i try is 3.3.0beta in which spellcheck work fine. > > Now i see some mention of removing enchant in localisation patch so i > wonder why is that done. > GtkSpell (so PyGtKSpell also) is dependant of Enchant library, so it > must be PyEnchant they mention (as your code show) but it is just small > pure python (ctypes) extension module so what is problem in keeping it > included. > > PyEnchant allow as in the past to fix problem with broken dicts engines > (hebrew and turkish ones) as gtkspell does not expose any functions to > deal with them. It is also been suggested to replace (py)gtkspell with > pyenchant entirely. > We used pyenchant only to build a list of installed languages, but gramps spellcheck has always been 100% using gtkspell. I looked into replacing gtkspell with the pyenchant, and it would be less usable if we don't implement it by ourselves as gtkspell. (no red wiggle underline but instead you need to use a toolbar button which then lists words with problems) We received a patch so as not to need python-enchant anymore for the list of languages. It works in ubuntu 10.04 -11-04 and Mac, so the old Turkish bug is gone at least a year. If we still need python-enchant for windows, it should come from the windows developers as a patch checking against windows to import it. Benny > > -- > Josip > > > ------------------------------------------------------------------------------ > vRanger cuts backup time in half-while increasing security. > With the market-leading solution for virtual backup and recovery, > you get blazing-fast, flexible, and affordable data protection. > Download your free trial now. > http://p.sf.net/sfu/quest-d2dcopy1 > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |
From: Peter L. <pet...@te...> - 2011-05-29 11:20:38
|
Den Sunday 29 May 2011 13.02.04 skrev Benny Malengier: > 2011/5/29 Josip <jo...@pi...> > > > On 28.05.2011 22:31, Peter Landgren wrote: > > > Hi Windows people, > > > > > > I have been trying to fix spell checking for Swedish (or any other > > > > language) in Gramps 3.3. > > > > > I started with Gramps 3.2.6 and got that OK. > > > See: http://www.gramps-project.org/bugs/view.php?id=3866 > > > > > > I must add sv_SE.aff and se_SE.dic from the Open Office spell catalog > > > (C:\Program\OpenOffice.org > > > > 3\share\uno_packages\cache\uno_packages\32.tmp_\dict-sv.oxt\) to: > > > C:\Python26\Lib\site-packages\enchant\share\enchant\myspell> > > > in order to get Swedish spelling working. > > > > You need dictionary for yours language if you wont spell-check to work. > > It is explained on wiki. > > > > > Note: > > > 1. enchant must be installed > > > 2. Aspell is NOT installed. > > > > OpenOffice uses myspell so aspell is not needed (although it can be used > > if you like to use aspell dicts) > > > > > Now I have spell checking working in both 3.2.6 and 3.3.0 for Windows > > > XP. Remains to test in Windows 7. > > > > > > Note. In 3.3.0 I had to fix Spell.py > > > > > > Index: Spell.py > > > =================================================================== > > > --- Spell.py (revision 17588) > > > +++ Spell.py (arbetskopia) > > > @@ -34,7 +34,7 @@ > > > > #------------------------------------------------------------------------ > > - > > > > > from gen.ggettext import gettext as _ > > > import locale > > > > > > - > > > +import constfunc > > > > #------------------------------------------------------------------------ > > - > > > > > # > > > # Set up logging > > > > > > @@ -51,6 +51,8 @@ > > > > > > import gtk > > > > > > try: > > > + if constfunc.win(): > > > + import enchant > > > > > > import gtkspell > > > HAVE_GTKSPELL = True > > > > > > except ImportError: > > ========================================================================= > > === > > > > > This is one way of fixing spell checking in Windows XP. > > > There might be other ways. > > > > The recent version i try is 3.3.0beta in which spellcheck work fine. > > > > Now i see some mention of removing enchant in localisation patch so i > > wonder why is that done. > > GtkSpell (so PyGtKSpell also) is dependant of Enchant library, so it > > must be PyEnchant they mention (as your code show) but it is just small > > pure python (ctypes) extension module so what is problem in keeping it > > included. > > > > PyEnchant allow as in the past to fix problem with broken dicts engines > > (hebrew and turkish ones) as gtkspell does not expose any functions to > > deal with them. It is also been suggested to replace (py)gtkspell with > > pyenchant entirely. > > We used pyenchant only to build a list of installed languages, but gramps > spellcheck has always been 100% using gtkspell. > I looked into replacing gtkspell with the pyenchant, and it would be less > usable if we don't implement it by ourselves as gtkspell. (no red wiggle > underline but instead you need to use a toolbar button which then lists > words with problems) > > We received a patch so as not to need python-enchant anymore for the list > of languages. It works in ubuntu 10.04 -11-04 and Mac, so the old Turkish > bug is gone at least a year. > If we still need python-enchant for windows, it should come from the > windows developers as a patch checking against windows to import it. > > Benny I hade a look at what happens in "import enchant". The first thing it does, for Windows only, is to "# Add our bundled enchant libraries to DLL search path" /Peter > > -- > > Josip > > > > > > ------------------------------------------------------------------------- > > ----- vRanger cuts backup time in half-while increasing security. > > With the market-leading solution for virtual backup and recovery, > > you get blazing-fast, flexible, and affordable data protection. > > Download your free trial now. > > http://p.sf.net/sfu/quest-d2dcopy1 > > _______________________________________________ > > Gramps-devel mailing list > > Gra...@li... > > https://lists.sourceforge.net/lists/listinfo/gramps-devel |
From: Benny M. <ben...@gm...> - 2011-05-29 14:40:17
|
2011/5/29 Peter Landgren <pet...@te...> > I hade a look at what happens in "import enchant". > The first thing it does, for Windows only, is to > "# Add our bundled enchant libraries to DLL search path" > > Ok, so add the import enchant to Spell.py for windows systems, and add to the README under dependencies that python-enchant is required under Windows. Benny |
From: Peter L. <pet...@te...> - 2011-05-29 14:51:03
|
Den Sunday 29 May 2011 16.40.10 skrev Benny Malengier: > 2011/5/29 Peter Landgren <pet...@te...> > > > I hade a look at what happens in "import enchant". > > The first thing it does, for Windows only, is to > > "# Add our bundled enchant libraries to DLL search path" > > Ok, so add the import enchant to Spell.py for windows systems, and add to > the README under dependencies that python-enchant is required under > Windows. > > Benny OK, but I must have it working in Windows 7 too. For the moment it does not. I get the same errormsg as earlier. It seems to me that enchant can't find the dictionaries. I have the same structure of enchant as in Win XP, but obviously something differ. It seems that Josip has a working solution without enchant. /Peter |
From: Josip <jo...@pi...> - 2011-05-29 14:53:37
|
On 29.05.2011 16:40, Benny Malengier wrote: > > > 2011/5/29 Peter Landgren <pet...@te... > <mailto:pet...@te...>> > > I hade a look at what happens in "import enchant". > The first thing it does, for Windows only, is to > "# Add our bundled enchant libraries to DLL search path" > > > Ok, so add the import enchant to Spell.py for windows systems, and add > to the README under dependencies that python-enchant is required under > Windows. > This probably come from author's "PyEnchant bundled version for Windows" which includes not only ctypes bindings for enchant but also enchant.dll, various enchant-providers.dll, all their dependencies and place to put dicts in. But that bundle is not needed any more, just enchant library and at least dict for locale under which is run. -- Josip |
From: Peter L. <pet...@te...> - 2011-05-31 06:40:38
|
Den Sunday 29 May 2011 16.40.10 skrev Benny Malengier: > 2011/5/29 Peter Landgren <pet...@te...> > > > I hade a look at what happens in "import enchant". > > The first thing it does, for Windows only, is to > > "# Add our bundled enchant libraries to DLL search path" > > Ok, so add the import enchant to Spell.py for windows systems, and add to > the README under dependencies that python-enchant is required under > Windows. > > Benny Now I have it working under Windows 7 too. (I had a PATH that pointed to something wrong.) Will commit Spell.py and edit the Wiki. /Peter |
From: Josip <jo...@pi...> - 2011-05-29 14:45:45
|
On 29.05.2011 13:02, Benny Malengier wrote: > > > We used pyenchant only to build a list of installed languages, but > gramps spellcheck has always been 100% using gtkspell. > I looked into replacing gtkspell with the pyenchant, and it would be > less usable if we don't implement it by ourselves as gtkspell. (no red > wiggle underline but instead you need to use a toolbar button which then > lists words with problems) > > We received a patch so as not to need python-enchant anymore for the > list of languages. It works in ubuntu 10.04 -11-04 and Mac, so the old > Turkish bug is gone at least a year. > If we still need python-enchant for windows, it should come from the > windows developers as a patch checking against windows to import it. > No we do not need python-enchant for windows only as it works fine without him. Tested with gramps-3.3.0-0.SVN17614M and all is fine, shows "Spellcheck: On/Off" and "Languages" with form ll_LL (kinda like more previous version where languages is listed in full names like "English, French etc) -- Josip |
From: Peter L. <pet...@te...> - 2011-05-29 14:50:19
|
Den Sunday 29 May 2011 16.44.45 skrev Josip: > On 29.05.2011 13:02, Benny Malengier wrote: > > We used pyenchant only to build a list of installed languages, but > > gramps spellcheck has always been 100% using gtkspell. > > I looked into replacing gtkspell with the pyenchant, and it would be > > less usable if we don't implement it by ourselves as gtkspell. (no red > > wiggle underline but instead you need to use a toolbar button which then > > lists words with problems) > > > > We received a patch so as not to need python-enchant anymore for the > > list of languages. It works in ubuntu 10.04 -11-04 and Mac, so the old > > Turkish bug is gone at least a year. > > If we still need python-enchant for windows, it should come from the > > windows developers as a patch checking against windows to import it. > > No we do not need python-enchant for windows only as it works fine > without him. > Tested with gramps-3.3.0-0.SVN17614M and all is fine, shows "Spellcheck: > On/Off" and "Languages" with form ll_LL (kinda like more previous > version where languages is listed in full names like "English, French etc) I wonder what error I make, but cant get it working. What spell checker have you installed? /Peter |
From: Josip <jo...@pi...> - 2011-05-29 15:02:32
|
On 29.05.2011 16:54, Peter Landgren wrote: > > I wonder what error I make, but cant get it working. > What spell checker have you installed? > Don't know! If you have 64bit Windows try "GrampsAIO64-3.3.0_beta-1.exe" from https://rapidshare.com/users/K65PY0/ to see what libs is needed and in what order (it includes Swedish dict also) From that enviroment (from AIO bin folder) try to run svn code like: python -E YOUR_SVN_PATH/gramps33/src/gramps.py -- Josip |
From: Tim L. <guy...@gm...> - 2011-05-29 16:01:39
|
Just to add the comment I have made in bug 3866: When I build gtkspell (actually gtkspell2) on Mac OS X under Macports, it first builds enchant, because gtkspell depends on enchant. But I don't need the python binding to enchant, and I certainly don't need to import the python binding from Spell.py. So you might well need the enchant.dll library. If the python binding is adding the library to the dll search path, then perhaps you need to manually add the enchant.dll to the search path, or put it somewhere where it is found. -- View this message in context: http://gramps.1791082.n4.nabble.com/Spell-checking-in-Windows-for-Gramps-3-3-and-3-2-6-tp3558025p3559114.html Sent from the GRAMPS - Dev mailing list archive at Nabble.com. |