From: Adam S. <ad...@sc...> - 2004-05-17 17:48:03
|
This is in Gramps v1.0.3. Before I had a problem trying to find the source references I gave to some gallery images. I think I pinned it down. You can add attributes. I added the source reference to an added attribute. When saved, the XML is incorrect, leading to the source reference not being accessed in Gramps. In fact, below is what appears to be valid Gramps XML with an added attribute with the source reference layed out the way I think it's suppose to be and Gramps doesn't see it. Must be how Gramps deals with added attributes. When the XML data is read in and saved again, the source reference will now be in the wrong place. These new attributes aren't saved, so everytime I start Gramps and add the attribute to a new media object, it's new to Gramps all over again. An enhancement request would be to save new attributes between sessions. This would be useful since they would appear on the menus instead of me having to add it each time. ----XML-Sample----XML-Sample----XML-Sample----XML-Sample----XML-Sample---- <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE database SYSTEM "gramps.dtd" []> <database xmlns="http://gramps.sourceforge.net/database"> <header> <created date="17 MAY 2004" version="1.0.3-1" people="1" families="0" sources="1" places="0"/> <researcher> <resname>Adam Stein</resname> <resaddr>xxx</resaddr> <rescity>xxx</rescity> <resstate>xxx</resstate> <rescountry>xxx</rescountry> <respostal>xxx</respostal> <resphone>xxx</resphone> <resemail>ad...@sc...</resemail> </researcher> </header> <people> <person id="I0"> <gender>M</gender> <name type="Birth Name"> <first>Adam</first> <last>Stein</last> </name> </person> </people> <sources> <source id="S0"> <stitle>Made Up Reference</stitle> <sauthor>Adam Stein</sauthor> </source> </sources> <objects> <object id="O1" src="O1.jpg" mime="image/jpeg" description="O0"> <attribute type="Ship" value="Added the 'Ship' attribute"> <sourceref ref="S0"> <spage>No particular page number</spage> </sourceref> </attribute> </object> </objects> </database> ----XML-Sample----XML-Sample----XML-Sample----XML-Sample----XML-Sample---- Adam -- Adam Stein @ Xerox Corporation Email: ad...@sc... Disclaimer: All views expressed here have been proved to be my own. [http://www.csh.rit.edu/~adam/] |
From: Alex R. <sh...@al...> - 2004-05-17 18:09:52
|
Adam, Great that you nailed it down! I'll take a look at this tonight. Alex On Mon, 2004-05-17 at 12:45, Adam Stein wrote: > This is in Gramps v1.0.3. >=20 > Before I had a problem trying to find the source references I gave to som= e=20 > gallery images. I think I pinned it down. You can add attributes. I ad= ded the=20 > source reference to an added attribute. When saved, the XML is incorrect= ,=20 > leading to the source reference not being accessed in Gramps. In fact, b= elow is=20 > what appears to be valid Gramps XML with an added attribute with the sour= ce=20 > reference layed out the way I think it's suppose to be and Gramps doesn't= see=20 > it. Must be how Gramps deals with added attributes. When the XML data i= s read=20 > in and saved again, the source reference will now be in the wrong place. >=20 > These new attributes aren't saved, so everytime I start Gramps and add th= e=20 > attribute to a new media object, it's new to Gramps all over again. An=20 > enhancement request would be to save new attributes between sessions. Th= is=20 > would be useful since they would appear on the menus instead of me having= to add=20 > it each time. >=20 > ----XML-Sample----XML-Sample----XML-Sample----XML-Sample----XML-Sample---= - > <?xml version=3D"1.0" encoding=3D"UTF-8"?> > <!DOCTYPE database SYSTEM "gramps.dtd" []> > <database xmlns=3D"http://gramps.sourceforge.net/database"> > <header> > <created date=3D"17 MAY 2004" version=3D"1.0.3-1" people=3D"1" famili= es=3D"0"=20 > sources=3D"1" places=3D"0"/> > <researcher> > <resname>Adam Stein</resname> > <resaddr>xxx</resaddr> > <rescity>xxx</rescity> > <resstate>xxx</resstate> > <rescountry>xxx</rescountry> > <respostal>xxx</respostal> > <resphone>xxx</resphone> > <resemail>ad...@sc...</resemail> > </researcher> > </header> > <people> > <person id=3D"I0"> > <gender>M</gender> > <name type=3D"Birth Name"> > <first>Adam</first> > <last>Stein</last> > </name> > </person> > </people> > <sources> > <source id=3D"S0"> > <stitle>Made Up Reference</stitle> > <sauthor>Adam Stein</sauthor> > </source> > </sources> > <objects> > <object id=3D"O1" src=3D"O1.jpg" mime=3D"image/jpeg" description=3D"O= 0"> > <attribute type=3D"Ship" value=3D"Added the 'Ship' attribute"> > <sourceref ref=3D"S0"> > <spage>No particular page number</spage> > </sourceref> > </attribute> > </object> > </objects> > </database> >=20 > ----XML-Sample----XML-Sample----XML-Sample----XML-Sample----XML-Sample---= - --=20 Alexander Roitman http://ebner.neuroscience.umn.edu/people/alex.html Dept. of Neuroscience, Lions Research Building 2001 6th Street SE, Minneapolis, MN 55455 Tel (612) 625-7566 FAX (612) 626-9201 |
From: Alex R. <sh...@al...> - 2004-05-18 02:54:53
Attachments:
GrampsParser.py
|
Adam, This thing should be fixed in STABLE branch of CVS now. Just in case, I am also attaching the src/GrampsParser.py file. Let me know if this works for you. Beware that you may have to manually repair your XML before trying it :-) The issue was in parsing XML, not saving it. The initial save was fine, but on subsequent reads it failed to add a source reference to the attribute, mistakenly adding it to the parent media object. As a result, the subsequent saves were promptly saving it as a media object's source reference, not the attribute's. Now, the next thing is that it probably makes sense to enable sources for media objects as well. It seems it the're not enabled by a pure oversight. So, as time permits, we'll add a new Source tab to the property editor for media objects. Thanks again for pinpointing this, Alex On Mon, May 17, 2004 at 01:45:36PM -0400, Adam Stein wrote: > This is in Gramps v1.0.3. > > Before I had a problem trying to find the source references I gave to some > gallery images. I think I pinned it down. [snip] -- Alexander Roitman http://ebner.neuroscience.umn.edu/people/alex.html Dept. of Neuroscience, Lions Research Building 2001 6th Street SE, Minneapolis, MN 55455 Tel (612) 625-7566 FAX (612) 626-9201 |
From: Alex R. <sh...@al...> - 2004-05-19 02:48:48
|
Adam, On Mon, May 17, 2004 at 09:54:48PM -0500, Alex Roitman wrote: >=20 > Now, the next thing is that it probably makes sense to enable sources for= =20 > media objects as well. It seems it the're not enabled by a pure oversight= =2E=20 > So, as time permits, we'll add a new Source tab to the property > editor for media objects.=20 Time permitted today :-), so now both media objects (Media View) and references to them (individual and family galleries) should allow adding the source references, and properly save and parse them.=20 The changes are in CVS and should appear in the stable snapshot tomorrow: http://gramps.sf.net/gramps-stable-snapshot.tar.gz If you could (cautiously!) test it and let me know how it is working for you I would greatly appreciate it. Among possible worries is the fact that I have glade2.6, and it is not unthinkable that it could save something that will make earlier libglade hick-up.=20 The saving/parsing part seems to be solid on my end, so if everything is working for you we will include that in the next stable release. Alex -- Alexander Roitman http://ebner.neuroscience.umn.edu/people/alex.html Dept. of Neuroscience, Lions Research Building 2001 6th Street SE, Minneapolis, MN 55455 Tel (612) 625-7566 FAX (612) 626-9201 |
From: Alex R. <sh...@al...> - 2004-05-18 03:04:48
|
Adam, On Mon, May 17, 2004 at 01:45:36PM -0400, Adam Stein wrote: >[snip]=20 > These new attributes aren't saved, so everytime I start Gramps and add th= e=20 > attribute to a new media object, it's new to Gramps all over again. An= =20 > enhancement request would be to save new attributes between sessions. Th= is=20 > would be useful since they would appear on the menus instead of me having= to add=20 > it each time. This makes great sense. I added an RFE item to our tracker at sf.net, you can monitor/post feedback here: http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D955591&group_i= d=3D25770&atid=3D385140 When time permits, we should get it done. I'm thinking of adding an XML file to ~/.gramps dir, much like custom filters, books, and report styles are stored. Alex --=20 Alexander Roitman http://ebner.neuroscience.umn.edu/people/alex.html Dept. of Neuroscience, Lions Research Building 2001 6th Street SE, Minneapolis, MN 55455 Tel (612) 625-7566 FAX (612) 626-9201 |
From: Alex R. <sh...@al...> - 2004-05-24 05:05:42
|
Adam, On Mon, May 17, 2004 at 10:04:45PM -0500, Alex Roitman wrote: >=20 > On Mon, May 17, 2004 at 01:45:36PM -0400, Adam Stein wrote: > >[snip]=20 > > These new attributes aren't saved, so everytime I start Gramps and add = the=20 > > attribute to a new media object, it's new to Gramps all over again. An= =20 > > enhancement request would be to save new attributes between sessions. = This=20 > > would be useful since they would appear on the menus instead of me havi= ng to add=20 > > it each time. >=20 > This makes great sense. I added an RFE item to our tracker at sf.net, > you can monitor/post feedback here: > http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D955591&group= _id=3D25770&atid=3D385140 >=20 > When time permits, we should get it done. I'm thinking of adding an XML > file to ~/.gramps dir, much like custom filters, books, and report > styles are stored. This should be in the STABLE branch of CVS now, as well as in the stable snapshot on Monday. Let me know if you have problems, although now you should not need an attribute as a way to add a source reference to the image :-) Alex --=20 Alexander Roitman http://ebner.neuroscience.umn.edu/people/alex.html Dept. of Neuroscience, Lions Research Building 2001 6th Street SE, Minneapolis, MN 55455 Tel (612) 625-7566 FAX (612) 626-9201 |