Menu
▾
▴
[gphoto-patches] [ gphoto-Patches-1823151 ] Bring libmtp:s cache handling into ptp2
|
From: SourceForge.net <no...@so...> - 2007-11-12 23:07:07
|
Patches item #1823151, was opened at 2007-10-31 00:43 Message generated for change (Comment added) made by snirkel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=1823151&group_id=8874 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Linus Walleij (snirkel) Assigned to: Marcus Meissner (marcusmeissner) Summary: Bring libmtp:s cache handling into ptp2 Initial Comment: As it says. See patches, these are rather solid now I think. Only object deletion will affect the cache currently (actually I think this will fix a bug in ptp2 for gphoto, but not sure. You probably already remove the object handle but not the MTPprops I think) but you can easily add code to update/refresh cache whenever files/metadata is added/removed/updated. This is probably better done in library.c since you may want to queue up a few metadata changed before updating the cache. The fine thing is that MTPProps structs could be just renamed ObjectProps and hold any metadata tag obtained by traditional PTP commands or say Nikon acceleration if we want to so this is quite open-ended. ---------------------------------------------------------------------- >Comment By: Linus Walleij (snirkel) Date: 2007-11-13 00:06 Message: Logged In: YES user_id=473872 Originator: YES File Added: ptp.h.patch ---------------------------------------------------------------------- Comment By: Linus Walleij (snirkel) Date: 2007-11-13 00:06 Message: Logged In: YES user_id=473872 Originator: YES File Added: ptp.c.patch ---------------------------------------------------------------------- Comment By: Linus Walleij (snirkel) Date: 2007-11-05 21:47 Message: Logged In: YES user_id=473872 Originator: YES No hurries... If I get to understand the issues at hand a bit better I might be able to provide a full cache integration patch to library.c ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2007-11-05 21:18 Message: Logged In: YES user_id=48092 Originator: NO I have seen it, and I will review carefully when I have find a bit more time :/ (have currently not so much time and concentration left over) ---------------------------------------------------------------------- Comment By: Linus Walleij (snirkel) Date: 2007-10-31 00:47 Message: Logged In: YES user_id=473872 Originator: YES Oh it might need a patch to library.c too, since the object deletion function now remove the info. File Added: library.c.diff ---------------------------------------------------------------------- Comment By: Linus Walleij (snirkel) Date: 2007-10-31 00:43 Message: Logged In: YES user_id=473872 Originator: YES File Added: ptp.h.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=1823151&group_id=8874 |