Menu
▾
▴
[gphoto-patches] [ gphoto-Patches-1543622 ] Support for getting real largeish files
|
From: SourceForge.net <no...@so...> - 2006-08-21 05:48:18
|
Patches item #1543622, was opened at 2006-08-20 20:28 Message generated for change (Comment added) made by marcusmeissner You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=1543622&group_id=8874 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Linus Walleij (snirkel) Assigned to: Marcus Meissner (marcusmeissner) Summary: Support for getting real largeish files Initial Comment: This patch originally came to libmtp from Dan Aloni. (Ignore the part that considers the libmtp.c file.) It brings in support for getting large files off a device by passing a file descriptor to the getting functions. The patch looks OK to me and will AFAICS not disturb the logic. MTP devices have some real large files... like AVI movies. so mmap() etc will barf. But I regret forking ptp.c/ptp.h so will try to process it with you in gphoto2 first. I believe this kind of logic will be needed if libgphoto2 shall be able to handle real large files too some day so it won't hurt I think. A similar patch for *sending* large files should be expected if this one applies I guess. ---------------------------------------------------------------------- >Comment By: Marcus Meissner (marcusmeissner) Date: 2006-08-21 05:48 Message: Logged In: YES user_id=48092 I have merged the patch. Using such a method for libgphoto2 will need a different approach though I think and redesign. :/ ---------------------------------------------------------------------- Comment By: Linus Walleij (snirkel) Date: 2006-08-20 20:29 Message: Logged In: YES user_id=473872 BTW: original patch http://sourceforge.net/tracker/index.php?func=detail&aid=1538642&group_id=158745&atid=809063 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=1543622&group_id=8874 |