[gphoto-bugs] [ gphoto-Bugs-3590696 ] usb1 backend doesn't check libusb_init return code

[SourceForge.net <no...@so...>]

Bugs item #3590696, was opened at 2012-11-28 05:51
Message generated for change (Comment added) made by marcusmeissner
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108874&aid=3590696&group_id=8874

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: libgphoto2_port
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: parafin (parafin)
>Assigned to: Marcus Meissner (marcusmeissner)
Summary: usb1 backend doesn't check libusb_init return code

Initial Comment:
libusb_init function creates valid context only if it returns 0, see http://libusb.sourceforge.net/api-1.0/group__lib.html#ga9517c37281bba0b51cc62eba728be48b
But libgphoto2_port/libusb1/libusb1.c does not check for that (there's 2 lines with libusb_init call), which later results in segfault in case libusb initialization does fail (it may happen if kernel was built with USB stack disabled for example). See http://darktable.org/redmine/issues/9093 for real life occurrence of this bug.

----------------------------------------------------------------------

>Comment By: Marcus Meissner (marcusmeissner)
Date: 2012-11-29 01:27

Message:
i added !=0 checks and error exits to SVN.

thaqnks for the report! :)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108874&aid=3590696&group_id=8874