Menu
▾
▴
[gphoto-patches] [ gphoto-Patches-3467525 ] Patch for Fujifilm X10
|
From: SourceForge.net <no...@so...> - 2012-01-03 07:49:18
|
Patches item #3467525, was opened at 2011-12-30 10:25 Message generated for change (Comment added) made by kaaloo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=3467525&group_id=8874 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Fixed Priority: 5 Private: No Submitted By: Luis Arias (kaaloo) Assigned to: Marcus Meissner (marcusmeissner) Summary: Patch for Fujifilm X10 Initial Comment: The following patch produces much better behavior for the Fujifilm X10 under shotwell and avoids the following issue: http://redmine.yorba.org/issues/4512 There may be more to do since it also seems to stop automounting to work on Ubuntu oneiric, but that may be another issue. Anyhow importing pictures from the camera works great in Shotwell with a patched lib. === modified file camlibs/ptp2/library.c --- camlibs/ptp2/library.c 2011-04-30 16:38:30 +0000 +++ camlibs/ptp2/library.c 2011-12-30 18:11:47 +0000 @@ -1185,6 +1185,8 @@ {"Fuji:FinePix S2500HD", 0x04cb, 0x0209, 0}, /* salsaman <sal...@gm...> */ {"Fuji:FinePix Z700EXR", 0x04cb, 0x020d, 0}, + /* Luis Arias <ka...@gm...> */ + {"Fuji:FinePix X100", 0x04cb, 0x0263, 0}, {"Ricoh:Caplio R5 (PTP mode)", 0x05ca, 0x0110, 0}, {"Ricoh:Caplio GX (PTP mode)", 0x05ca, 0x0325, 0}, ---------------------------------------------------------------------- >Comment By: Luis Arias (kaaloo) Date: 2012-01-02 23:49 Message: Bingo! Just one gphoto2 --get-all-thumbnails is enough to cause the camera to go into an invalid state and subsequent commands give the PTP I/O error. I'll file a separate bug report with the log files. ---------------------------------------------------------------------- Comment By: Luis Arias (kaaloo) Date: 2012-01-02 23:35 Message: Oh gphoto2 -L runs fine N times in a row, the camera gets put into an invalid state by something shotwell does when it displays the previews. I'll try mixing with gphoto2 -P and get back here. ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2012-01-02 23:31 Message: if the camera only allows one round of accesses and then hangs, its a bug :/ it might access files on the camera it shoul;d not access for instance. you can also try reproducing with the commandline tool, which allows better debugging. gphoto2 -L (list all files) gphoto2 -L and or mixed with gphoto2 -P (download all files) ---------------------------------------------------------------------- Comment By: Luis Arias (kaaloo) Date: 2012-01-02 23:27 Message: Marcus, thanks for your help in this! I'm starting to narrow things down. I disabled the gphoto2 gvfs backend by running sudo chmod -x /usr/lib/gvfs/gvfs-gphoto2-volume-monitor So now this is out of the picture. What I notice is that the shotwell issue persists and actually gphoto2 --list-files will fail with the same PTP I/O error right after shotwell has displayed the photo previews. My next step is to take a look at the shotwell code and see exactly what libgphoto2 api it is calling for this to see if I can reproduce the issue with command line gphoto2. If you have any other suggestions please let me know! I'll update the shotwell reports with this info. ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2012-01-02 12:51 Message: there is no need for different flags. I pretty much suspect it is yet again the gvfs gphoto2 slave. ---------------------------------------------------------------------- Comment By: Luis Arias (kaaloo) Date: 2012-01-02 12:46 Message: Please ignore this patch for the moment as I am investigating the issue further. Upon rebooting and trying again today, I experienced the same behavior as described here: http://redmine.yorba.org/issues/4512 so there is more this than meets the eye. I am running more tests with different PTP flag combinations but it may be interaction with another component like gnome_vfs that may be the cause. I have reported the end user bug here in launchpad so it gets tracked. https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/910964 ---------------------------------------------------------------------- Comment By: Hub Figuière (hfiguiere) Date: 2012-01-01 12:16 Message: re-opening (see last comment) ---------------------------------------------------------------------- Comment By: Luis Arias (kaaloo) Date: 2012-01-01 04:43 Message: Oops, its definitely the X10 not the X100. Sorry my bad. ---------------------------------------------------------------------- Comment By: Hub Figuière (hfiguiere) Date: 2011-12-31 11:09 Message: I don't understand. The bug reports say it is for the X10, but the patch add the X100.... What is it? ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2011-12-31 03:09 Message: applied, thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=3467525&group_id=8874 |