Re: Key layout and exterior X window patches

[Daniel J S. <dan...@ie...>]

Ethan Merritt wrote:
> On Wednesday 29 June 2005 02:42 am, Daniel J Sebald wrote:
> 
>>And with that, I think now is as good a time as any to consider the key layout patch
> 
> 
> Looks basically OK.  I'm fine with it.
> But there are some compile-time warnings,

Aee, I keep forgetting to turn on warnings.  Can we turn warnings on by default?  :)

 and at least part of
> the original syntax seems to have broken:  set key <position>

Well, this is what Petr suggested the other day, i.e., that it should be

set key at <position>

His point was that the position alone didn't give enough indication that it in fact meant position; whereas "at" inherently suggests position.  Furthermore, "at" is consistent with

 Syntax:
       set label {<tag>} {"<label text>"} {at <position>}

Either way is fine with me.  Which do list members prefer?

> 
> 
> graphics.c:1108: warning: unused variable `keybox_half_height'
> graphics.c:1109: warning: unused variable `keybox_half_width'
> save.c:321: warning: enumeration value `CENTRE' not handled in switch
> save.c:329: warning: enumeration value `JUST_CENTRE' not handled in switch

I'll fix those.

> 
> cd tutorial; make clean; make
> 
> set key 15,-10
>         ^
> "eg3.plt", line 7: unknown key option

Oh yeah, I see... eg6.plt (tutorial.tex), bivariat.dem and electron.dem also have this.  I will fix these if the list thinks "at" should be required.

Dan