Re: Key layout patch

[Daniel J S. <dan...@ie...>]

Daniel J Sebald wrote:
> #if 0
>     /* Dan Sebald 21jun2005:  Hans had added this hunk of code after
>      * a new key patch was created.  It was placed somewhere that made
>      * no sense in the new patch.  Sorry if this has created a bug,
>      * but I can't exactly recall what the issue was.  Perhaps if
>      * that bug crops up again we can find a proper home for this code.
>      */
>         /* HBB 20040725: leave manually set bmargin alone */
>         if (bmargin < 0) {
>             ybot += key_entry_height * key_rows
>             + (int) (t->v_char * (ktitl_lines + 1));
>             ybot += (int) (key->height_fix * t->v_char);
>         }
> #endif

OK, I've looked at this hunk of code.  It appears I've already accounted for the above with the new logic:

if (key->flag == KEY_AUTO_PLACEMENT && key->region == GPKEY_EXTERIOR) {
    if (key->stack_dir == GPKEY_HORIZONTAL || key->hpos == CENTRE) {
	if (key->vpos == JUST_BOT && bmargin < 0) {
	    ybot += key_entry_height * key_rows
		+ (int) (t->v_char * (ktitl_lines + 1));
	    ybot += (int) (key->height_fix * t->v_char);
	} else if (key->vpos == JUST_TOP && tmargin < 0) {
	    ytop -= key_entry_height * key_rows
		+ (int) (t->v_char * (ktitl_lines + 1));
	    ytop += (int) (key->height_fix * t->v_char);
	}
    }

That is, flag==KEY_AUTO_PLACEMENT and region==GPKEY_EXTERIOR and vpos==JUST_BOT and hpos==CENTRE is now the equivalent of the old TUNDER.

So, I've removed that hunk of code above which was commented out anyway.  If the developers disagree with behavior it is very easy to fix the current tests at a later date.  I think it should do fine for now.

Dan