Re: image/binary patch complete

[Daniel J S. <dan...@ie...>]

Ethan A Merritt wrote:

>On Friday 27 August 2004 12:05 am, mi...@ph... wrote:
>  
>
>>>The patch has been uploaded to the SourceForge site.
>>>("with_image_26aug2004.patch" and "with_image_data_24aug2004.patch" are
>>>      
>>>
>>It works very well for me. I propose to commit the patch into CVS.
>>    
>>
>
>I like the layout of this version much better than the earlier ones.
>I think there are some places still that can be cleaned up, but I hope
>there will be adequate opportunity for that afterwards.
>So adding it to CVS is OK with me.
>  
>

Yes, there are several things that can be cleaned up yet, especially if 
the #ifdef .. #else .. #endif constructs are untangled.  And as always, 
one codes something up and then later realizes a way of improving 
things.  Passing necessary information into the datafile.c routines is 
the one thing that clearly needs a standard.  I'm indifferent about 
that, as it can be done several ways.

Dan