Re: proposal for cvs'ing "with image"

[Daniel J S. <dan...@ie...>]

Daniel J Sebald wrote:

>
>
> Ethan Merritt wrote:
>
>> On Thursday 12 August 2004 12:00 am, mi...@ph... wrote:
>>  
>>
>>> I propose the patch gets committed into cvs.
>>>   
>>
>>
>> I also find this comment in post.trm a little alarming:
>>
>> +    /*** FIX ME!!! *****
>> +     *
>> +     * I had to put this grestore command here, otherwise the
>> +     * case where multiple images are plotted on the same graph
>> +     * fails after the first image.  I have no idea what it does.
>> +     * I'm guessing it restores the stack or something and that
>> +     * it must be paired with gsave.  It seems to me there is a
>> +     * gsave in the palette routine that doesn't have a matching
>> +     * grestore.  Could that be the problem?
>> +     */
>> +    fputs("grestore\n", gpoutfile);
>>
>>  
>>
>
> Hey, that's one of those "that's the way it works" sort of things.  
> :-)  I noted what at the time probably seemed like the source of 
> problems. However, a year ago, and even now, if I explained to the 
> list I thought there was a grestore missing in some PostScript code 
> that seemed to work fine the way it was, the reaction would have been 
> "don't believe it". 


Sorry, my bad.  That message is just some bogus note from when I first 
did the code.  There *should* be a grestore there because some of the 
image commands alter the graphics state, probably.  The state was 
probably at the top of the stack so "grestore" without a matched "gsave" 
didn't make a difference.  I put a "gsave" near the top of the routine 
to ensure a match.

Dan