Re: Plot placement, revisited

[Ethan M. <merritt@u.washington.edu>]

On Saturday 24 July 2004 07:44 pm, Daniel J Sebald wrote:
> typedef enum H_JUSTIFY {
>     H_LEFT,
>     H_CENTRE,
>     H_RIGHT
> } H_JUSTIFY;
> 
> typedef enum JUSTIFY {
>     LEFT,
>     CENTRE,
>     RIGHT
> } JUSTIFY;
> 

Be careful if you consolidate these admittedly redundant definitions.

Some of them depend on the ordering of the enums,
which of course entirely violates the spirit of using an enum
in the first place.

For example, see this alarming comment in term_api.h

/* this order means we can use  x-(just*strlen(text)*t->h_char)/2 if
 * term cannot justify
 */
typedef enum JUSTIFY {
    LEFT,
    CENTRE,
    RIGHT
} JUSTIFY;



-- 
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195