From: Hans-Bernhard B. <br...@ph...> - 2004-07-22 00:35:14
|
On Wed, 21 Jul 2004, Ethan Merritt wrote: > On Wednesday 21 July 2004 04:44 am, Hans-Bernhard Broeker wrote: > > > > Well, to put it none too subtly: terminal 'dumb' doesn't support PM3D > > function filled_polygon, so graphics.c:1810 is calling NULL pointer. > > Instant crash guaranteed. > > I will fix the crash. But what behavior is preferred in this case? > > approximate with rectangles or yerrorbars rather than polygons > (consistent with documentation), Hmm... what with your recent joining of filledboxes and filledcurves, can filled rectangles still be supported by a terminal driver if there are no filledcurves? At least for the case at hand (dumb.trm), term->filled_box() isn't supported either. Whereas an attempt to dense-fill yerrorbars might well come out too huge in file size to be useful. > plot one or both of the curves with lines only > (consistent with previous behaviour of filledcurves although > not what the docs say), IMHO that feels more sensible. If the terminal can't fill, don't try to coerce it. We could change the docs instead. > or > > int_warn(NO_CARET,"plotting style not available for this terminal") That would have to be an int_error(), I think. That is, unless you intend to avoid trying to call nonexistant terminal entries by some additional code. -- Hans-Bernhard Broeker (br...@ph...) Even if all the snow were burnt, ashes would remain. |