From: Ethan M. <merritt@u.washington.edu> - 2004-07-08 16:43:52
|
On Thursday 08 July 2004 08:59 am, Daniel J Sebald wrote: > > I would be a taker, but I'm not sure Ethan has completed his changes. As I said, I have some more tweaks that I will feed in after testing. But they are both localized and small, so I don't think that you should hold off just because of that. > The patch I'm proposing is the "wth image", "with rgbimage", and "binary > datafile" stuff, but I should probably say a few things about it on the > list so people know what to expect. My main concern is that you carefully check that your patch does not undo some of the code changes that my recent round of patches added. In fact, I suggest that is a general requirement for patches added in this current round. Major changes on top of other major changes are a bit tricky. Big patches should come with a demo/test-case so that it is easy to verify it still works later on. For my recent patches these are: fillbetween.dem datatstrings.dem histograms.dem histograms2.dem (currently shows a minor bug is present) We also might want a policy that new features default to --enable-<feature> to insure that they are well-tested for compatibility. Later on we can decide if some are too specialized or so big that they should require deliberate selection at ./configure time. -- Ethan A Merritt merritt@u.washington.edu Biomolecular Structure Center Mailstop 357742 University of Washington, Seattle, WA 98195 |