Re: Mac OS X driver.

[Hans-Bernhard B. <br...@ph...>]

On Sun, 28 Mar 2004, Ethan A Merritt wrote:

> On Sunday 28 March 2004 13:35, Per Persson wrote:
> > A warning unrelated to aquaterm/OS X I think:
> > 	../term/fig.trm: In function `FIG_arrow':
> > 	../term/fig.trm:785: warning: comparison is always false due to
> > limited range of data type
> > 	../term/fig.trm:817: warning: comparison is always false due to
> > limited range of data type
> 
> Yes, that's the same bug I reported a few days ago.
> It is due to an improper use of TBOOLEAN for one of the
> term->arrow parameters that wants to take on numical
> values.  Hans, are you working on that one?

I have a patched version ready to commit, but am a bit hesitant to do so.
This is a fundamental change to the definition of the terminal API,
something I've been opposing for a while now when others suggested
anything like that.  But then, the actual change to the API has already
been done a while ago, when this abuse of a boolean argument was 
introduced.  I.e. this change just adapts the formal type to what the
code actually has been doing for quite a while.

Ah heck, I'll just check it in and package up a new snapshot, then.


-- 
Hans-Bernhard Broeker (br...@ph...)
Even if all the snow were burnt, ashes would remain.